[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 130193: [cmake]: De-duplicate "else" to fix build with cmake-3.9
From: Rolf Eike Beer <kde () opensource ! sf-tec ! de>
Date: 2017-07-20 21:05:44
Message-ID: 20170720210544.30757.38674 () mimi ! kde ! org
[Download RAW message or body]
--===============8337425040458475300==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130193/#review103463
-----------------------------------------------------------
Ship it!
While at it, please also remove the arguments from the else() and endif() calls.
- Rolf Eike Beer
On Juli 20, 2017, 7:59 nachm., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130193/
> -----------------------------------------------------------
>
> (Updated Juli 20, 2017, 7:59 nachm.)
>
>
> Review request for kdelibs and Frank Osterfeld.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Otherwise it errors out with:
> "CMake Error at kdeui/CMakeLists.txt:316 (else): A duplicate ELSE
> command was found inside an IF block."
> Also adjust indentation to match the surrounding lines.
>
>
> Diffs
> -----
>
> kdeui/CMakeLists.txt d6ec8b47e9af686441ab5ab761be9ff424cbb556
>
> Diff: https://git.reviewboard.kde.org/r/130193/diff/
>
>
> Testing
> -------
>
> Builds fine with cmake-3.9.0.
>
>
> Thanks,
>
> Heiko Becker
>
>
--===============8337425040458475300==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130193/">https://git.reviewboard.kde.org/r/130193/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">While \
at it, please also remove the arguments from the else() and endif() calls.</p></pre> \
<br />
<p>- Rolf Eike Beer</p>
<br />
<p>On Juli 20th, 2017, 7:59 nachm. UTC, Heiko Becker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs and Frank Osterfeld.</div>
<div>By Heiko Becker.</div>
<p style="color: grey;"><i>Updated Juli 20, 2017, 7:59 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Otherwise it errors out with: "CMake Error at \
kdeui/CMakeLists.txt:316 (else): A duplicate ELSE command was found inside an IF \
block." Also adjust indentation to match the surrounding lines.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds fine with cmake-3.9.0.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: \
grey">(d6ec8b47e9af686441ab5ab761be9ff424cbb556)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130193/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8337425040458475300==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic