From kde-core-devel  Tue May 16 18:05:17 2017
From: Rolf Eike Beer <kde () opensource ! sf-tec ! de>
Date: Tue, 16 May 2017 18:05:17 +0000
To: kde-core-devel
Subject: Re: kdereview: ksmtp
Message-Id: <2627123.Egs0gu0Qom () daneel ! sf-tec ! de>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=149495798108894
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart1555176.KXh9n2bFog"

--nextPart1555176.KXh9n2bFog
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Am Donnerstag, 11. Mai 2017, 17:03:01 schrieb Daniel Vr=E1til:
> Hi,
>=20
> please review ksmtp, which is now in kdereview.

=2Dthe CMakeLists.txt has a mix of spaces inside () or not

=2Din loginjob, line 173, you check for code 25. Should this be 250? Or i=
s that=20
25*? Where is ServerResponse actually defined, I only see the header.

=2Ddoes that support pipelining? I don't see any sync points, so I guess =
not.

=2Dthere is a longstanding bug in KMail that it violates the RfC when it =
has a=20
problem with authentication (e.g. password rejected), that is does not=20=

properly QUIT the SMTP session, but just closes the socket. Is that pro=
perly=20
handled?

Greetings,

Eike
--nextPart1555176.KXh9n2bFog
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlkbP2EACgkQXKSJPmm5/E72xQCcCE7YXCmL7kvtrtAMnNsImkae
o/4AoIYYY7FXStAmldCgOPNC5ANvLz4c
=t0+K
-----END PGP SIGNATURE-----

--nextPart1555176.KXh9n2bFog--