From kde-core-devel Wed Feb 08 19:18:49 2017 From: Antonio Larrosa Jimenez Date: Wed, 08 Feb 2017 19:18:49 +0000 To: kde-core-devel Subject: Re: Review Request 129935: Fix build for GCC 7 Message-Id: <20170208191849.23155.81581 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=148658157005068 --===============3060987038615263224== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129935/ ----------------------------------------------------------- (Updated Feb. 8, 2017, 7:18 p.m.) Status ------ This change has been marked as submitted. Review request for kdelibs. Repository: kdelibs Description ------- This fixes building with GCC 7 which fails with "ISO C++ forbids comparison between pointer and integer [-fpermissive]" Diffs ----- kdeui/windowmanagement/netwm.cpp 0c8b0a7d455f40327a03c685b7a7ff2beda901e0 Diff: https://git.reviewboard.kde.org/r/129935/diff/ Testing ------- I checked that building with GCC 7 shows: /usr/src/packages/BUILD/kdelibs-4.14.28/kdeui/windowmanagement/netwm.cpp: In member function 'void NETWinInfo::update(const long unsigned int*)': /usr/src/packages/BUILD/kdelibs-4.14.28/kdeui/windowmanagement/netwm.cpp:4371:48: error: ISO C++ forbids comparison between pointer and integer [-fpermissive] p->blockCompositing = (data_ret != None); ^~~~ and the submitted commit fixes this. Thanks, Antonio Larrosa Jimenez --===============3060987038615263224== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129935/

This change has been marked as submitted.

Review request for kdelibs.

By Antonio Larrosa Jimenez.

Updated Feb. 8, 2017, 7:18 p.m.

Repository: kdelibs

Description

This fixes building with GCC 7 which fails with
"ISO C++ forbids comparison between pointer and integer [-fpermissive]"

Testing

I checked that building with GCC 7 shows:
/usr/src/packages/BUILD/kdelibs-4.14.28/kdeui/windowmanagement/netwm.cpp: In member function 'void NETWinInfo::update(const long unsigned int*)':
/usr/src/packages/BUILD/kdelibs-4.14.28/kdeui/windowmanagement/netwm.cpp:4371:48: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
             p->blockCompositing = (data_ret != None);
                                                ^~~~
and the submitted commit fixes this.

Diffs

kdeui/windowmanagement/netwm.cpp (0c8b0a7d455f40327a03c685b7a7ff2beda901e0)

--===============3060987038615263224==--