[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 122653: Set permissions for links in remote:, necessary for correct visualization
From: Stefan_Brüns <stefan.bruens () rwth-aachen ! de>
Date: 2017-02-08 13:28:07
Message-ID: 20170208132807.25963.81723 () mimi ! kde ! org
[Download RAW message or body]
--===============1889985464242488467==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122653/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 1:28 p.m.)
Status
------
This change has been discarded.
Review request for kdelibs, Plasma and Christoph Feck.
Bugs: 339193
http://bugs.kde.org/show_bug.cgi?id=339193
Repository: kde-runtime
Description
-------
KFileItem uses UDS_ACCESS to determine permissions. Readability is
subsequently used to create the list of overlay icons.
CCBUG: 339193
Diffs
-----
kioslave/remote/remoteimpl.cpp 5d973c6c1b6c31b7f3107d0d15805ef04bfdd661
Diff: https://git.reviewboard.kde.org/r/122653/diff/
Testing
-------
dolphin remote:
-> no lock icon on smb:, mtp:, ... links
Thanks,
Stefan Brüns
--===============1889985464242488467==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122653/">https://git.reviewboard.kde.org/r/122653/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs, Plasma and Christoph Feck.</div>
<div>By Stefan Brüns.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2017, 1:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=339193">339193</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KFileItem uses UDS_ACCESS to determine permissions. Readability is \
subsequently used to create the list of overlay icons.
CCBUG: 339193</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">dolphin remote:
-> no lock icon on smb:, mtp:, ... links</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/remote/remoteimpl.cpp <span style="color: \
grey">(5d973c6c1b6c31b7f3107d0d15805ef04bfdd661)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122653/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1889985464242488467==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic