[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2017-02-07 9:13:05
Message-ID: 20170207091305.23155.26189 () mimi ! kde ! org
[Download RAW message or body]
--===============2386790409957190134==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/#review102439
-----------------------------------------------------------
applets/systemloadviewer/package/contents/config/main.xml (line 52)
<https://git.reviewboard.kde.org/r/129917/#comment68316>
I think it's overkill to enable this by default, given it's only interesting to a \
limited group of users, and others probably won't understand it, or its utility.
- Sebastian Kügler
On Feb. 6, 2017, 8:05 p.m., Pascal VITOUX wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129917/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 8:05 p.m.)
>
>
> Review request for kde-workspace and Plasma.
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and \
> 'cache/writeback' infos from ksysguard 5.9.0
> The monitor displays the dirty + writeback amount proportionaly scaled with the \
> maximal amount reached, until the remaining dirty amount goes below a minimal \
> threshold of 10MB.
> An interesting usecase is to show the real progress of a datas transfer to a slow \
> storage device like a USB drive.
>
> Diffs
> -----
>
> applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa
> applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15
> applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b
> applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649
>
> Diff: https://git.reviewboard.kde.org/r/129917/diff/
>
>
> Testing
> -------
>
> I use it since several months without issue.
>
>
> File Attachments
> ----------------
>
> panel applets : circular, bar and compact bar monitors
> https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/9067d5be-c1b4-4168-be20-76965b4a40ac__panel.png
> desktop applet, with tooltip
> https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/4eb7a092-7368-448f-8385-7c18ab298389__desktop-tooltip.png
> desktop applet, circular monitors
> https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/26f769fb-85e9-45f7-90e6-55035770be6e__desktop-circular.png
>
>
> Thanks,
>
> Pascal VITOUX
>
>
--===============2386790409957190134==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129917/">https://git.reviewboard.kde.org/r/129917/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129917/diff/2/?file=491019#file491019line52" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/systemloadviewer/package/contents/config/main.xml</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">52</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nt"><default></span>true<span \
class="nt"></default></span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think it's overkill to enable this by default, given it's only interesting to a \
limited group of users, and others probably won't understand it, or its \
utility.</p></pre> </div>
</div>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On February 6th, 2017, 8:05 p.m. UTC, Pascal VITOUX wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kde-workspace and Plasma.</div>
<div>By Pascal VITOUX.</div>
<p style="color: grey;"><i>Updated Feb. 6, 2017, 8:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add a cache monitor to the System Load Viewer applet \
using 'cache/dirty' and 'cache/writeback' infos from ksysguard 5.9.0</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The monitor displays the dirty + writeback amount proportionaly scaled with \
the maximal amount reached, until the remaining dirty amount goes below a minimal \
threshold of 10MB.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">An interesting usecase is to show the \
real progress of a datas transfer to a slow storage device like a USB \
drive.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I use it since several months without issue.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemloadviewer/package/contents/config/main.xml <span style="color: \
grey">(6bf16d5aa)</span></li>
<li>applets/systemloadviewer/package/contents/ui/ColorSettings.qml <span \
style="color: grey">(b9247aa15)</span></li>
<li>applets/systemloadviewer/package/contents/ui/GeneralSettings.qml <span \
style="color: grey">(f1ab40a1b)</span></li>
<li>applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml <span \
style="color: grey">(5a0bc0649)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129917/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/9067d5be-c1b4-4168-be20-76965b4a40ac__panel.png">panel \
applets : circular, bar and compact bar monitors</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/4eb7a092-7368-448f-8385-7c18ab298389__desktop-tooltip.png">desktop \
applet, with tooltip</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/26f769fb-85e9-45f7-90e6-55035770be6e__desktop-circular.png">desktop \
applet, circular monitors</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2386790409957190134==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic