[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2017-01-23 12:04:57
Message-ID: 20170123120457.19722.97735 () mimi ! kde ! org
[Download RAW message or body]
--===============6656063398178881813==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Jan. 22, 2017, 10:20 p.m., Albert Astals Cid wrote:
> > Sebas should I commited this? After 3 years i'm not sure kde-runtime is the best \
> > thing to update in it's almost frozen state.
>
> Sebastian Kügler wrote:
> I'd just discard it. I don't think anybody is releasing kde-runtime anyway, and the \
> proper way to fix this is to do it in QtQuick component's Label. Thanks for \
> cleaning up, though!
> Albert Astals Cid wrote:
> I do release kde-runtime
>
> http://download.kde.org/stable/applications/16.12.1/src/kde-runtime-16.12.1.tar.xz.mirrorlist
>
Ah, okay. Up to you then. I think this patch is rather safe, but I wouldn't want to \
get support calls for a regression...
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114437/#review102202
-----------------------------------------------------------
On Dec. 13, 2013, 3:37 p.m., Leszek Lesner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114437/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 3:37 p.m.)
>
>
> Review request for KDE Runtime.
>
>
> Repository: kde-runtime
>
>
> Description
> -------
>
> This adds a right click context menu for PlasmaComponents.TextField which allows to \
> cut, copy and paste text.
>
> Diffs
> -----
>
> plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10a3d1f
>
> Diff: https://git.reviewboard.kde.org/r/114437/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Leszek Lesner
>
>
--===============6656063398178881813==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114437/">https://git.reviewboard.kde.org/r/114437/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 22nd, 2017, 10:20 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Sebas should I commited this? After 3 years i'm not \
sure kde-runtime is the best thing to update in it's almost frozen state.</p></pre> \
</blockquote>
<p>On January 23rd, 2017, 11:51 a.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd \
just discard it. I don't think anybody is releasing kde-runtime anyway, and the \
proper way to fix this is to do it in QtQuick component's Label. Thanks for cleaning \
up, though!</p></pre> </blockquote>
<p>On January 23rd, 2017, noon UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I do \
release kde-runtime</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: \
inherit;">http://download.kde.org/stable/applications/16.12.1/src/kde-runtime-16.12.1.tar.xz.mirrorlist</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah, \
okay. Up to you then. I think this patch is rather safe, but I wouldn't want to get \
support calls for a regression...</p></pre> <br />
<p>- Sebastian</p>
<br />
<p>On December 13th, 2013, 3:37 p.m. UTC, Leszek Lesner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Leszek Lesner.</div>
<p style="color: grey;"><i>Updated Dec. 13, 2013, 3:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adds a right click context menu for PlasmaComponents.TextField \
which allows to cut, copy and paste text. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/plasmacomponents/qml/TextField.qml <span style="color: \
grey">(10a3d1f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114437/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6656063398178881813==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic