[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 122987: Allow user to specify path to myspell dictionary files
From: Eugene Shalygin <eugene.shalygin () gmail ! com>
Date: 2017-01-21 0:46:41
Message-ID: 20170121004641.31352.20664 () mimi ! kde ! org
[Download RAW message or body]
--===============3308230543766452546==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
-----------------------------------------------------------
(Updated Jan. 21, 2017, 12:46 a.m.)
Status
------
This change has been discarded.
Review request for KDE Frameworks and kdelibs.
Repository: sonnet
Description
-------
Not on all systems myspell dictionaries are located in /usr/share/myspell/dicts/, which is hardcoded in \
the hunspell plugin sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user define \
this path.
Diffs
-----
src/plugins/hunspell/CMakeLists.txt e35fe8c
src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION
src/plugins/hunspell/hunspellclient.cpp 46963ef
src/plugins/hunspell/hunspelldict.cpp fda4a4c
Diff: https://git.reviewboard.kde.org/r/122987/diff/
Testing
-------
hunspell plugin began to work on Gentoo
Thanks,
Eugene Shalygin
--===============3308230543766452546==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122987/">https://git.reviewboard.kde.org/r/122987/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; \
-moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and kdelibs.</div>
<div>By Eugene Shalygin.</div>
<p style="color: grey;"><i>Updated Jan. 21, 2017, 12:46 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
sonnet
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Not on all systems myspell dictionaries are \
located in /usr/share/myspell/dicts/, which is hardcoded in the hunspell plugin sources. For instance, \
on Gentoo it is /usr/share/myspell/. So let the user define this path.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">hunspell plugin began to work on \
Gentoo</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/hunspell/CMakeLists.txt <span style="color: grey">(e35fe8c)</span></li>
<li>src/plugins/hunspell/config-hunspellplugin.h.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/plugins/hunspell/hunspellclient.cpp <span style="color: grey">(46963ef)</span></li>
<li>src/plugins/hunspell/hunspelldict.cpp <span style="color: grey">(fda4a4c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122987/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3308230543766452546==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic