[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 129233: [kdelibs] Make Qt4 WebKit optional (default on)
From: Andreas Sturmlechner <andreas.sturmlechner () gmail ! com>
Date: 2016-10-21 22:10:40
Message-ID: 20161021221040.24464.11205 () mimi ! kde ! org
[Download RAW message or body]
--===============0679769080983162735==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Oct. 21, 2016, 5:59 a.m., Martin Gräßlin wrote:
> > I think that's too much a change for a bug-fix only library.
Is it, really? There's buildsystem changes only, akin to existing switches, and default shipment of \
kdelibs remains 100% the same, although arguably it's a bigger change than recent strigi optionalisation. \
The patch has been in use for several releases already, at least Fedora is doing something similar and \
Debian is also on the path to remove Qt4WebKit.
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129233/#review100189
-----------------------------------------------------------
On Oct. 20, 2016, 8:50 p.m., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129233/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2016, 8:50 p.m.)
>
>
> Review request for kdelibs.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Provide a switch for distributions to disable build of kdewebkit and
> kdewebkit-widgets, to support efforts on getting rid of Qt4 WebKit.
>
> The implications of this for KDE Applications packages are, at this
> point, negligible:
>
> kde-runtime/drkonqi
> kde-runtime/kioslave (htmlthumbnail, removable with little effort)
> kde-runtime/plasma (with rdeps: kqtquickcharts, ktouch)
> pykde4 (with rdep: kajongg)
>
> The following two listed for completeness, even if not part of
> current KDE Applications releases anymore:
> kdepim-4
> marble-4
>
>
> Diffs
> -----
>
> CMakeLists.txt f1266655c512474626b68565a2830dae5828bf57
> kdewidgets/CMakeLists.txt 51536017ac0a3a86e164e30b80840a89aa3a8248
> plasma/CMakeLists.txt b9214388d72122ae9c5709b6956a8b8e13ccd3aa
>
> Diff: https://git.reviewboard.kde.org/r/129233/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andreas Sturmlechner
>
>
--===============0679769080983162735==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129233/">https://git.reviewboard.kde.org/r/129233/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 21st, 2016, 5:59 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I think that's too much a change for a bug-fix only library.</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Is it, really? There's buildsystem changes only, akin to existing \
switches, and default shipment of kdelibs remains 100% the same, although arguably it's a bigger change \
than recent strigi optionalisation. The patch has been in use for several releases already, at least \
Fedora is doing something similar and Debian is also on the path to remove Qt4WebKit.</p></pre> <br />
<p>- Andreas</p>
<br />
<p>On October 20th, 2016, 8:50 p.m. UTC, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated Oct. 20, 2016, 8:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Provide a switch for distributions to \
disable build of kdewebkit and kdewebkit-widgets, to support efforts on getting rid of Qt4 WebKit.
The implications of this for KDE Applications packages are, at this
point, negligible:
kde-runtime/drkonqi
kde-runtime/kioslave (htmlthumbnail, removable with little effort)
kde-runtime/plasma (with rdeps: kqtquickcharts, ktouch)
pykde4 (with rdep: kajongg)
The following two listed for completeness, even if not part of
current KDE Applications releases anymore:
kdepim-4
marble-4</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(f1266655c512474626b68565a2830dae5828bf57)</span></li>
<li>kdewidgets/CMakeLists.txt <span style="color: \
grey">(51536017ac0a3a86e164e30b80840a89aa3a8248)</span></li>
<li>plasma/CMakeLists.txt <span style="color: \
grey">(b9214388d72122ae9c5709b6956a8b8e13ccd3aa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129233/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0679769080983162735==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic