[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 108308: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of W
From: David Edmundson <david () davidedmundson ! co ! uk>
Date: 2016-09-22 20:35:08
Message-ID: 20160922203508.26270.32653 () mimi ! kde ! org
[Download RAW message or body]
--===============7556138104616945699==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/108308/#review99455
-----------------------------------------------------------
Closing as this review request is more than 2 years old.
If it still applies to current Plasma please reopen this review request. Thanks
- David Edmundson
On Jan. 16, 2013, 2:37 p.m., Yichao Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/108308/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2013, 2:37 p.m.)
>
>
> Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> When setting "Keep window thumbnails" to "Always (Breaks minimization)", kwin will \
> keep WM_STATE to be NORMAL when a client is minimized while including \
> _NET_WM_STATE_HIDDEN in its _NET_WM_STATE, as confirmed by ICCCM[1] and Extended \
> Window Manager Hints[2]. However, apart from the expected result (breaks \
> minimization: the client will continue to refresh its content) the minimized window \
> is not shown as minimized in icontasks and pager.
> These two plasma addons (and probably other addons as well) uses \
> KWindowInfo::isMinimized to determine whether the window is minimized. However, \
> this function threat all window that are not Iconic (WM_STATE != ICONIC) as not \
> minimized, in contradiction to the "Extended window manager hints" which says, \
> "Pagers and similar applications should use _NET_WM_STATE_HIDDEN instead of \
> WM_STATE to decide whether to display a window in miniature representations of the \
> windows on a desktop."
> This patch correct this behavior and therefore correct the behavior of both pager \
> and icontasks in this situation.
> [1] http://tronche.com/gui/x/icccm/sec-4.html#s-4.1.3.1
> [2] http://standards.freedesktop.org/wm-spec/wm-spec-1.3.html#id2731936
>
>
> Diffs
> -----
>
> kdeui/windowmanagement/kwindowinfo_x11.cpp d983c9a
>
> Diff: https://git.reviewboard.kde.org/r/108308/diff/
>
>
> Testing
> -------
>
> Compiled, pager and icontasks shows minimized windows correctly.
> Also tested on openbox (+plasma's pager) by "Xuetian Weng".
>
>
> Thanks,
>
> Yichao Yu
>
>
--===============7556138104616945699==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/108308/">https://git.reviewboard.kde.org/r/108308/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Closing as this review request is more than 2 years old.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If it still applies to current Plasma please reopen this review request. \
Thanks</p></pre> <br />
<p>- David Edmundson</p>
<br />
<p>On January 16th, 2013, 2:37 p.m. UTC, Yichao Yu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, and Martin \
Gräßlin.</div> <div>By Yichao Yu.</div>
<p style="color: grey;"><i>Updated Jan. 16, 2013, 2:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When setting "Keep window thumbnails" to "Always (Breaks \
minimization)", kwin will keep WM_STATE to be NORMAL when a client is minimized \
while including _NET_WM_STATE_HIDDEN in its _NET_WM_STATE, as confirmed by ICCCM[1] \
and Extended Window Manager Hints[2]. However, apart from the expected result (breaks \
minimization: the client will continue to refresh its content) the minimized window \
is not shown as minimized in icontasks and pager.
These two plasma addons (and probably other addons as well) uses \
KWindowInfo::isMinimized to determine whether the window is minimized. However, this \
function threat all window that are not Iconic (WM_STATE != ICONIC) as not minimized, \
in contradiction to the "Extended window manager hints" which says, \
"Pagers and similar applications should use _NET_WM_STATE_HIDDEN instead of \
WM_STATE to decide whether to display a window in miniature representations of the \
windows on a desktop."
This patch correct this behavior and therefore correct the behavior of both pager and \
icontasks in this situation.
[1] http://tronche.com/gui/x/icccm/sec-4.html#s-4.1.3.1
[2] http://standards.freedesktop.org/wm-spec/wm-spec-1.3.html#id2731936
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled, pager and icontasks shows minimized windows correctly. Also \
tested on openbox (+plasma's pager) by "Xuetian Weng".</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/windowmanagement/kwindowinfo_x11.cpp <span style="color: \
grey">(d983c9a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/108308/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7556138104616945699==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic