[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 127823: Allow building without strigi on Linux
From: Johannes Huber <johu () gentoo ! org>
Date: 2016-05-23 16:38:04
Message-ID: 20160523163804.12263.17513 () mimi ! kde ! org
[Download RAW message or body]
--===============9164576113392932806==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Mai 3, 2016, 2:58 nachm., Aleix Pol Gonzalez wrote:
> > Why touch the `if(WIN32)` though? If needed, just make it optional on all \
> > platforms.
>
> Antonio Rojas wrote:
> That's what I'm doing... Currently it's only optional on WIN32, I'm changing it to \
> be optional regardless of the platform
> Aleix Pol Gonzalez wrote:
> Eh... fair enough.
>
> +1
>
> Andreas Sturmlechner wrote:
> works for me during the last days. but is there a list of depending packages other \
> than the one from Fedora? \
> https://lists.fedoraproject.org/archives/list/kde@lists.fedoraproject.org/thread/EOQ57IGVTS3WHWTRIZNFMQEUXKT2VE26/?sort=date
>
+1 from Gentoo
- Johannes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127823/#review95136
-----------------------------------------------------------
On Mai 3, 2016, 2:06 nachm., Antonio Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127823/
> -----------------------------------------------------------
>
> (Updated Mai 3, 2016, 2:06 nachm.)
>
>
> Review request for kdelibs.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Now that kde-workspace is obsolete and kdelibs is only used by some still unported \
> applications, it doesn't make sense to force using strigi anymore. This will allow \
> dropping this old unmaintained library from distributions.
>
> Diffs
> -----
>
> CMakeLists.txt e7b2bea
>
> Diff: https://git.reviewboard.kde.org/r/127823/diff/
>
>
> Testing
> -------
>
> Builds with and without strigi, everything seems to work
>
>
> Thanks,
>
> Antonio Rojas
>
>
--===============9164576113392932806==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127823/">https://git.reviewboard.kde.org/r/127823/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Mai 3rd, 2016, 2:58 nachm. CEST, <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Why touch the <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">if(WIN32)</code> though? If needed, just make it optional on all \
platforms.</p></pre> </blockquote>
<p>On Mai 3rd, 2016, 3:23 nachm. CEST, <b>Antonio Rojas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">That's what I'm doing... Currently it's only optional on WIN32, I'm \
changing it to be optional regardless of the platform</p></pre> </blockquote>
<p>On Mai 3rd, 2016, 6:01 nachm. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Eh... \
fair enough.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">+1</p></pre> </blockquote>
<p>On Mai 21st, 2016, 9:44 nachm. CEST, <b>Andreas Sturmlechner</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">works \
for me during the last days. but is there a list of depending packages other than the \
one from Fedora? https://lists.fedoraproject.org/archives/list/kde@lists.fedoraproject.org/thread/EOQ57IGVTS3WHWTRIZNFMQEUXKT2VE26/?sort=date</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 \
from Gentoo</p></pre> <br />
<p>- Johannes</p>
<br />
<p>On Mai 3rd, 2016, 2:06 nachm. CEST, Antonio Rojas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Antonio Rojas.</div>
<p style="color: grey;"><i>Updated Mai 3, 2016, 2:06 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Now that kde-workspace is obsolete and kdelibs is only \
used by some still unported applications, it doesn't make sense to force using strigi \
anymore. This will allow dropping this old unmaintained library from \
distributions.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds with and without strigi, everything seems to \
work</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e7b2bea)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127823/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============9164576113392932806==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic