[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 127264: Set CMP0064 to OLD to suppress CMake warnings
From: Rohan Garg <rohangarg () kubuntu ! org>
Date: 2016-03-08 14:36:22
Message-ID: 20160308143622.6298.58138 () mimi ! kde ! org
[Download RAW message or body]
--===============7127976081513245346==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 3, 2016, 10:24 p.m., Aleix Pol Gonzalez wrote:
> > cmake/modules/KDE4Macros.cmake, line 1003
> > <https://git.reviewboard.kde.org/r/127264/diff/1/?file=447921#file447921line1003>
> >
> > Without the conditionals, the code would work just as well.
>
> Rohan Garg wrote:
> Unless you have a CMake so old that said policy doesn't exist. For eg. on Debian \
> stable :)
> Luigi Toscano wrote:
> (which is still 3.0.2, so way more than the minimum required version for Frameworks \
> (2.8.12))
> Rohan Garg wrote:
> Except we're talking about kdelibs here, from the KDE 4 era.
>
> Luigi Toscano wrote:
> Even better (for your patch)! 2.8.9 is the current minimum, so not old at all for \
> kdelibs4.
> Rohan Garg wrote:
> Maybe I'm doing a terrible job of explaining it. The CMP0064 policy was introduced \
> in v3.4 , which is not available in Debian stable. Does that clear things up? Or am \
> I missing something?
> Luigi Toscano wrote:
> I'm supporting your patch. My comment is in fact to point out that version of cmake \
> is not so old.
Ahh ok :)
- Rohan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127264/#review93107
-----------------------------------------------------------
On March 3, 2016, 6:28 p.m., Rohan Garg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127264/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 6:28 p.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> This follows the same idea from 826a5ff3278f492a99ac6827614e1d0ca40a45e8
>
>
> Diffs
> -----
>
> cmake/modules/KDE4Macros.cmake 5bb2ffa
>
> Diff: https://git.reviewboard.kde.org/r/127264/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rohan Garg
>
>
--===============7127976081513245346==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127264/">https://git.reviewboard.kde.org/r/127264/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 3rd, 2016, 10:24 p.m. IST, <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127264/diff/1/?file=447921#file447921line1003" \
style="color: black; font-weight: bold; text-decoration: \
underline;">cmake/modules/KDE4Macros.cmake</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1003</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">if</span> <span class="p">(</span><span class="s">POLICY</span> <span \
class="s">CMP0064</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Without the conditionals, the code would work just as well.</p></pre> \
</blockquote>
<p>On March 8th, 2016, 7:37 p.m. IST, <b>Rohan Garg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Unless you have a CMake so old that said policy doesn't exist. For eg. on \
Debian stable :)</p></pre> </blockquote>
<p>On March 8th, 2016, 7:45 p.m. IST, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">(which is still 3.0.2, so way more than the minimum required version for \
Frameworks (2.8.12))</p></pre> </blockquote>
<p>On March 8th, 2016, 7:46 p.m. IST, <b>Rohan Garg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Except we're talking about kdelibs here, from the KDE 4 era.</p></pre> \
</blockquote>
<p>On March 8th, 2016, 7:50 p.m. IST, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Even \
better (for your patch)! 2.8.9 is the current minimum, so not old at all for \
kdelibs4.</p></pre> </blockquote>
<p>On March 8th, 2016, 7:51 p.m. IST, <b>Rohan Garg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe \
I'm doing a terrible job of explaining it. The CMP0064 policy was introduced in v3.4 \
, which is not available in Debian stable. Does that clear things up? Or am I missing \
something?</p></pre> </blockquote>
<p>On March 8th, 2016, 7:53 p.m. IST, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
supporting your patch. My comment is in fact to point out that version of cmake is \
not so old.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Ahh ok :)</p></pre> <br />
<p>- Rohan</p>
<br />
<p>On March 3rd, 2016, 6:28 p.m. IST, Rohan Garg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Rohan Garg.</div>
<p style="color: grey;"><i>Updated March 3, 2016, 6:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This follows the same idea from \
826a5ff3278f492a99ac6827614e1d0ca40a45e8</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/KDE4Macros.cmake <span style="color: grey">(5bb2ffa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127264/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7127976081513245346==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic