'Re: Review Request 126627: Replace screensaver inhibition by direct dbus calls'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 126627: Replace screensaver inhibition by direct dbus calls
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2016-01-04 20:18:20
Message-ID: 20160104201820.6499.24026 () mimi ! kde ! org
[Download RAW message or body]

--===============7864927981344574081==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126627/#review90590
-----------------------------------------------------------


Makes me sad :( +1 nonetheless


app/mainwindow.cpp (line 732)
<https://git.reviewboard.kde.org/r/126627/#comment61928>

    Full screen presentation going on / in progress? also perhaps add a hint to the \
translators



app/mainwindow.cpp (line 735)
<https://git.reviewboard.kde.org/r/126627/#comment61930>

    Is this check neccessary?



app/mainwindow.cpp (line 747)
<https://git.reviewboard.kde.org/r/126627/#comment61929>

    .value();



app/mainwindow.cpp (line 760)
<https://git.reviewboard.kde.org/r/126627/#comment61931>

    setArguments({mScreenSaverInhibitionCookie})


- Kai Uwe Broulik


On Jan. 4, 2016, 8:07 nachm., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126627/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 8:07 nachm.)
> 
> 
> Review request for Gwenview, KDE Base Apps and Kai Uwe Broulik.
> 
> 
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> This is a better approach to fix bug 334525 than
> https://git.reviewboard.kde.org/r/125910/ which forces
> a default reason (which is user visible).
> 
> With this new patch Gwenview will set a proper reason
> why is it inhibitting the screensaver ("Full Screen Presentation")
> and will use the DBus directly rather than the obsolete
> KNotificationRestrictions API.
> 
> 
> Diffs
> -----
> 
> app/mainwindow.cpp 7b30c4e 
> 
> Diff: https://git.reviewboard.kde.org/r/126627/diff/
> 
> 
> Testing
> -------
> 
> PowerDevil correctly shows that Gwenview is inhibitting
> the PM because "Full Screen Presentation".
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
> 


--===============7864927981344574081==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126627/">https://git.reviewboard.kde.org/r/126627/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Makes \
me sad :( +1 nonetheless</p></pre>  <br />







<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/126627/diff/1/?file=428424#file428424line735" \
style="color: black; font-weight: bold; text-decoration: \
underline;">app/mainwindow.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">struct \
MainWindow::Private</pre></td>

  </tr>
 </tbody>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">732</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="n">inhibitScreenSaver</span><span class="p">.</span><span \
class="n">setArguments</span><span class="p">(</span><span \
class="n">QList</span><span class="o">&lt;</span><span class="n">QVariant</span><span \
class="o">&gt;</span><span class="p">()</span> <span class="o">&lt;&lt;</span> <span \
class="n">QStringLiteral</span><span class="p">(</span><span \
class="s">&quot;Gwenview&quot;</span><span class="p">)</span> <span \
class="o">&lt;&lt;</span> <span class="n">i18n</span><span class="p">(</span><span \
class="s">&quot;Full Screen Presentation&quot;</span><span \
class="p">));</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Full \
screen presentation going on / in progress? also perhaps add a hint to the \
translators</p></pre>  </div>
</div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/126627/diff/1/?file=428424#file428424line738" \
style="color: black; font-weight: bold; text-decoration: \
underline;">app/mainwindow.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">struct \
MainWindow::Private</pre></td>

  </tr>
 </tbody>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">735</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">sessionBus</span><span class="p">.</span><span \
class="n">isConnected</span><span class="p">())</span> <span \
class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is \
this check neccessary?</p></pre>  </div>
</div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/126627/diff/1/?file=428424#file428424line750" \
style="color: black; font-weight: bold; text-decoration: \
underline;">app/mainwindow.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">struct \
MainWindow::Private</pre></td>

  </tr>
 </tbody>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">747</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
<span class="n">mScreenSaverInhibitionCookie</span> <span class="o">=</span> <span \
class="n">reply</span><span class="p">.</span><span class="n">argumentAt</span><span \
class="o">&lt;</span><span class="mi">0</span><span class="o">&gt;</span><span \
class="p">();</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">.value();</p></pre>  </div>
</div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/126627/diff/1/?file=428424#file428424line763" \
style="color: black; font-weight: bold; text-decoration: \
underline;">app/mainwindow.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">struct \
MainWindow::Private</pre></td>

  </tr>
 </tbody>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">760</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="n">uninhibitScreenSaver</span><span class="p">.</span><span \
class="n">setArguments</span><span class="p">(</span><span \
class="n">QList</span><span class="o">&lt;</span><span class="n">QVariant</span><span \
class="o">&gt;</span><span class="p">()</span> <span class="o">&lt;&lt;</span> <span \
class="n">mScreenSaverInhibitionCookie</span><span class="p">);</span></pre></td>  \
</tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">setArguments({mScreenSaverInhibitionCookie})</p></pre>  </div>
</div>
<br />



<p>- Kai Uwe Broulik</p>


<br />
<p>On Januar 4th, 2016, 8:07 nachm. UTC, Martin Klapetek wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Gwenview, KDE Base Apps and Kai Uwe Broulik.</div>
<div>By Martin Klapetek.</div>


<p style="color: grey;"><i>Updated Jan. 4, 2016, 8:07 nachm.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=334525">334525</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a better approach to fix bug 334525 than \
https://git.reviewboard.kde.org/r/125910/ which forces a default reason (which is \
user visible).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">With this new patch Gwenview will set a \
proper reason why is it inhibitting the screensaver ("Full Screen Presentation")
and will use the DBus directly rather than the obsolete
KNotificationRestrictions API.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">PowerDevil correctly shows that Gwenview is \
inhibitting the PM because "Full Screen Presentation".</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>app/mainwindow.cpp <span style="color: grey">(7b30c4e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126627/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============7864927981344574081==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic