[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full sc
From: "Luigi Toscano" <luigi.toscano () tiscali ! it>
Date: 2015-12-30 16:43:26
Message-ID: 20151230164326.30660.21168 () mimi ! kde ! org
[Download RAW message or body]
--===============7587717206397340979==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dic. 30, 2015, 3:48 p.m., Luigi Toscano wrote:
> > For the record: this was submitted to the knotifications frameworks, not to \
> > kdelibs.
>
> Martin Klapetek wrote:
> Yes, sorry, I wrote it as a message here but now I see that it didn't get through; \
> I still have "Publish" here :S
> There are no more kdelibs releases planned and the same bug happens in frameworks, \
> so I pushed it to frameworks.
> Luigi Toscano wrote:
> Afaik we are still publishing patch releases of kdelibs 4.14 branch, so I would add \
> the fix there too.
> Martin Klapetek wrote:
> Ah, do we have any records for that? Also when would the next release be?
With every stable release of KDE Applications (x.y, x.y.z, x.y.z+1, etc, so \
non-beta).
You can check the release tools, kdelibs is listed:
https://quickgit.kde.org/?p=sysadmin%2Frelease-tools.git&a=blob&h=ca78d7665498409a5d8b892b255cb6783cea078b&hb=dd91ca9e998550e10f17c850544753ac065ea9e9&f=modules.git
- Luigi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/#review90339
-----------------------------------------------------------
On Dic. 29, 2015, 9:54 p.m., Johannes Stefan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125910/
> -----------------------------------------------------------
>
> (Updated Dic. 29, 2015, 9:54 p.m.)
>
>
> Review request for kdelibs and Martin Klapetek.
>
>
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Setting default reason for going into fullscreen mode
>
>
> Diffs
> -----
>
> kdeui/notifications/knotificationrestrictions.cpp 818edea
>
> Diff: https://git.reviewboard.kde.org/r/125910/diff/
>
>
> Testing
> -------
>
> Compiled an tested - DBus Log as expected:
>
> ##### begin DBUS-log #####
> method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 \
> path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit string \
> "Gwenview" string "no_reason_specified"
> method call sender=:1.6 -> dest=:1.3 serial=588 path=/org/gnome/SessionManager; \
> interface=org.gnome.SessionManager; member=Inhibit string "Gwenview"
> uint32 0
> string "no_reason_specified"
> uint32 8
> signal sender=:1.3 -> dest=(null destination) serial=351 \
> path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; \
> member=PropertiesChanged string "org.gnome.SessionManager"
> array [
> dict entry(
> string "InhibitedActions"
> variant uint32 8
> )
> ]
> array [
> ]
> signal sender=:1.3 -> dest=(null destination) serial=352 \
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; \
> member=InhibitorAdded object path "/org/gnome/SessionManager/Inhibitor29"
> method return sender=:1.3 -> dest=:1.6 reply_serial=588
> uint32 1169992534
> method call sender=:1.4 -> dest=:1.21 serial=56 \
> path=/org/gnome/Mutter/IdleMonitor/Core; interface=org.gnome.Mutter.IdleMonitor; \
> member=RemoveWatch uint32 35
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 \
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch string \
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 \
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=GetNameOwner \
> string ":1.223" method return sender=:1.6 -> dest=:1.223 reply_serial=56
> uint32 1169992534
> method call sender=:1.6 -> dest=:1.21 serial=592 \
> path=/org/gnome/Mutter/DisplayConfig; interface=org.freedesktop.DBus.Properties; \
> member=Set string "org.gnome.Mutter.DisplayConfig"
> string "PowerSaveMode"
> variant int32 0
> method call sender=:1.21 -> dest=:1.3 serial=1073 path=/org/gnome/SessionManager; \
> interface=org.gnome.SessionManager; member=IsInhibited uint32 16
> method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 \
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch \
> string "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
> method return sender=:1.21 -> dest=:1.4 reply_serial=56
> method return sender=:1.3 -> dest=:1.21 reply_serial=1073
> boolean false
> ##### end of DBUS-log #####
>
>
> Thanks,
>
> Johannes Stefan
>
>
--===============7587717206397340979==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125910/">https://git.reviewboard.kde.org/r/125910/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On dicembre 30th, 2015, 3:48 p.m. CET, <b>Luigi \
Toscano</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">For the record: this was submitted to the \
knotifications frameworks, not to kdelibs.</p></pre> </blockquote>
<p>On dicembre 30th, 2015, 5:32 p.m. CET, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, \
sorry, I wrote it as a message here but now I see that it didn't get through; I still \
have "Publish" here :S</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">There are no more kdelibs releases \
planned and the same bug happens in frameworks, so I pushed it to \
frameworks.</p></pre> </blockquote>
<p>On dicembre 30th, 2015, 5:36 p.m. CET, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Afaik \
we are still publishing patch releases of kdelibs 4.14 branch, so I would add the fix \
there too.</p></pre> </blockquote>
<p>On dicembre 30th, 2015, 5:38 p.m. CET, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah, \
do we have any records for that? Also when would the next release be?</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With \
every stable release of KDE Applications (x.y, x.y.z, x.y.z+1, etc, so non-beta).</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">You can check the release tools, kdelibs is listed: \
https://quickgit.kde.org/?p=sysadmin%2Frelease-tools.git&a=blob&h=ca78d7665498 \
409a5d8b892b255cb6783cea078b&hb=dd91ca9e998550e10f17c850544753ac065ea9e9&f=modules.git</p></pre>
<br />
<p>- Luigi</p>
<br />
<p>On dicembre 29th, 2015, 9:54 p.m. CET, Johannes Stefan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs and Martin Klapetek.</div>
<div>By Johannes Stefan.</div>
<p style="color: grey;"><i>Updated Dic. 29, 2015, 9:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=334525">334525</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Setting default reason for going into fullscreen \
mode</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiled an tested - DBus Log as expected:</p> <h5 \
style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">begin DBUS-log</h5> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">method call \
sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 path=/ScreenSaver; \
interface=org.freedesktop.ScreenSaver; member=Inhibit string "Gwenview"
string "no_reason_specified"
method call sender=:1.6 -> dest=:1.3 serial=588 path=/org/gnome/SessionManager; \
interface=org.gnome.SessionManager; member=Inhibit string "Gwenview"
uint32 0
string "no_reason_specified"
uint32 8
signal sender=:1.3 -> dest=(null destination) serial=351 \
path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; \
member=PropertiesChanged string "org.gnome.SessionManager"
array [
dict entry(
string "InhibitedActions"
variant uint32 8
)
]
array [
]
signal sender=:1.3 -> dest=(null destination) serial=352 \
path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; \
member=InhibitorAdded object path "/org/gnome/SessionManager/Inhibitor29"
method return sender=:1.3 -> dest=:1.6 reply_serial=588
uint32 1169992534
method call sender=:1.4 -> dest=:1.21 serial=56 \
path=/org/gnome/Mutter/IdleMonitor/Core; interface=org.gnome.Mutter.IdleMonitor; \
member=RemoveWatch uint32 35
method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 \
path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch string \
"type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 \
path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=GetNameOwner \
string ":1.223" method return sender=:1.6 -> dest=:1.223 reply_serial=56
uint32 1169992534
method call sender=:1.6 -> dest=:1.21 serial=592 \
path=/org/gnome/Mutter/DisplayConfig; interface=org.freedesktop.DBus.Properties; \
member=Set string "org.gnome.Mutter.DisplayConfig"
string "PowerSaveMode"
variant int32 0
method call sender=:1.21 -> dest=:1.3 serial=1073 path=/org/gnome/SessionManager; \
interface=org.gnome.SessionManager; member=IsInhibited uint32 16
method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 \
path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch \
string "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
method return sender=:1.21 -> dest=:1.4 reply_serial=56
method return sender=:1.3 -> dest=:1.21 reply_serial=1073
boolean false</p>
<h5 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">end of DBUS-log</h5></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/notifications/knotificationrestrictions.cpp <span style="color: \
grey">(818edea)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125910/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7587717206397340979==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic