[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 126253: kxmlgui.xsd add Separator append attribute
From: "Allen Winter" <winter () kde ! org>
Date: 2015-12-06 16:07:08
Message-ID: 20151206160708.29696.911 () mimi ! kde ! org
[Download RAW message or body]
--===============8595552612911941161==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 6, 2015, 3:17 p.m., Martin Walch wrote:
> > Should the specification in kpartgui.dtd also be updated?
Krazy doesn't look at kpartgui.dtd . I don't know what kpartgui.dtd is used for.
I suppose adding the line "append CDATA #IMPLIED" into the Separator ATTLIST (line \
125) would work.
<!ELEMENT Separator EMPTY>
<!ATTLIST Separator
lineSeparator (true|false) "true"
weakSeparator (true|false) "true"
append CDATA #IMPLIED
group CDATA #IMPLIED
>
Any experts out there with an opinion?
- Allen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126253/#review89184
-----------------------------------------------------------
On Dec. 6, 2015, 2:34 p.m., Allen Winter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126253/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2015, 2:34 p.m.)
>
>
> Review request for kdelibs and Martin Walch.
>
>
> Bugs: 356134
> https://bugs.kde.org/show_bug.cgi?id=356134
>
>
> Repository: kxmlgui
>
>
> Description
> -------
>
> Add an append attribute to the Separator Element of the kxmlgui.xsd
>
>
> Diffs
> -----
>
> src/kxmlgui.xsd da1d155
>
> Diff: https://git.reviewboard.kde.org/r/126253/diff/
>
>
> Testing
> -------
>
> added to Krazy now. no longer see the xmllint warnings in kolf
>
>
> Thanks,
>
> Allen Winter
>
>
--===============8595552612911941161==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126253/">https://git.reviewboard.kde.org/r/126253/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 6th, 2015, 3:17 p.m. UTC, <b>Martin \
Walch</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Should the specification in kpartgui.dtd also be \
updated?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Krazy \
doesn't look at kpartgui.dtd . I don't know what kpartgui.dtd is used for.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I suppose adding the line "append CDATA #IMPLIED" into the Separator \
ATTLIST (line 125) would work.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;"><!ELEMENT Separator \
EMPTY> <!ATTLIST Separator
lineSeparator (true|false) "true"
weakSeparator (true|false) "true"
append CDATA #IMPLIED
group CDATA #IMPLIED</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"></blockquote> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Any experts out there with an opinion?</p></pre> <br />
<p>- Allen</p>
<br />
<p>On December 6th, 2015, 2:34 p.m. UTC, Allen Winter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs and Martin Walch.</div>
<div>By Allen Winter.</div>
<p style="color: grey;"><i>Updated Dec. 6, 2015, 2:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=356134">356134</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kxmlgui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add an append attribute to the Separator Element of \
the kxmlgui.xsd</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">added to Krazy now. no longer see the xmllint warnings \
in kolf</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kxmlgui.xsd <span style="color: grey">(da1d155)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126253/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8595552612911941161==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic