[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 126204: kdialog: Implement new password dialog
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-11-30 9:24:08
Message-ID: 20151130092408.29696.63721 () mimi ! kde ! org
[Download RAW message or body]
--===============1624609225043054678==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126204/#review88944
-----------------------------------------------------------
kdialog/kdialog.cpp (line 888)
<https://git.reviewboard.kde.org/r/126204/#comment60899>
Don't abbreviate those
- Kai Uwe Broulik
On Nov. 30, 2015, 8:51 vorm., Andrew Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126204/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 8:51 vorm.)
>
>
> Review request for KDE Base Apps.
>
>
> Bugs: 340397
> http://bugs.kde.org/show_bug.cgi?id=340397
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Using KNewPasswordDialog
>
> Usage: --newpassword <text> [min len] [max len] New Password dialog
>
>
> Diffs
> -----
>
> kdialog/kdialog.cpp 9afc53bccd1b313417e280952a208200cc444940
> kdialog/widgets.h 2afbed5af4917ee9c41fd9f82c257aebd9c11473
> kdialog/widgets.cpp c03cb5a179a054376881a4bdfcf474023ddf0209
>
> Diff: https://git.reviewboard.kde.org/r/126204/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Chen
>
>
--===============1624609225043054678==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126204/">https://git.reviewboard.kde.org/r/126204/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126204/diff/1/?file=420233#file420233line888" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdialog/kdialog.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
main(int argc, char *argv[])</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">888</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">options</span><span class="p">.</span><span class="n">add</span><span \
class="p">(</span><span class="s">"newpassword <text> [min len] [max \
len]"</span><span class="p">,</span> <span class="n">ki18n</span><span \
class="p">(</span><span class="s">"New Password dialog"</span><span \
class="p">));</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Don't \
abbreviate those</p></pre> </div>
</div>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On November 30th, 2015, 8:51 vorm. UTC, Andrew Chen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Andrew Chen.</div>
<p style="color: grey;"><i>Updated Nov. 30, 2015, 8:51 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=340397">340397</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Using KNewPasswordDialog</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Usage: --newpassword <text> [min len] [max len] New Password \
dialog</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdialog/kdialog.cpp <span style="color: \
grey">(9afc53bccd1b313417e280952a208200cc444940)</span></li>
<li>kdialog/widgets.h <span style="color: \
grey">(2afbed5af4917ee9c41fd9f82c257aebd9c11473)</span></li>
<li>kdialog/widgets.cpp <span style="color: \
grey">(c03cb5a179a054376881a4bdfcf474023ddf0209)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126204/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1624609225043054678==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic