[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 119663: libkscreensaver: blank mouse cursor in startup code
From: "Wolfgang Bauer" <wbauer () tmo ! at>
Date: 2015-09-30 14:02:15
Message-ID: 20150930140215.16344.94117 () mimi ! kde ! org
[Download RAW message or body]
--===============1632834819988845579==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119663/
-----------------------------------------------------------
(Updated Sept. 30, 2015, 4:02 nachm.)
Status
------
This change has been discarded.
Review request for kde-workspace.
Bugs: 334762
http://bugs.kde.org/show_bug.cgi?id=334762
Repository: kde-workspace
Description
-------
Qt's QGLWidget apparently explicitely sets a standard mouse pointer for the \
screensaver widget. This patch prevents the mouse cursor from being shown \
for KDE's OpenGL screensavers by setting a blank override cursor for the \
screensaver application when not run in demo mode.
Diffs
-----
kscreensaver/libkscreensaver/main.cpp 561205a
Diff: https://git.reviewboard.kde.org/r/119663/diff/
Testing
-------
Set one of KDE's OpenGL screensavers in systemsettings->Display and \
Monitor->Screen Locker, like Euphoria or Solarwinds. Wait for the \
screensaver to kick in. Notice that the mouse pointer is blanked now, \
whereas it was shown without this patch.
If a password is required, the mouse cursor does correctly re-appear for \
the greeter as it should if you move the mouse/press a key to get rid of \
the screensaver.
I'm using the patch on my systems for over two months now and haven't \
noticed any unexpected results.
Thanks,
Wolfgang Bauer
--===============1632834819988845579==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119663/">https://git.reviewboard.kde.org/r/119663/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px \
gray solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated Sept. 30, 2015, 4:02 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=334762">334762</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Qt's QGLWidget apparently \
explicitely sets a standard mouse pointer for the screensaver widget. This \
patch prevents the mouse cursor from being shown for KDE's OpenGL \
screensavers by setting a blank override cursor for the screensaver \
application when not run in demo mode.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Set one of KDE's OpenGL \
screensavers in systemsettings->Display and Monitor->Screen Locker, \
like Euphoria or Solarwinds. Wait for the screensaver to kick in.
Notice that the mouse pointer is blanked now, whereas it was shown without \
this patch.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">If a password is required, \
the mouse cursor does correctly re-appear for the greeter as it should if \
you move the mouse/press a key to get rid of the screensaver.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'm using the patch on my systems for over \
two months now and haven't noticed any unexpected results.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kscreensaver/libkscreensaver/main.cpp <span style="color: \
grey">(561205a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119663/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1632834819988845579==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic