[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it c
From:       "Jeremy Whiting" <jpwhiting () kde ! org>
Date:       2015-09-17 22:58:30
Message-ID: 20150917225830.2235.97533 () mimi ! kde ! org
[Download RAW message or body]

--===============3541585148358419694==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125297/
-----------------------------------------------------------

(Updated Sept. 17, 2015, 4:58 p.m.)


Status
------

This change has been discarded.


Review request for kdelibs and Albert Astals Cid.


Repository: okular


Description
-------

When running the mainshelltest the tests that fail report being unable to call \
openDocument because of it's QUrl parameter. With this it no longer complains about \
that (but the tests still fail).


Diffs
-----

  shell/okular_main.cpp 1c988d9 
  shell/shell.h c16a0b2 
  shell/shell.cpp d0204f9 

Diff: https://git.reviewboard.kde.org/r/125297/diff/


Testing
-------

Test no longer complains about being unable to call openDocument.


Thanks,

Jeremy Whiting


--===============3541585148358419694==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125297/">https://git.reviewboard.kde.org/r/125297/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kdelibs and Albert Astals Cid.</div>
<div>By Jeremy Whiting.</div>


<p style="color: grey;"><i>Updated Sept. 17, 2015, 4:58 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When running the mainshelltest the tests that fail \
report being unable to call openDocument because of it's QUrl parameter. With this it \
no longer complains about that (but the tests still fail).</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Test no longer complains about being unable to call \
openDocument.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shell/okular_main.cpp <span style="color: grey">(1c988d9)</span></li>

 <li>shell/shell.h <span style="color: grey">(c16a0b2)</span></li>

 <li>shell/shell.cpp <span style="color: grey">(d0204f9)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125297/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============3541585148358419694==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic