[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 125068: Make Format Painter work in KRichTextWidget
From: "Luigi Toscano" <luigi.toscano () tiscali ! it>
Date: 2015-09-07 20:22:13
Message-ID: 20150907202213.18618.30800 () mimi ! kde ! org
[Download RAW message or body]
--===============1138011078507909105==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Set. 7, 2015, 10:12 p.m., Albert Astals Cid wrote:
> > Ship It!
Is the fix relevant for to the ktextwidgets framework as well?
- Luigi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125068/#review84970
-----------------------------------------------------------
On Set. 6, 2015, 1:39 a.m., Allen Winter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125068/
> -----------------------------------------------------------
>
> (Updated Set. 6, 2015, 1:39 a.m.)
>
>
> Review request for kdelibs.
>
>
> Bugs: 221947
> http://bugs.kde.org/show_bug.cgi?id=221947
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> This patch, originally from Anders Lund back in 2010, fixes the problem with the \
> Format Painter changes not taking effect.
>
> Diffs
> -----
>
> kdeui/widgets/krichtextwidget.cpp 36ca232
>
> Diff: https://git.reviewboard.kde.org/r/125068/diff/
>
>
> Testing
> -------
>
> Tried it. Format Painter function in KJots works now, so fixes bug 221947
>
>
> Thanks,
>
> Allen Winter
>
>
--===============1138011078507909105==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125068/">https://git.reviewboard.kde.org/r/125068/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On settembre 7th, 2015, 10:12 p.m. CEST, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is the fix relevant for \
to the ktextwidgets framework as well?</pre> <br />
<p>- Luigi</p>
<br />
<p>On settembre 6th, 2015, 1:39 a.m. CEST, Allen Winter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Allen Winter.</div>
<p style="color: grey;"><i>Updated Set. 6, 2015, 1:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=221947">221947</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch, originally from Anders Lund back in 2010, \
fixes the problem with the Format Painter changes not taking effect.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tried it. Format Painter function in KJots works now, \
so fixes bug 221947</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/widgets/krichtextwidget.cpp <span style="color: \
grey">(36ca232)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125068/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1138011078507909105==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic