[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active
From: "Oswald Buddenhagen" <ossi () kde ! org>
Date: 2015-07-31 8:24:12
Message-ID: 20150731082412.31864.86514 () mimi ! kde ! org
[Download RAW message or body]
--===============2053751409628871916==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121755/#review83215
-----------------------------------------------------------
Ship it!
the description makes a good commit message, so please make sure you use that (apart \
from adding the BUG lines).
- Oswald Buddenhagen
On July 29, 2015, 9:39 a.m., Wolfgang Bauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121755/
> -----------------------------------------------------------
>
> (Updated July 29, 2015, 9:39 a.m.)
>
>
> Review request for kde-workspace, Thomas Lübking and Oswald Buddenhagen.
>
>
> Bugs: 268988 and 338018
> http://bugs.kde.org/show_bug.cgi?id=268988
> http://bugs.kde.org/show_bug.cgi?id=338018
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> [Commit d03df616](https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/d03df6169ecb291318e87099a346488c961fe1d6) \
> made input grabbing optional in KDM. But without it, input dialogs do not correctly \
> get focus and keyboard shortcuts don't work.
> KDM does call activateWindow() on opened dialogs, but this doesn't seem to have the \
> desired effect without a window manager running. And if you hover the mouse over a \
> widget, it visually looks like it has focus, but often it doesn't accept input \
> anyway.
> This patch sets the input focus via XSetInputFocus() instead, this also has the \
> positive side-effect that a widget retains the focus if you move the mouse away.
>
> Diffs
> -----
>
> kdm/kfrontend/kfdialog.cpp 3f6fa84
>
> Diff: https://git.reviewboard.kde.org/r/121755/diff/
>
>
> Testing
> -------
>
> Tried all things mentioned in the bug reports, keyboard input and shortcuts work \
> now in all cases.
> I also tested with onboard keyboards (xvkbd and kvkbd), both work fine. Before, \
> kvkbd didn't work at all (the text input widget lost focus as soon as you moved the \
> mouse to the OSK) and xvkbd only works if you forced the focus to the text input \
> widget via its "Focus" button (from which this patch was inspired actually ;-) ).
> Other openSUSE users have tested this as well, and the patch is even part of \
> openSUSE's official package since January. See also \
> https://bugzilla.opensuse.org/show_bug.cgi?id=772344
>
> Thanks,
>
> Wolfgang Bauer
>
>
--===============2053751409628871916==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121755/">https://git.reviewboard.kde.org/r/121755/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the \
description makes a good commit message, so please make sure you use that (apart from \
adding the BUG lines).</p></pre> <br />
<p>- Oswald Buddenhagen</p>
<br />
<p>On July 29th, 2015, 9:39 a.m. UTC, Wolfgang Bauer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kde-workspace, Thomas Lübking and Oswald Buddenhagen.</div>
<div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated July 29, 2015, 9:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=268988">268988</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=338018">338018</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><a \
href="https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/d03df6169ecb291318e87099a346488c961fe1d6" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Commit d03df616</a> made input grabbing optional in KDM. But without it, \
input dialogs do not correctly get focus and keyboard shortcuts don't work.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">KDM does call activateWindow() on opened dialogs, but this doesn't seem to \
have the desired effect without a window manager running. And if you hover the mouse \
over a widget, it visually looks like it has focus, but often it doesn't accept input \
anyway.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch sets the input focus via XSetInputFocus() \
instead, this also has the positive side-effect that a widget retains the focus if \
you move the mouse away.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tried all things mentioned in the bug reports, \
keyboard input and shortcuts work now in all cases.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
also tested with onboard keyboards (xvkbd and kvkbd), both work fine. Before, kvkbd \
didn't work at all (the text input widget lost focus as soon as you moved the mouse \
to the OSK) and xvkbd only works if you forced the focus to the text input widget via \
its "Focus" button (from which this patch was inspired actually ;-) ).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Other openSUSE users have tested this as well, and the patch is even part \
of openSUSE's official package since January. See also \
https://bugzilla.opensuse.org/show_bug.cgi?id=772344</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdm/kfrontend/kfdialog.cpp <span style="color: grey">(3f6fa84)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121755/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2053751409628871916==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic