[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 124163: Use KIO::Overwrite when saving a changed file otherwise it always fails.
From: "Kevin Kofler" <kevin.kofler () chello ! at>
Date: 2015-07-09 19:27:32
Message-ID: 20150709192732.16549.50839 () mimi ! kde ! org
[Download RAW message or body]
--===============8106169891301188167==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124163/#review82295
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Kofler
On Juni 24, 2015, 12:33 nachm., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124163/
> -----------------------------------------------------------
>
> (Updated Juni 24, 2015, 12:33 nachm.)
>
>
> Review request for kdelibs and Kevin Kofler.
>
>
> Bugs: 347760
> http://bugs.kde.org/show_bug.cgi?id=347760
>
>
> Repository: libkomparediff2
>
>
> Description
> -------
>
> As the summary says use KIO::Overwrite when saving files.
> BUG:347760
>
>
> Diffs
> -----
>
> komparemodellist.cpp 32242777411ddb8549154a6f2ef0fbc9fff7a239
>
> Diff: https://git.reviewboard.kde.org/r/124163/diff/
>
>
> Testing
> -------
>
> Kompare now correctly saves the destination file when comparing and making changes.
>
>
> Thanks,
>
> Jeremy Whiting
>
>
--===============8106169891301188167==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124163/">https://git.reviewboard.kde.org/r/124163/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Kevin Kofler</p>
<br />
<p>On Juni 24th, 2015, 12:33 nachm. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs and Kevin Kofler.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Juni 24, 2015, 12:33 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=347760">347760</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkomparediff2
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As the summary says use KIO::Overwrite when saving \
files. BUG:347760</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Kompare now correctly saves the destination file when \
comparing and making changes.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>komparemodellist.cpp <span style="color: \
grey">(32242777411ddb8549154a6f2ef0fbc9fff7a239)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124163/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8106169891301188167==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic