[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set
From: Stefan_Brüns <stefan.bruens () rwth-aachen ! de>
Date: 2015-03-19 2:20:02
Message-ID: 20150319022002.15053.74366 () mimi ! kde ! org
[Download RAW message or body]
--===============1810169920025729313==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122652/
-----------------------------------------------------------
(Updated March 19, 2015, 2:20 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, kdelibs and David Faure.
Changes
-------
Submitted with commit 6215e878706dc6e79d1b6ac5df33f5751d6c7ec0 by Stefan Brüns to \
branch master.
Bugs: 339193
http://bugs.kde.org/show_bug.cgi?id=339193
Repository: kdelibs
Description
-------
The default value for UDSEntry::numberValue(...) is 0, whereas KFileItem
uses the special value KFileItem::Unknown == (mode_t) -1.
CCBUG: 339193
Diffs
-----
kio/kio/kfileitem.cpp f431d3608cfe646fb882365921e694af8ff8838f
Diff: https://git.reviewboard.kde.org/r/122652/diff/
Testing
-------
dolphin remote:
-> no lock icon on smb:, mtp:, ... links
Thanks,
Stefan Brüns
--===============1810169920025729313==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122652/">https://git.reviewboard.kde.org/r/122652/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, kdelibs and David Faure.</div>
<div>By Stefan Brüns.</div>
<p style="color: grey;"><i>Updated March 19, 2015, 2:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 6215e878706dc6e79d1b6ac5df33f5751d6c7ec0 by Stefan \
Brüns to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=339193">339193</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The default value for UDSEntry::numberValue(...) is 0, whereas KFileItem \
uses the special value KFileItem::Unknown == (mode_t) -1.
CCBUG: 339193</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">dolphin remote:
-> no lock icon on smb:, mtp:, ... links</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/kfileitem.cpp <span style="color: \
grey">(f431d3608cfe646fb882365921e694af8ff8838f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122652/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1810169920025729313==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic