'Re: Review Request 122987: Allow user to specify path to myspell dictionary files'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 122987: Allow user to specify path to myspell dictionary files
From:       "Rolf Eike Beer" <kde () opensource ! sf-tec ! de>
Date:       2015-03-17 21:13:32
Message-ID: 20150317211332.15053.96384 () mimi ! kde ! org
[Download RAW message or body]

--===============7863428960940835438==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On März 17, 2015, 1:07 nachm., Laurent Montel wrote:
> > src/plugins/hunspell/hunspellclient.cpp, line 27
> > <https://git.reviewboard.kde.org/r/122987/diff/3/?file=355372#file355372line27>
> > 
> > #include "..."
> > we use local file.

No, the file is in an include path, not in the same directory as the source file (binary vs. source dir).

- Rolf Eike

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77630
-----------------------------------------------------------

On März 17, 2015, 1:09 nachm., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> -----------------------------------------------------------
> 
> (Updated März 17, 2015, 1:09 nachm.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> -------
> 
> Not on all systems myspell dictionaries are located in /usr/share/myspell/dicts/,  which is hardcoded \
> in the hunspell plugin sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user \
> define this path. 
> 
> Diffs
> -----
> 
> src/plugins/hunspell/CMakeLists.txt 098fb49 
> src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION 
> src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
> src/plugins/hunspell/hunspelldict.cpp 621113d 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> -------
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
> 

--===============7863428960940835438==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122987/">https://git.reviewboard.kde.org/r/122987/</a>
     </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On März 17th, 2015, 1:07 nachm. UTC, <b>Laurent Montel</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/122987/diff/3/?file=355372#file355372line27" style="color: black; \
font-weight: bold; text-decoration: underline;">src/plugins/hunspell/hunspellclient.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td>  <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">27</font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include \
&lt;config-hunspellplugin.h&gt;</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><h1 style="font-size: 100%;text-rendering: inherit;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">include "..."</h1> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">we use local \
file.</p></pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">No, the file is in an include path, not in the same \
directory as the source file (binary vs. source dir).</pre> <br />

<p>- Rolf Eike</p>

<br />
<p>On März 17th, 2015, 1:09 nachm. UTC, Eugene Shalygin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and kdelibs.</div>
<div>By Eugene Shalygin.</div>

<p style="color: grey;"><i>Updated März 17, 2015, 1:09 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
sonnet
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Not on all systems myspell dictionaries are \
located in /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin sources. For instance, \
on Gentoo it is /usr/share/myspell/. So let the user define this path.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">hunspell plugin began to work on \
Gentoo</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plugins/hunspell/CMakeLists.txt <span style="color: grey">(098fb49)</span></li>

 <li>src/plugins/hunspell/config-hunspellplugin.h.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/plugins/hunspell/hunspellclient.cpp <span style="color: grey">(9e3aa67)</span></li>

 <li>src/plugins/hunspell/hunspelldict.cpp <span style="color: grey">(621113d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122987/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7863428960940835438==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 