[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request 122471: Enable Compilation of about Protocol
From:       David_Narváez <david.narvaez () computer ! org>
Date:       2015-02-07 22:23:26
Message-ID: 20150207222326.13235.4488 () probe ! kde ! org
[Download RAW message or body]

--===============5393861031110413631==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122471/
-----------------------------------------------------------

Review request for kde-workspace and David Faure.


Repository: kio-extras


Description
-------

Basically porting away from QUrl and KDE_EXPORT


Diffs
-----

  CMakeLists.txt 3379ce7 
  about/kio_about.h 620d6aa 
  about/kio_about.cpp d7396d8 

Diff: https://git.reviewboard.kde.org/r/122471/diff/


Testing
-------

Tested compilation and installation:

$ find /home/david/kio-install/ -name "*about*"
/home/david/kio-install/lib64/plugins/kio_about.so                                    \
                
/home/david/kio-install/share/kservices5/about.protocol


Thanks,

David Narváez


--===============5393861031110413631==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122471/">https://git.reviewboard.kde.org/r/122471/</a>
  </td>
    </tr>
   </table>
   <br />





<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kde-workspace and David Faure.</div>
<div>By David Narváez.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Basically porting away from QUrl and \
KDE_EXPORT</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested compilation and installation:</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">$ find /home/david/kio-install/ -name "<em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
                normal;">about</em>"
/home/david/kio-install/lib64/plugins/kio_about.so                                    \
<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
                inherit;white-space: normal;" />
/home/david/kio-install/share/kservices5/about.protocol</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(3379ce7)</span></li>

 <li>about/kio_about.h <span style="color: grey">(620d6aa)</span></li>

 <li>about/kio_about.cpp <span style="color: grey">(d7396d8)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122471/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============5393861031110413631==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic