[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support
From: "David Faure" <faure () kde ! org>
Date: 2015-02-05 12:13:30
Message-ID: 20150205121330.19248.99606 () probe ! kde ! org
[Download RAW message or body]
--===============0758140089610203986==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122341/#review75469
-----------------------------------------------------------
thumbnail/thumbnail.cpp
<https://git.reviewboard.kde.org/r/122341/#comment52188>
there can be one issue here, if the destination already exists (but couldn't be \
loaded for some reason, e.g. corrupt file).
KDE::rename would overwrite an existing dest, while QFile::rename doesn't do \
that.
The proper way to implement "save to temp file and then move over existing \
destination" is to use QSaveFile. It's a corner case so I'm ok with it being fixed in \
a later commit. Maybe in this one a QFile::remove on the dest is enough, with a \
comment "// not atomic! should use QSaveFile"....
- David Faure
On Feb. 5, 2015, 8:59 a.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122341/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 8:59 a.m.)
>
>
> Review request for kde-workspace, Bhushan Shah and David Faure.
>
>
> Repository: kio-extras
>
>
> Description
> -------
>
> Only major difference would be the lack of fallback to KFMI. Maybe we could \
> implement thumbnail features in KFileMetadata?
>
> Diffs
> -----
>
> thumbnail/thumbnail.cpp 39e8de5
>
> Diff: https://git.reviewboard.kde.org/r/122341/diff/
>
>
> Testing
> -------
>
> Only tested compilation.
>
>
> Thanks,
>
> David Narváez
>
>
--===============0758140089610203986==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122341/">https://git.reviewboard.kde.org/r/122341/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122341/diff/3/?file=347082#file347082line773" \
style="color: black; font-weight: bold; text-decoration: \
underline;">thumbnail/thumbnail.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
ThumbnailProtocol::createSubThumbnail(QImage& thumbnail, const QString& \
filePath,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">754</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n"><span class="hl">KDE</span></span><span class="o">::</span><span \
class="n">rename</span><span class="p">(</span><span \
class="n">tempFileName</span><span class="p">,</span> <span \
class="n">thumbPath</span><span class="hl"> </span><span class="o"><span \
class="hl">+</span></span><span class="hl"> </span><span \
class="n">thumbName</span><span class="p">);</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">732</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n"><span class="hl">QFile</span></span><span class="o">::</span><span \
class="n">rename</span><span class="p">(</span><span \
class="n">tempFileName</span><span class="p">,</span> <span \
class="n">thumbPath</span><span class="p"><span class="hl">.</span></span><span \
class="n"><span class="hl">absoluteFilePath</span></span><span class="p"><span \
class="hl">(</span></span><span class="n">thumbName</span><span class="p">)<span \
class="hl">)</span>;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">there \
can be one issue here, if the destination already exists (but couldn't be loaded for \
some reason, e.g. corrupt file).</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">KDE::rename would \
overwrite an existing dest, while QFile::rename doesn't do that.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The proper way to implement "save to temp file and then move over existing \
destination" is to use QSaveFile. It's a corner case so I'm ok with it being fixed in \
a later commit. Maybe in this one a QFile::remove on the dest is enough, with a \
comment "// not atomic! should use QSaveFile"....</p></pre> </div>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On February 5th, 2015, 8:59 a.m. UTC, David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kde-workspace, Bhushan Shah and David Faure.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2015, 8:59 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Only major difference would be the lack of fallback to \
KFMI. Maybe we could implement thumbnail features in KFileMetadata?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Only tested compilation.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>thumbnail/thumbnail.cpp <span style="color: grey">(39e8de5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122341/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0758140089610203986==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic