From kde-core-devel Mon Feb 02 22:17:31 2015 From: "Jeremy Whiting" Date: Mon, 02 Feb 2015 22:17:31 +0000 To: kde-core-devel Subject: Re: Review Request 122394: Fix OSX library names in kdeinit5.app Message-Id: <20150202221731.19248.57726 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=142291548524878 --===============5776367749764810150== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On Feb. 2, 2015, 2:56 p.m., René J.V. Bertin wrote: > > src/kdeinit/kinit.cpp, lines 90-92 > > > > > > These are true shared libraries that are also used for "-l" style linking with ld? I'm not sure I understand the question, is there some other type of library on OSX besides "true shared libraries that are also used for -l style linking with ld"? file says they are Mach-O 64-bit dynamically linked shared library x86_64 if that helps answer your question. - Jeremy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122394/#review75242 ----------------------------------------------------------- On Feb. 2, 2015, 1:51 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122394/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2015, 1:51 p.m.) > > > Review request for KDE Software on Mac OS X, kdelibs, David Faure, and Ian Wadham. > > > Bugs: 343707 > https://bugs.kde.org/show_bug.cgi?id=343707 > > > Repository: kinit > > > Description > ------- > > OSX Doesn't have .so libraries, so use OSX names in kdeinit5.app to load the correct libraries needed. > > > Diffs > ----- > > src/kdeinit/kinit.cpp 3c3c913 > > Diff: https://git.reviewboard.kde.org/r/122394/diff/ > > > Testing > ------- > > kdeinit5.app no longer complains about the missing .so libraries. > > > Thanks, > > Jeremy Whiting > > --===============5776367749764810150== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122394/

On February 2nd, 2015, 2:56 p.m. MST, René J.V. Bertin wrote:

src/kdeinit/kinit.cpp (Diff revision 1) 

    90
    
    "libKF5KIOCore.5.dylib",

  


  

    
    

    91
    
    "libKF5Parts.5.dylib",

  


  

    
    

    92
    
    "libKF5Plasma.5.dylib"

  


 




  
These are true shared libraries that are also used for "-l" style linking with ld?

 









I'm not sure I understand the question, is there some other type of library on OSX besides "true shared libraries that are also used for -l style linking with ld"? file says they are Mach-O 64-bit dynamically linked shared library x86_64 if that helps answer your question.








- Jeremy






On February 2nd, 2015, 1:51 p.m. MST, Jeremy Whiting wrote:












 

  


Review request for KDE Software on Mac OS X, kdelibs, David Faure, and Ian Wadham.


By Jeremy Whiting.




Updated Feb. 2, 2015, 1:51 p.m.










 Bugs: 


 343707









 Repository: 
kinit





Description 

 

 

  
   
OSX Doesn't have .so libraries, so use OSX names in kdeinit5.app to load the correct libraries needed.

  		
 






Testing 



 

  
   
kdeinit5.app no longer complains about the missing .so libraries.

  		
 






Diffs 


    

 
  • src/kdeinit/kinit.cpp (3c3c913)
    • 





View Diff







  		
 











  

 



--===============5776367749764810150==--