[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 122330: Associate *.qmltypes and *.qmlproject files with the text/x-qml mime type
From: "Milian Wolff" <mail () milianw ! de>
Date: 2015-02-02 11:55:44
Message-ID: 20150202115544.19249.99673 () probe ! kde ! org
[Download RAW message or body]
--===============9208769772199060983==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Feb. 1, 2015, 8:32 p.m., David Faure wrote:
> > -1 for not submitting this upstream for shared-mime-info.
> >
> > I took care of it, it's committed, will be in s-m-i 1.4.
Could we add a comment to this file then, telling people to work on upstream smi \
instead then?
- Milian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122330/#review75179
-----------------------------------------------------------
On Feb. 1, 2015, 7:28 p.m., Denis Steckelmacher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122330/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2015, 7:28 p.m.)
>
>
> Review request for KDE Frameworks, kdelibs and KDevelop.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> The KDevelop QML/JS plugin sometimes needs to parse .qmltypes files (in order to \
> list the content of installed QML modules, for instance), but KDevelop requires \
> that files parsed using the QML/JS plugin have the text/x-qml mime type.
> Because .qmltypes and .qmlproject files are valid QML files (they follow the \
> standard QML syntax), this patch proposes to add these extensions to the ones \
> associated with the text/x-qml mime type.
>
> Diffs
> -----
>
> src/mimetypes/kde5.xml cc9f71e
>
> Diff: https://git.reviewboard.kde.org/r/122330/diff/
>
>
> Testing
> -------
>
> Installing kcoreaddons and updating the system MIME database allows KDevelop to \
> detect that files with the .qmltypes and .qmlproject extensions have to be parsed \
> using the QML/JS language support plugin. This allows QML files to use QML modules \
> installed system-wide (and fixes the unit tests of kdev-qmljs).
>
> Thanks,
>
> Denis Steckelmacher
>
>
--===============9208769772199060983==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122330/">https://git.reviewboard.kde.org/r/122330/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 1st, 2015, 8:32 p.m. UTC, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">-1 for not submitting this upstream for \
shared-mime-info.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I took care of it, it's committed, will \
be in s-m-i 1.4.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Could \
we add a comment to this file then, telling people to work on upstream smi instead \
then?</p></pre> <br />
<p>- Milian</p>
<br />
<p>On February 1st, 2015, 7:28 p.m. UTC, Denis Steckelmacher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, kdelibs and KDevelop.</div>
<div>By Denis Steckelmacher.</div>
<p style="color: grey;"><i>Updated Feb. 1, 2015, 7:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The KDevelop QML/JS plugin sometimes needs to parse \
.qmltypes files (in order to list the content of installed QML modules, for \
instance), but KDevelop requires that files parsed using the QML/JS plugin have the \
text/x-qml mime type.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Because .qmltypes and .qmlproject files \
are valid QML files (they follow the standard QML syntax), this patch proposes to add \
these extensions to the ones associated with the text/x-qml mime type.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Installing kcoreaddons and updating the system MIME \
database allows KDevelop to detect that files with the .qmltypes and .qmlproject \
extensions have to be parsed using the QML/JS language support plugin. This allows \
QML files to use QML modules installed system-wide (and fixes the unit tests of \
kdev-qmljs).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/mimetypes/kde5.xml <span style="color: grey">(cc9f71e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122330/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============9208769772199060983==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic