[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 122270: port kcminit away from kdelibs4support
From: "Nick Shaforostoff" <shafff () ukr ! net>
Date: 2015-01-29 19:53:42
Message-ID: 20150129195342.13679.33588 () probe ! kde ! org
[Download RAW message or body]
--===============7390039426014490040==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Січ. 29, 2015, 2:36 після полудня, Martin Gräßlin wrote:
> > I'm surprised that you pushed the change although the review was not finished and you hadn't a shipit \
> > on any of the versions.
>
> Thomas Lübking wrote:
> Nick, though it does not seem as if you had introduced it, the "QGuiApplication::screens().count() > 1" \
> check is, as has been pointed out in this review several times, still wrong for sure. Do you intend to \
> keep working on this code? (to get rid of QGuiApplication and perhaps the ini read)
> Nick Shaforostoff wrote:
> sorry, should i revert the commit?
>
> yes, i intend to create a new review request with 'QGuiApplication::screens().count() > 1' replacement \
> using xcb routines.
i had a look at kcminit from KDE4 branch and indeed it used ScreenCount(QX11Info::display()), which can \
be substituted simply via xcb according to http://xcb.freedesktop.org/xlibtoxcbtranslationguide/
- Nick
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122270/#review74982
-----------------------------------------------------------
On Січ. 29, 2015, 11:58 до полудня, Nick Shaforostoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122270/
> -----------------------------------------------------------
>
> (Updated Січ. 29, 2015, 11:58 до полудня)
>
>
> Review request for kde-workspace, Aleix Pol Gonzalez, Martin Gräßlin, and Lukáš Tinkl.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Now kcminit is linked with less libraries -> startup time improved
>
> I also suggest always setting KDE_MULTIHEAD=true to eliminate ini file access during startup and to be \
> able to stop linking against QtGui
>
> Diffs
> -----
>
> startkde/kcminit/CMakeLists.txt ffae38c
> startkde/kcminit/main.h 1140b77
> startkde/kcminit/main.cpp 4724323
>
> Diff: https://git.reviewboard.kde.org/r/122270/diff/
>
>
> Testing
> -------
>
> compiled, ran 'kcminit --list' and kcminit AAA
>
>
> Thanks,
>
> Nick Shaforostoff
>
>
--===============7390039426014490040==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122270/">https://git.reviewboard.kde.org/r/122270/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Січень 29th, 2015, 2:36 після полудня UTC, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm surprised that you pushed the change \
although the review was not finished and you hadn't a shipit on any of the versions.</p></pre> \
</blockquote>
<p>On Січень 29th, 2015, 3:08 після полудня UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Nick, though it does not seem as if you had introduced it, the \
"QGuiApplication::screens().count() > 1" check is, as has been pointed out in this review several \
times, still wrong for sure. Do you intend to keep working on this code? (to get rid of QGuiApplication \
and perhaps the ini read)</p></pre> </blockquote>
<p>On Січень 29th, 2015, 7:44 після полудня UTC, <b>Nick Shaforostoff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">sorry, should i revert the commit?</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yes, i intend to create a \
new review request with 'QGuiApplication::screens().count() > 1' replacement using xcb \
routines.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">i had a look at kcminit from KDE4 branch and indeed it used \
ScreenCount(QX11Info::display()), which can be substituted simply via xcb according to \
http://xcb.freedesktop.org/xlibtoxcbtranslationguide/</p></pre> <br />
<p>- Nick</p>
<br />
<p>On Січень 29th, 2015, 11:58 до полудня UTC, Nick Shaforostoff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kde-workspace, Aleix Pol Gonzalez, Martin Gräßlin, and Lukáš Tinkl.</div>
<div>By Nick Shaforostoff.</div>
<p style="color: grey;"><i>Updated Січ. 29, 2015, 11:58 до полудня</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Now kcminit is linked with less libraries \
-> startup time improved</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I also suggest always setting KDE_MULTIHEAD=true to eliminate ini file \
access during startup and to be able to stop linking against QtGui</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">compiled, ran 'kcminit --list' and kcminit \
AAA</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>startkde/kcminit/CMakeLists.txt <span style="color: grey">(ffae38c)</span></li>
<li>startkde/kcminit/main.h <span style="color: grey">(1140b77)</span></li>
<li>startkde/kcminit/main.cpp <span style="color: grey">(4724323)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122270/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7390039426014490040==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic