[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 121831: libksysguard: process.h: encapsulate private fields
From: "Gregor Mi" <codestruct () posteo ! org>
Date: 2015-01-25 22:27:14
Message-ID: 20150125222714.30682.1454 () probe ! kde ! org
[Download RAW message or body]
--===============3700689598483086401==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121831/
-----------------------------------------------------------
(Updated Jan. 25, 2015, 10:27 p.m.)
Review request for KDE Base Apps, Dominik Haumann, Eike Hein, and John Tapsell.
Changes
-------
more consistent order of methods
Repository: libksysguard
Description
-------
In process.h there are several public fields. This RR introduces a d-ptr.
(In a separate commit I would add the .reviewboardrc file)
What is the current policy on using small C++ macros as done in this RR? Use it (code \
is more compact and readable) or don't use it (better for debugging)?
Diffs (updated)
-----
processui/scripting.h 2445c0ab0d81af3283c0f6e9c5f349a3d70b0de9
processui/scripting.cpp 76291b0ae0a26e486aa81a4ca3976ff4a47cb3c0
processcore/processes_solaris_p.cpp f054df4b1e762e9cbec1ff8dea78f467b878bee0
processui/ProcessFilter.cpp ec520593fb67c777d56817f2493d40dc5ade0347
processui/ProcessModel.cpp 53bc041110c9cdb686fef783895104969b661889
processui/ksysguardprocesslist.cpp 4dc142e864d8353ceafc3a6735ffa81e48291420
processcore/processes.cpp 580df8db152040f1ad075430fdce08fe7ad4ae2d
processcore/processes_atop_p.cpp 24c76e3e35f62bd8e9e705ad32cc11cbd3662601
processcore/processes_base_p.h 71b8a9cc6ee14bf7934a0a9d3199b257b5ce1be7
processcore/processes_linux_p.cpp 898d4fa491873fe95a8b32a5c1b85642b2e46ad5
processcore/processes.h d09c3265333fe7e2702deaa910c5fbe4bc3ac9e6
tests/processtest.cpp f9b36e9a3a3c2048b51f1d935f8c40de2ad8a9b8
.reviewboardrc PRE-CREATION
CMakeLists.txt cefc86f12be684e195bd148641483e9e1734e636
processcore/process.h b6695c0ed301dc5f0fad8ba847da811f19ebfd9a
processcore/process.cpp a38b8be71da1a51cb87f636664ebac817b1d20ab
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
-------
Compiles and runs. Data is still shown; no visible error. Unit tests succeed.
Thanks,
Gregor Mi
--===============3700689598483086401==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121831/">https://git.reviewboard.kde.org/r/121831/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Base Apps, Dominik Haumann, Eike Hein, and John \
Tapsell.</div> <div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated Jan. 25, 2015, 10:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">more consistent order of methods</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libksysguard
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In process.h there are several public fields. This RR \
introduces a d-ptr.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">(In a separate commit I would add the \
.reviewboardrc file)</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">What is the current policy on using \
small C++ macros as done in this RR? Use it (code is more compact and readable) or \
don't use it (better for debugging)?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles and runs. Data is still shown; no visible \
error. Unit tests succeed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>processui/scripting.h <span style="color: \
grey">(2445c0ab0d81af3283c0f6e9c5f349a3d70b0de9)</span></li>
<li>processui/scripting.cpp <span style="color: \
grey">(76291b0ae0a26e486aa81a4ca3976ff4a47cb3c0)</span></li>
<li>processcore/processes_solaris_p.cpp <span style="color: \
grey">(f054df4b1e762e9cbec1ff8dea78f467b878bee0)</span></li>
<li>processui/ProcessFilter.cpp <span style="color: \
grey">(ec520593fb67c777d56817f2493d40dc5ade0347)</span></li>
<li>processui/ProcessModel.cpp <span style="color: \
grey">(53bc041110c9cdb686fef783895104969b661889)</span></li>
<li>processui/ksysguardprocesslist.cpp <span style="color: \
grey">(4dc142e864d8353ceafc3a6735ffa81e48291420)</span></li>
<li>processcore/processes.cpp <span style="color: \
grey">(580df8db152040f1ad075430fdce08fe7ad4ae2d)</span></li>
<li>processcore/processes_atop_p.cpp <span style="color: \
grey">(24c76e3e35f62bd8e9e705ad32cc11cbd3662601)</span></li>
<li>processcore/processes_base_p.h <span style="color: \
grey">(71b8a9cc6ee14bf7934a0a9d3199b257b5ce1be7)</span></li>
<li>processcore/processes_linux_p.cpp <span style="color: \
grey">(898d4fa491873fe95a8b32a5c1b85642b2e46ad5)</span></li>
<li>processcore/processes.h <span style="color: \
grey">(d09c3265333fe7e2702deaa910c5fbe4bc3ac9e6)</span></li>
<li>tests/processtest.cpp <span style="color: \
grey">(f9b36e9a3a3c2048b51f1d935f8c40de2ad8a9b8)</span></li>
<li>.reviewboardrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: \
grey">(cefc86f12be684e195bd148641483e9e1734e636)</span></li>
<li>processcore/process.h <span style="color: \
grey">(b6695c0ed301dc5f0fad8ba847da811f19ebfd9a)</span></li>
<li>processcore/process.cpp <span style="color: \
grey">(a38b8be71da1a51cb87f636664ebac817b1d20ab)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121831/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3700689598483086401==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic