--===============0883835067691689687== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121511/#review72011 ----------------------------------------------------------- Ship it! If it compiles, shit it :D You could most probably skip the d assignments since as i understand in that #if branches the d is just an empty class but never hurts to do properly - Albert Astals Cid On des. 14, 2014, 10:03 p.m., Paul Manners wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121511/ > ----------------------------------------------------------- > > (Updated des. 14, 2014, 10:03 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > ------- > > kfilemetainfo.cpp is breaking the build > > > Diffs > ----- > > kio/kio/kfilemetainfo.cpp 84fb329 > > Diff: https://git.reviewboard.kde.org/r/121511/diff/ > > > Testing > ------- > > This was causing problems when doing a build under Windows (with emerge kdelibs under mingw4). Checking the source code of the kdelibs package in Ubuntu (13.10), it appears to also suffer from the same error so this may be a bigger issue than just on this branch. > > This fixes the build but I don't know how to check if it impacts any of the other applications. > > > Thanks, > > Paul Manners > > --===============0883835067691689687== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121511/

Ship it!

If it compiles, shit it :D
You could most probably skip the d assignments since as i understand in that #if branches the d is just an empty class but never hurts to do properly

- Albert Astals Cid

On desembre 14th, 2014, 10:03 p.m. UTC, Paul Manners wrote:

Review request for kdelibs.

By Paul Manners.

Updated des. 14, 2014, 10:03 p.m.

Repository: kdelibs

Description

kfilemetainfo.cpp is breaking the build

Testing

This was causing problems when doing a build under Windows (with emerge kdelibs under mingw4).  Checking the source code of the kdelibs package in Ubuntu (13.10), it appears to also suffer from the same error so this may be a bigger issue than just on this branch. 
This fixes the build but I don't know how to check if it impacts any of the other applications.

Diffs

kio/kio/kfilemetainfo.cpp (84fb329)

--===============0883835067691689687==--