From kde-core-devel  Sun Dec 14 17:02:27 2014
From: "Albert Astals Cid" <aacid () kde ! org>
Date: Sun, 14 Dec 2014 17:02:27 +0000
To: kde-core-devel
Subject: Re: Review Request 120761: Added support for NFSv3, major refactoring, fixed bugs
Message-Id: <20141214170227.31947.20459 () probe ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=141857659305242

--===============8252925971753813203==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit



> On nov. 16, 2014, 2:24 p.m., Christoph Feck wrote:
> > Albert, this is a backport of https://git.reviewboard.kde.org/r/120343/
> > 
> > David Faure already approved a backport to KDE 4 there, but was not sure if release team is okey with the backport.
> 
> Albert Astals Cid wrote:
>     I've the feeling i've already weighted in my opinion on this, but i'll give it again :)
>     kde-runtime 4.14 is not having more releases so imho doesn't make sense in commiting there. kde-runtime Applications/14.12 is in beta stage and master is open for new features, i'll leave to someone else to decide if this is a bugfix or a feature.

Mathias can you please commit this to kde-runtime master branch?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120761/#review70438
-----------------------------------------------------------


On nov. 16, 2014, 2:23 p.m., Mathias Tillman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120761/
> -----------------------------------------------------------
> 
> (Updated nov. 16, 2014, 2:23 p.m.)
> 
> 
> Review request for KDE Runtime and Albert Astals Cid.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> This patch adds proper support for NFSv3 in the kio module, it still supports NFSv2 servers of course. I implemented it in such a way that it loops through the versions trying to find a compatible one.
> I also found when working with it that the code was far from optimal, so I have done some major refactoring and optimisation work which also fixes a couple of bugs. That's why the patch is so big.
> 
> This is a backport of https://git.reviewboard.kde.org/r/120343/.
> 
> 
> Diffs
> -----
> 
>   kioslave/nfs/rpc_mnt2_xdr.c PRE-CREATION 
>   kioslave/nfs/rpc_mnt3.h PRE-CREATION 
>   kioslave/nfs/rpc_mnt3_xdr.c PRE-CREATION 
>   kioslave/nfs/rpc_nfs2_prot.h PRE-CREATION 
>   kioslave/nfs/rpc_nfs2_prot_xdr.c PRE-CREATION 
>   kioslave/nfs/rpc_nfs3_prot.h PRE-CREATION 
>   kioslave/nfs/rpc_nfs3_prot.x PRE-CREATION 
>   kioslave/nfs/rpc_nfs3_prot_xdr.c PRE-CREATION 
>   kioslave/nfs/nfsv2.h PRE-CREATION 
>   kioslave/nfs/nfsv2.cpp PRE-CREATION 
>   kioslave/nfs/nfsv3.h PRE-CREATION 
>   kioslave/nfs/nfsv3.cpp PRE-CREATION 
>   kioslave/nfs/nfs_prot.h 5ed218f20d2fda219adda6899a1321fc3d384d1e 
>   kioslave/nfs/nfs_prot.x  
>   kioslave/nfs/nfs_prot_xdr.c cd1354668d40616a0a0864bc6b3d68ccc5ef3e4f 
>   kioslave/nfs/mount_xdr.c 433a8596884bdb4fe05795c74de21767ed88d6eb 
>   kioslave/nfs/nfs.protocol 4781b3ca1424473c913e7ee265ee6fffa50cce39 
>   kioslave/nfs/mount.h c3b8c217f3574c8afd2410ad2b50ec98828e31bb 
>   kioslave/nfs/mount.x  
>   kioslave/nfs/kio_nfs.h ec52564f5fa2c5ce38f354bbe94b86a75fb7f6b0 
>   kioslave/nfs/kio_nfs.cpp 3f94b9129bf9f126aef1e4356dc533420151ae2a 
>   kioslave/nfs/CMakeLists.txt b973a736393388af5d66b8b7d6b055f497f3bdf8 
>   kioslave/nfs/README 9d92d73104ede629e617aeb8e117802ebf4190c2 
>   kioslave/nfs/TODO 6e5525127454c936f829028c521999ba4f046c08 
> 
> Diff: https://git.reviewboard.kde.org/r/120761/diff/
> 
> 
> Testing
> -------
> 
> I've tried browsing NFS servers that are compatible with both version 2 and 3, as well as one server that was only compatible with version 3 (see bug #309113).
> In addition to that I've tried most things I can think of like copying, changing permissions, creating files and directories etc.
> 
> Due to its size it will most likely require more testing, but my tests have so far been successful.
> 
> 
> Thanks,
> 
> Mathias Tillman
> 
>


--===============8252925971753813203==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120761/">https://git.reviewboard.kde.org/r/120761/</a>
     </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On novembre 16th, 2014, 2:24 p.m. UTC, <b>Christoph Feck</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Albert, this is a backport of https://git.reviewboard.kde.org/r/120343/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">David Faure already approved a backport to KDE 4 there, but was not sure if release team is okey with the backport.</p></pre>
 </blockquote>




 <p>On novembre 16th, 2014, 4:45 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've the feeling i've already weighted in my opinion on this, but i'll give it again :)
kde-runtime 4.14 is not having more releases so imho doesn't make sense in commiting there. kde-runtime Applications/14.12 is in beta stage and master is open for new features, i'll leave to someone else to decide if this is a bugfix or a feature.</p></pre>
 </blockquote>








</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Mathias can you please commit this to kde-runtime master branch?</p></pre>
<br />










<p>- Albert</p>


<br />
<p>On novembre 16th, 2014, 2:23 p.m. UTC, Mathias Tillman wrote:</p>









<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for KDE Runtime and Albert Astals Cid.</div>
<div>By Mathias Tillman.</div>


<p style="color: grey;"><i>Updated nov. 16, 2014, 2:23 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds proper support for NFSv3 in the kio module, it still supports NFSv2 servers of course. I implemented it in such a way that it loops through the versions trying to find a compatible one.
I also found when working with it that the code was far from optimal, so I have done some major refactoring and optimisation work which also fixes a couple of bugs. That's why the patch is so big.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a backport of https://git.reviewboard.kde.org/r/120343/.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've tried browsing NFS servers that are compatible with both version 2 and 3, as well as one server that was only compatible with version 3 (see bug #309113).
In addition to that I've tried most things I can think of like copying, changing permissions, creating files and directories etc.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Due to its size it will most likely require more testing, but my tests have so far been successful.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kioslave/nfs/rpc_mnt2_xdr.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kioslave/nfs/rpc_mnt3.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kioslave/nfs/rpc_mnt3_xdr.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kioslave/nfs/rpc_nfs2_prot.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kioslave/nfs/rpc_nfs2_prot_xdr.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kioslave/nfs/rpc_nfs3_prot.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kioslave/nfs/rpc_nfs3_prot.x <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kioslave/nfs/rpc_nfs3_prot_xdr.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kioslave/nfs/nfsv2.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kioslave/nfs/nfsv2.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kioslave/nfs/nfsv3.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kioslave/nfs/nfsv3.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kioslave/nfs/nfs_prot.h <span style="color: grey">(5ed218f20d2fda219adda6899a1321fc3d384d1e)</span></li>

 <li>kioslave/nfs/nfs_prot.x <span style="color: grey">()</span></li>

 <li>kioslave/nfs/nfs_prot_xdr.c <span style="color: grey">(cd1354668d40616a0a0864bc6b3d68ccc5ef3e4f)</span></li>

 <li>kioslave/nfs/mount_xdr.c <span style="color: grey">(433a8596884bdb4fe05795c74de21767ed88d6eb)</span></li>

 <li>kioslave/nfs/nfs.protocol <span style="color: grey">(4781b3ca1424473c913e7ee265ee6fffa50cce39)</span></li>

 <li>kioslave/nfs/mount.h <span style="color: grey">(c3b8c217f3574c8afd2410ad2b50ec98828e31bb)</span></li>

 <li>kioslave/nfs/mount.x <span style="color: grey">()</span></li>

 <li>kioslave/nfs/kio_nfs.h <span style="color: grey">(ec52564f5fa2c5ce38f354bbe94b86a75fb7f6b0)</span></li>

 <li>kioslave/nfs/kio_nfs.cpp <span style="color: grey">(3f94b9129bf9f126aef1e4356dc533420151ae2a)</span></li>

 <li>kioslave/nfs/CMakeLists.txt <span style="color: grey">(b973a736393388af5d66b8b7d6b055f497f3bdf8)</span></li>

 <li>kioslave/nfs/README <span style="color: grey">(9d92d73104ede629e617aeb8e117802ebf4190c2)</span></li>

 <li>kioslave/nfs/TODO <span style="color: grey">(6e5525127454c936f829028c521999ba4f046c08)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120761/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============8252925971753813203==--