[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 121511: Fix to allow kfilemetainfo.h and kfilemetainfo.cpp to build
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2014-12-14 16:07:09
Message-ID: 20141214160709.31947.85002 () probe ! kde ! org
[Download RAW message or body]
--===============4701372521167874034==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121511/#review71986
-----------------------------------------------------------
Don't change public headers.
It's just that the no_strigi part of the .cpp code is broken, fix that part.
- Albert Astals Cid
On des. 14, 2014, 3:38 p.m., Paul Manners wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121511/
> -----------------------------------------------------------
>
> (Updated des. 14, 2014, 3:38 p.m.)
>
>
> Review request for kdelibs.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Appears to be a syntax issue with kfilemetainfo.h and kfilemetainfo.cpp that is \
> breaking the build of kdelibs in the 4.13 branch.
>
> Diffs
> -----
>
> kio/kio/kfilemetainfo.h 6920ffe
> kio/kio/kfilemetainfo.cpp 84fb329
>
> Diff: https://git.reviewboard.kde.org/r/121511/diff/
>
>
> Testing
> -------
>
> This appears to be a syntax error.
>
> This was causing problems when doing a build under Windows (with emerge kdelibs \
> under mingw4). Checking the source code of the kdelibs package in Ubuntu (13.10), \
> it appears to also suffer from the same error so this may be a bigger issue than \
> just on this branch.
> This fixes the build but I don't know how to check if it impacts any of the other \
> applications.
>
> Thanks,
>
> Paul Manners
>
>
--===============4701372521167874034==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121511/">https://git.reviewboard.kde.org/r/121511/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Don't \
change public headers.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">It's just that the no_strigi part of \
the .cpp code is broken, fix that part.</p></pre> <br />
<p>- Albert Astals Cid</p>
<br />
<p>On desembre 14th, 2014, 3:38 p.m. UTC, Paul Manners wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Paul Manners.</div>
<p style="color: grey;"><i>Updated des. 14, 2014, 3:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Appears to be a syntax issue with kfilemetainfo.h and \
kfilemetainfo.cpp that is breaking the build of kdelibs in the 4.13 branch.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This appears to be a syntax error. </p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This was causing problems when doing a build under Windows (with emerge \
kdelibs under mingw4). Checking the source code of the kdelibs package in Ubuntu \
(13.10), it appears to also suffer from the same error so this may be a bigger issue \
than just on this branch. </p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This fixes the build but I don't know \
how to check if it impacts any of the other applications. </p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/kfilemetainfo.h <span style="color: grey">(6920ffe)</span></li>
<li>kio/kio/kfilemetainfo.cpp <span style="color: grey">(84fb329)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121511/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4701372521167874034==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic