[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 121083: Replace manual export files with CMake's generate_export_header
From: "Hugo Pereira Da Costa" <hugo.pereira () free ! fr>
Date: 2014-11-24 7:50:39
Message-ID: 20141124075039.11305.10699 () probe ! kde ! org
[Download RAW message or body]
--===============6674171746358559261==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Nov. 22, 2014, 12:18 a.m., Harald Sitter wrote:
> > This breaks the kde4 build as ECM is not being used there and \
> > generate_export_header is not available without ECM.
>
> Andrius da Costa Ribas wrote:
> generate_export_header isn't in ECM, but in cmake itself \
> (http://www.cmake.org/cmake/help/v3.0/module/GenerateExportHeader.html). Does kde4 \
> required cmake version not support it? Should I revert this commit?
> Harald Sitter wrote:
> Ah, I was not aware of that. So the solution probably is to move the \
> include(GenerateExportheader) line outside the if-else for kf5/kde4
> Albert Astals Cid wrote:
> Andrius: kdelibs4 has to work on cmake 2.8.9, when was that introduced?
>
> Harald Sitter wrote:
> If kubuntu packaging can be trusted it was there before that (e.g. was already in \
> 2.8.7)
> Thomas Lübking wrote:
> http://www.cmake.org/cmake/help/v2.8.9/cmake.html#module:GenerateExportHeader
I'm running cmake 3.1 here and still can't get oxygen to build in KDE4 mode anyway.
Cmake aborts with: Unknown CMake command "generate_export_header"
So surely something seems broken with this patch (missing module include ?)
Can you either test compilation with option -DUSE_KDE4=1, and fix, or provide \
instructions, or revert ?
Thanks !
Hugo
- Hugo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121083/#review70761
-----------------------------------------------------------
On Nov. 21, 2014, 10:47 p.m., Andrius da Costa Ribas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121083/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 10:47 p.m.)
>
>
> Review request for kde-workspace and kdewin.
>
>
> Repository: oxygen
>
>
> Description
> -------
>
> These files currently use
>
> ```
> __attribute__((visibility("...")))
> ```
>
> which doesn't work on MSVC.
>
>
> Diffs
> -----
>
> liboxygen/oxygen_config_export.h 02ea29d
> liboxygen/oxygen_export.h b8877a0
> liboxygen/CMakeLists.txt 69b7bd2
>
> Diff: https://git.reviewboard.kde.org/r/121083/diff/
>
>
> Testing
> -------
>
> Builds with msvc 2013 64bit
>
>
> Thanks,
>
> Andrius da Costa Ribas
>
>
--===============6674171746358559261==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121083/">https://git.reviewboard.kde.org/r/121083/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 22nd, 2014, 12:18 a.m. UTC, <b>Harald \
Sitter</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This breaks the kde4 build as ECM is not being used \
there and generate_export_header is not available without ECM.</p></pre> \
</blockquote>
<p>On November 22nd, 2014, 12:42 a.m. UTC, <b>Andrius da Costa Ribas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">generate_export_header isn't in ECM, but in cmake itself \
(http://www.cmake.org/cmake/help/v3.0/module/GenerateExportHeader.html). Does kde4 \
required cmake version not support it? Should I revert this commit?</p></pre> \
</blockquote>
<p>On November 22nd, 2014, 10:26 a.m. UTC, <b>Harald Sitter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah, I \
was not aware of that. So the solution probably is to move the \
include(GenerateExportheader) line outside the if-else for kf5/kde4</p></pre> \
</blockquote>
<p>On November 22nd, 2014, 2:41 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Andrius: kdelibs4 has to work on cmake 2.8.9, when was that \
introduced?</p></pre> </blockquote>
<p>On November 22nd, 2014, 2:44 p.m. UTC, <b>Harald Sitter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
kubuntu packaging can be trusted it was there before that (e.g. was already in \
2.8.7)</p></pre> </blockquote>
<p>On November 22nd, 2014, 2:46 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">http://www.cmake.org/cmake/help/v2.8.9/cmake.html#module:GenerateExportHeader</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
running cmake 3.1 here and still can't get oxygen to build in KDE4 mode anyway. Cmake \
aborts with: Unknown CMake command "generate_export_header" So surely something seems \
broken with this patch (missing module include ?)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can \
you either test compilation with option -DUSE_KDE4=1, and fix, or provide \
instructions, or revert ? </p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Thanks ! </p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Hugo</p></pre> <br />
<p>- Hugo</p>
<br />
<p>On November 21st, 2014, 10:47 p.m. UTC, Andrius da Costa Ribas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kde-workspace and kdewin.</div>
<div>By Andrius da Costa Ribas.</div>
<p style="color: grey;"><i>Updated Nov. 21, 2014, 10:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
oxygen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">These files currently use </p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: \
125%">__attribute__((visibility(<span style="color: \
#BA2121">"..."</span>))) </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">which doesn't work on MSVC.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds with msvc 2013 64bit</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>liboxygen/oxygen_config_export.h <span style="color: grey">(02ea29d)</span></li>
<li>liboxygen/oxygen_export.h <span style="color: grey">(b8877a0)</span></li>
<li>liboxygen/CMakeLists.txt <span style="color: grey">(69b7bd2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121083/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6674171746358559261==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic