[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 115250: Try PASV mode when using Socks proxy
From: "David Faure" <faure () kde ! org>
Date: 2014-10-27 21:18:46
Message-ID: 20141027211846.23656.95453 () probe ! kde ! org
[Download RAW message or body]
--===============7797542982903979748==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Oct. 27, 2014, 8:42 p.m., David Faure wrote:
> > Why wasn't this committed?
>
> Emil Sedgh wrote:
> I would commit it now, but I'm not sure where should I commit this.
> Is kdelibs/master frozen? Should I commit this to KIO framework now?
You can commit bugfixes to KDE/4.14
In any case yes, commit to kio.git master too.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115250/#review69217
-----------------------------------------------------------
On Jan. 23, 2014, 11:31 a.m., Emil Sedgh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115250/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2014, 11:31 a.m.)
>
>
> Review request for kdelibs, Dawit Alemayehu and David Faure.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> FTP has two modes: PASV and EPSV.
> Not all server's support EPSV.
>
> Currently, kio_ftp gives up on PASV mode if socks proxy is enabled.
> That is because QHostAddress.protocol() returns -1 (unknown protocol) on \
> KUrl("socks://localhost:3128").
> So kio_ftp fails using SOCKS proxy on server's that lack EPSV support.
>
> This patch makes sure kio_ftp will try PASV mode if socks proxy is enabled.
>
>
> Diffs
> -----
>
> kioslave/ftp/ftp.cpp 5bb2e8d
>
> Diff: https://git.reviewboard.kde.org/r/115250/diff/
>
>
> Testing
> -------
>
> Tested a server that lacks EPSV support with and without proxy.
> Seems fine now.
> Used to throw 'Internal Server error'.
>
>
> Thanks,
>
> Emil Sedgh
>
>
--===============7797542982903979748==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115250/">https://git.reviewboard.kde.org/r/115250/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 27th, 2014, 8:42 p.m. UTC, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Why wasn't this committed?</p></pre> </blockquote>
<p>On October 27th, 2014, 9:10 p.m. UTC, <b>Emil Sedgh</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
would commit it now, but I'm not sure where should I commit this. Is kdelibs/master \
frozen? Should I commit this to KIO framework now?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
can commit bugfixes to KDE/4.14</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">In any case yes, commit \
to kio.git master too.</p></pre> <br />
<p>- David</p>
<br />
<p>On January 23rd, 2014, 11:31 a.m. UTC, Emil Sedgh wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs, Dawit Alemayehu and David Faure.</div>
<div>By Emil Sedgh.</div>
<p style="color: grey;"><i>Updated Jan. 23, 2014, 11:31 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">FTP has two modes: PASV and EPSV. Not all server's support EPSV.
Currently, kio_ftp gives up on PASV mode if socks proxy is enabled.
That is because QHostAddress.protocol() returns -1 (unknown protocol) on \
KUrl("socks://localhost:3128").
So kio_ftp fails using SOCKS proxy on server's that lack EPSV support.
This patch makes sure kio_ftp will try PASV mode if socks proxy is enabled.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested a server that lacks EPSV support with and without proxy. Seems \
fine now. Used to throw 'Internal Server error'.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/ftp/ftp.cpp <span style="color: grey">(5bb2e8d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115250/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7797542982903979748==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic