[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin
From: "David Faure" <faure () kde ! org>
Date: 2014-10-18 10:01:35
Message-ID: 20141018100135.21224.18521 () probe ! kde ! org
[Download RAW message or body]
--===============0719353491022556431==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120460/#review68652
-----------------------------------------------------------
you say it's a port, but it reads like new code (no diff). Is that because it moved \
to another module? Makes reviewing a bit harder (though not impossible).
- David Faure
On Oct. 13, 2014, 1:35 p.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120460/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 1:35 p.m.)
>
>
> Review request for kde-workspace and David Faure.
>
>
> Repository: kio-extras
>
>
> Description
> -------
>
> The filenamesearch ioslave lists all files/folders which match with the given \
> search query.
> Made some small adjustments:
> * Ported the ioslave to Qt5/KF5
> * Got rid of cleanup() and member variables
> * Use lambda function validators instead of some weird if + assert things in \
> searchDirectory/contentContainsPattern
> * Immediately return when the search string is empty
>
> https://projects.kde.org/projects/kde/applications/kde-baseapps/repository/revisions/frameworks/show/dolphin/src/search
>
>
> Diffs
> -----
>
> filenamesearch/kio_filenamesearch.h PRE-CREATION
> filenamesearch/kio_filenamesearch.cpp PRE-CREATION
> CMakeLists.txt 2036392
> filenamesearch/CMakeLists.txt PRE-CREATION
> filenamesearch/filenamesearch.protocol PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/120460/diff/
>
>
> Testing
> -------
>
> Compiles.
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
--===============0719353491022556431==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120460/">https://git.reviewboard.kde.org/r/120460/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you \
say it's a port, but it reads like new code (no diff). Is that because it moved to \
another module? Makes reviewing a bit harder (though not impossible).</p></pre> <br \
/>
<p>- David Faure</p>
<br />
<p>On October 13th, 2014, 1:35 p.m. UTC, Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kde-workspace and David Faure.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Oct. 13, 2014, 1:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The filenamesearch ioslave lists all files/folders \
which match with the given search query.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Made some small \
adjustments: <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> Ported the ioslave to Qt5/KF5 </em> Got rid of \
cleanup() and member variables <em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;"> Use lambda function validators instead \
of some weird if + assert things in searchDirectory/contentContainsPattern </em> \
Immediately return when the search string is empty</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">https://projects.kde.org/projects/kde/applications/kde-baseapps/repository/revisions/frameworks/show/dolphin/src/search</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filenamesearch/kio_filenamesearch.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>filenamesearch/kio_filenamesearch.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(2036392)</span></li>
<li>filenamesearch/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>filenamesearch/filenamesearch.protocol <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120460/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0719353491022556431==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic