[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 120627: Remove kdelibs4support.
From: "Kevin Kofler" <kevin.kofler () chello ! at>
Date: 2014-10-17 22:12:57
Message-ID: 20141017221257.21223.78349 () probe ! kde ! org
[Download RAW message or body]
--===============4097452284455906940==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120627/#review68628
-----------------------------------------------------------
(Review of revision 1, because you posted revision 2 while I was still looking at \
revision 1.)
Please make sure you also test Kompare with remote URLs (e.g. text files served over \
http://). Both the command-line parsing and the downloading code have issues related \
to remote URLs that I can see while proofreading and that you have apparently not \
noticed.
Please also test the radio buttons in the dialogs where you replaced KButtonGroup \
with QGroupBox to ensure that they still behave correctly.
komparepart/kompare_part.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47818>
This line looks very wrong to me: You're executing the block only if the stat job \
failed? This needs at least the '!' removed.
Please make sure you test this snippet, which you changed significantly.
komparepart/kompare_part.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47821>
The filter format is not correct for QFileDialog, it expects this format:
"Patch Files (*.diff *.dif *.patch)"
libdialogpages/diffpage.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47822>
QUrl::fromLocalFile is probably the wrong function to call on something called \
m_excludeFilesFileURL. (See also the discussion of the command line handling in \
main.cpp.)
libdialogpages/diffpage.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47823>
I think QUrl("diff") should really be good enough here, it's not an absolute \
path, and we don't need a file://diff URL, we can leave the scheme unset (relative \
URL).
libdialogpages/diffpage.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47824>
The layout->setSpacing calls can be deleted entirely. KDialog::spacingHint in \
current kdelibs4 only returned the default layout spacing that QLayout uses anyway.
libdialogpages/diffpage.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47825>
The layout->setMargin calls can be deleted entirely. KDialog::marginHint in \
current kdelibs4 only returned the default child margin that QLayout uses anyway.
libdialogpages/diffpage.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47826>
See above.
libdialogpages/diffpage.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47827>
See above.
libdialogpages/diffpage.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47828>
See above.
libdialogpages/diffpage.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47829>
See above.
libdialogpages/diffpage.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47830>
See above.
libdialogpages/diffpage.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47831>
See above.
libdialogpages/diffpage.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47832>
See above.
libdialogpages/filespage.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47833>
See above.
libdialogpages/filespage.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47834>
See above.
libdialogpages/filespage.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47835>
QUrl::fromLocalFile can't be right here. You may need the same treatment as for \
the command line (see main.cpp).
libdialogpages/filespage.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47836>
See above.
libdialogpages/filespage.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47837>
See above.
libdialogpages/filespage.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47838>
See above.
libdialogpages/pagebase.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47839>
This one should wait until it passes your own testing.
main.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47808>
All these parser.addOption calls must come before the call to parser.process.
main.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47810>
I think this now needs something like:
QDir::isAbsolutePath(args.at(0)) ? QUrl::fromLocalFile(args.at(0)) : \
QUrl(args.at(0))
QUrl really needs a static method for that, neither the constructor, nor \
fromLocalFile, nor fromUserInput do the right thing in this context. I'm going to ask \
on kde-core-devel if I'm missing something.
This shows up so often in this function that it might be worth putting it into a \
helper function.
main.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47811>
Here too:
QDir::isAbsolutePath(args.at(0)) ? QUrl::fromLocalFile(args.at(0)) : \
QUrl(args.at(0))
main.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47812>
Here too:
QDir::isAbsolutePath(args.at(1)) ? QUrl::fromLocalFile(args.at(1)) : \
QUrl(args.at(1))
main.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47813>
Here too:
QDir::isAbsolutePath(args.at(0)) ? QUrl::fromLocalFile(args.at(0)) : \
QUrl(args.at(0))
main.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47814>
Here too:
QDir::isAbsolutePath(args.at(1)) ? QUrl::fromLocalFile(args.at(1)) : \
QUrl(args.at(1))
main.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47815>
Here too:
QDir::isAbsolutePath(args.at(0)) ? QUrl::fromLocalFile(args.at(0)) : \
QUrl(args.at(0))
main.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47816>
Here too:
QDir::isAbsolutePath(args.at(0)) ? QUrl::fromLocalFile(args.at(0)) : \
QUrl(args.at(0))
main.cpp
<https://git.reviewboard.kde.org/r/120627/#comment47817>
Here too:
QDir::isAbsolutePath(args.at(1)) ? QUrl::fromLocalFile(args.at(1)) : \
QUrl(args.at(1))
- Kevin Kofler
On Okt. 17, 2014, 9:38 nachm., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120627/
> -----------------------------------------------------------
>
> (Updated Okt. 17, 2014, 9:38 nachm.)
>
>
> Review request for kdelibs and Kevin Kofler.
>
>
> Repository: kompare
>
>
> Description
> -------
>
> Change KUrl to QUrl.
> Use QLayout/QFrame instead of KVBox (seems broken though somehow)
> Use QFileDialog instead of KFileDialog.
>
>
> Diffs
> -----
>
> libdialogpages/viewpage.cpp 07bdba5e1edf55a6dcd02e5deef58d30c07660c2
> libdialogpages/viewsettings.h dbf6afe0d0c70e548e32dfc09391d67ef595cdba
> libdialogpages/viewsettings.cpp 5a69d0bd9a49f7a3881940c4ea8ad407be56adc1
> main.cpp 4132c8442f8546ee7d365051dda0e32196249217
> libdialogpages/diffpage.h 37490b1ebb245e9648530429da63a9240010dddd
> libdialogpages/diffpage.cpp 7800b486e023cffe41e1fa3e9e60781250ea4199
> libdialogpages/filespage.h 42afafcd0fc8bc0a01e32b79d414742937d791fb
> libdialogpages/filespage.cpp 6a87fe36abd57bdaa09b516de38969db6c6f2298
> libdialogpages/filessettings.h dc3306e34fe1b4eb7cb6a9d2b598f91932bedda0
> libdialogpages/filessettings.cpp 0e19dc00f22a2f6e9588bf2d110dbde682888472
> libdialogpages/pagebase.h 0cef46feaa2cc81deff12c2c5f739e6be6df1b49
> libdialogpages/pagebase.cpp ba1574aed7124ede49e1c5908a8fe693cf7bc5d3
> libdialogpages/viewpage.h b5b770d1441650564106e1cc7ef7e587f6ee142d
> komparepart/komparesplitter.cpp 8d496bf279caa7cb9a305c2d15131f591c48818d
> kompareurldialog.h dc50c588e70835ad9292da1baf5222f58f512f67
> kompareurldialog.cpp 7de050bc44770a79f8f7d789cabd95d6707a40f1
> libdialogpages/CMakeLists.txt 769a1154c56e8eb8aa42f1bc6d84e0f9a4154fd0
> libdialogpages/dialogpagesexport.h b2de57f6616739d353d4889ef4965ab07f1191aa
> komparenavtreepart/komparenavtreepart.cpp 3faceff78fbbd2f083cd0a7837c74f50fe543474
> komparepart/CMakeLists.txt 09b61e6ca0cdce391fc759be49a672a050cc16cd
> komparepart/kompare_part.h 24475f1b0ccf7fbeda56860a9a69955cd0b82808
> komparepart/kompare_part.cpp 4d40be0dedcfb91b77ee239de11188b328f8bc13
> komparepart/komparelistview.cpp 35bbab849d8b7938cba518e97a00ed50cae35612
> komparepart/kompareprefdlg.cpp 118485663390e9563a77741b490a9cdf8bf6d464
> komparepart/komparesaveoptionswidget.cpp 4c9acba6a7f9c6dda04130946faac37138422875
> CMakeLists.txt 38167c2099d0ea1600bd5a6893982e809902fa3a
> doc/index.docbook 578d12a41d9a6afed441ffd38c39bff16c096ab2
> interfaces/kompareinterface.h 53b19d944b2a4a65c14ea41b8f1c0997581933db
> kompare_shell.h 8549fcdc4d1536c58734f2bc3a78b9ebc42c6c5f
> kompare_shell.cpp dcc45513f3f9f5f94869046989b6b4f5b1c0995e
> komparenavtreepart/CMakeLists.txt 53e8e670e70629afac9197fc108d844733ec5c07
>
> Diff: https://git.reviewboard.kde.org/r/120627/diff/
>
>
> Testing
> -------
>
> It builds and runs. The compare dialog ui looks squished though and doesn't resize \
> like it used to, must be something I did wrong when porting away from KVBox
>
> Thanks,
>
> Jeremy Whiting
>
>
--===============4097452284455906940==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120627/">https://git.reviewboard.kde.org/r/120627/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">(Review of revision 1, because you posted revision 2 while I was still \
looking at revision 1.)</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Please make sure you also test Kompare \
with remote URLs (e.g. text files served over http://). Both the command-line parsing \
and the downloading code have issues related to remote URLs that I can see while \
proofreading and that you have apparently not noticed.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please also test the radio buttons in the dialogs where you replaced \
KButtonGroup with QGroupBox to ensure that they still behave correctly.</p></pre> \
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320254#file320254line295" \
style="color: black; font-weight: bold; text-decoration: \
underline;">komparepart/kompare_part.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
KomparePart::openDiff3( const QString& diff3Output )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">290</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="tb"> </span><span class="k">if</span> <span class="p">(</span> <span \
class="o">!</span><span class="n">node</span><span class="p">.</span><span \
class="n">isDir</span><span class="p">()</span> <span class="p">)</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">287</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">statJob</span><span class="o">-></span><span class="n">exec</span><span \
class="p">()</span> <span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
line looks very wrong to me: You're executing the block only if the stat job failed? \
This needs at least the '!' removed.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Please make sure you \
test this snippet, which you changed significantly.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320254#file320254line567" \
style="color: black; font-weight: bold; text-decoration: \
underline;">komparepart/kompare_part.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
KomparePart::saveAll()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">552</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="n"><span \
class="hl">K</span>Url</span> <span class="n">url</span> <span class="o">=</span> \
<span class="n"><span class="hl">K</span>FileDialog</span><span \
class="o">::</span><span class="n">getSaveUrl</span><span class="p">(</span> <span \
class="n"><span class="hl">m_info</span></span><span class="p"><span \
class="hl">.</span></span><span class="n"><span \
class="hl">destination</span></span><span class="p"><span \
class="hl">.</span></span><span class="n"><span class="hl">url</span></span><span \
class="p">(),</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">555</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="n"><span \
class="hl">Q</span>Url</span> <span class="n">url</span> <span class="o">=</span> \
<span class="n"><span class="hl">Q</span>FileDialog</span><span \
class="o">::</span><span class="n">getSave<span class="hl">File</span>Url</span><span \
class="p">(</span> <span class="n"><span class="hl">widget</span></span><span \
class="p">(),</span><span class="hl"> </span><span class="n"><span \
class="hl">i18n</span></span><span class="p"><span class="hl">(</span></span><span \
class="hl"> </span><span class="s"><span class="hl">"Save \
.diff"</span></span><span class="hl"> </span><span class="p"><span \
class="hl">),</span></span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
filter format is not correct for QFileDialog, it expects this format: "Patch Files \
(<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">.diff </em>.dif *.patch)"</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320264#file320264line100" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/diffpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DiffPage::setSettings( DiffSettings* setts )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">99</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">m_excludeFileURLComboBox</span><span class="o">-></span><span \
class="n">setUrl</span> <span class="p">(</span> <span class="n"><span \
class="hl">K</span>Url</span><span class="p">(</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">m_excludeFilesFileURL</span> <span class="p">)</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">94</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">m_excludeFileURLComboBox</span><span class="o">-></span><span \
class="n">setUrl</span> <span class="p">(</span> <span class="n"><span \
class="hl">Q</span>Url</span><span class="o"><span class="hl">::</span></span><span \
class="n"><span class="hl">fromLocalFile</span></span><span class="p">(</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">m_excludeFilesFileURL</span> <span class="p">)</span> <span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">QUrl::fromLocalFile is probably the wrong function to call on something \
called m_excludeFilesFileURL. (See also the discussion of the command line handling \
in main.cpp.)</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320264#file320264line147" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/diffpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DiffPage::apply()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">146</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">m_diffURLRequester</span><span class="o">-></span><span \
class="n">setUrl</span><span class="p">(</span> <span class="n"><span \
class="hl">K</span>Url</span><span class="p">(</span> <span \
class="s">"diff"</span> <span class="p">)</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">141</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">m_diffURLRequester</span><span class="o">-></span><span \
class="n">setUrl</span><span class="p">(</span> <span class="n"><span \
class="hl">Q</span>Url</span><span class="o"><span class="hl">::</span></span><span \
class="n"><span class="hl">fromLocalFile</span></span><span class="p">(</span> <span \
class="s">"diff"</span> <span class="p">)</span> <span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think QUrl("diff") should really be good enough here, it's not an absolute path, and \
we don't need a file://diff URL, we can leave the scheme unset (relative \
URL).</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320264#file320264line202" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/diffpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DiffPage::slotExcludeFileToggled( bool on )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">201</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">layout</span><span class="o">-></span><span \
class="n">setSpacing</span><span class="p">(</span> <span \
class="n">KDialog</span><span class="o">::</span><span \
class="n">spacingHint</span><span class="p">()</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">196</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="hl"><span \
class="tb"> </span></span><span class="c1"><span \
class="hl">//</span>layout->setSpacing( KDialog::spacingHint() \
);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
layout->setSpacing calls can be deleted entirely. KDialog::spacingHint in current \
kdelibs4 only returned the default layout spacing that QLayout uses anyway.</p></pre> \
</div> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320264#file320264line203" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/diffpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DiffPage::slotExcludeFileToggled( bool on )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">202</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">layout</span><span class="o">-></span><span \
class="n">setMargin</span><span class="p">(</span> <span \
class="n">KDialog</span><span class="o">::</span><span \
class="n">marginHint</span><span class="p">()</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">197</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="hl"><span \
class="tb"> </span></span><span class="c1"><span \
class="hl">//</span>layout->setMargin( KDialog::marginHint() );</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
layout->setMargin calls can be deleted entirely. KDialog::marginHint in current \
kdelibs4 only returned the default child margin that QLayout uses anyway.</p></pre> \
</div> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320264#file320264line227" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/diffpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DiffPage::addDiffTab()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">226</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">layout</span><span class="o">-></span><span \
class="n">setSpacing</span><span class="p">(</span> <span \
class="n">KDialog</span><span class="o">::</span><span \
class="n">spacingHint</span><span class="p">()</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">221</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="hl"><span \
class="tb"> </span></span><span class="c1"><span \
class="hl">//</span>layout->setSpacing( KDialog::spacingHint() \
);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See \
above.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320264#file320264line228" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/diffpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DiffPage::addDiffTab()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">227</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">layout</span><span class="o">-></span><span \
class="n">setMargin</span><span class="p">(</span> <span \
class="n">KDialog</span><span class="o">::</span><span \
class="n">marginHint</span><span class="p">()</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">222</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="hl"><span \
class="tb"> </span></span><span class="c1"><span \
class="hl">//</span>layout->setMargin( KDialog::marginHint() );</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See \
above.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320264#file320264line277" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/diffpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DiffPage::addFormatTab()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">276</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">layout</span><span class="o">-></span><span \
class="n">setSpacing</span><span class="p">(</span> <span \
class="n">KDialog</span><span class="o">::</span><span \
class="n">spacingHint</span><span class="p">()</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">271</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="hl"><span \
class="tb"> </span></span><span class="c1"><span \
class="hl">//</span>layout->setSpacing( KDialog::spacingHint() \
);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See \
above.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320264#file320264line278" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/diffpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DiffPage::addFormatTab()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">277</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">layout</span><span class="o">-></span><span \
class="n">setMargin</span><span class="p">(</span> <span \
class="n">KDialog</span><span class="o">::</span><span \
class="n">marginHint</span><span class="p">()</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">272</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="hl"><span \
class="tb"> </span></span><span class="c1"><span \
class="hl">//</span>layout->setMargin( KDialog::marginHint() );</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See \
above.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320264#file320264line309" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/diffpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DiffPage::addOptionsTab()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">308</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">groupLayout</span><span class="o">-></span><span \
class="n">setMargin</span><span class="p">(</span> <span \
class="n">KDialog</span><span class="o">::</span><span \
class="n">marginHint</span><span class="p">()</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">303</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="hl"><span \
class="tb"> </span></span><span class="c1"><span \
class="hl">//</span>groupLayout->setMargin( KDialog::marginHint() \
);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See \
above.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320264#file320264line367" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/diffpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DiffPage::addOptionsTab()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">366</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">layout</span><span class="o">-></span><span \
class="n">setSpacing</span><span class="p">(</span> <span \
class="n">KDialog</span><span class="o">::</span><span \
class="n">spacingHint</span><span class="p">()</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">361</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="hl"><span \
class="tb"> </span></span><span class="c1"><span \
class="hl">//</span>layout->setSpacing( KDialog::spacingHint() \
);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See \
above.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320264#file320264line368" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/diffpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DiffPage::addOptionsTab()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">367</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">layout</span><span class="o">-></span><span \
class="n">setMargin</span><span class="p">(</span> <span \
class="n">KDialog</span><span class="o">::</span><span \
class="n">marginHint</span><span class="p">()</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">362</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="hl"><span \
class="tb"> </span></span><span class="c1"><span \
class="hl">//</span>layout->setMargin( KDialog::marginHint() );</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See \
above.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320266#file320266line41" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/filespage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">41</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">layout</span><span class="o">-></span><span \
class="n">setSpacing</span><span class="p">(</span> <span \
class="n">KDialog</span><span class="o">::</span><span \
class="n">spacingHint</span><span class="p">()</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">37</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="hl"><span \
class="tb"> </span></span><span class="c1"><span \
class="hl">//</span>layout->setSpacing( KDialog::spacingHint() \
);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See \
above.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320266#file320266line42" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/filespage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">42</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">layout</span><span class="o">-></span><span \
class="n">setMargin</span><span class="p">(</span> <span \
class="n">KDialog</span><span class="o">::</span><span \
class="n">marginHint</span><span class="p">()</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">38</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="hl"><span \
class="tb"> </span></span><span class="c1"><span \
class="hl">//</span>layout->setMargin( KDialog::marginHint() );</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See \
above.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320266#file320266line114" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/filespage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
FilesPage::setSecondGroupBoxTitle( const QString& title )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">114</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">m_firstURLComboBox</span><span class="o">-></span><span \
class="n">setUrl</span><span class="p">(</span> <span class="n"><span \
class="hl">K</span>Url</span><span class="p">(</span> <span \
class="n">m_firstURLComboBox</span><span class="o">-></span><span \
class="n">currentText</span><span class="p">()</span> <span class="p">)</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">110</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">m_firstURLComboBox</span><span class="o">-></span><span \
class="n">setUrl</span><span class="p">(</span> <span class="n"><span \
class="hl">Q</span>Url</span><span class="o"><span class="hl">::</span></span><span \
class="n"><span class="hl">fromLocalFile</span></span><span class="p">(</span> <span \
class="n">m_firstURLComboBox</span><span class="o">-></span><span \
class="n">currentText</span><span class="p">()</span> <span class="p">)</span> <span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">QUrl::fromLocalFile can't be right here. You may need the same treatment as \
for the command line (see main.cpp).</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320266#file320266line115" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/filespage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
FilesPage::setSecondGroupBoxTitle( const QString& title )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">115</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">m_secondURLComboBox</span><span class="o">-></span><span \
class="n">setUrl</span><span class="p">(</span> <span class="n"><span \
class="hl">K</span>Url</span><span class="p">(</span> <span \
class="n">m_secondURLComboBox</span><span class="o">-></span><span \
class="n">currentText</span><span class="p">()</span> <span class="p">)</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">111</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">m_secondURLComboBox</span><span class="o">-></span><span \
class="n">setUrl</span><span class="p">(</span> <span class="n"><span \
class="hl">Q</span>Url</span><span class="o"><span class="hl">::</span></span><span \
class="n"><span class="hl">fromLocalFile</span></span><span class="p">(</span> <span \
class="n">m_secondURLComboBox</span><span class="o">-></span><span \
class="n">currentText</span><span class="p">()</span> <span class="p">)</span> <span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See \
above.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320266#file320266line134" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/filespage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
FilesPage::setSecondURLRequesterMode( unsigned int mode )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">134</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">m_firstURLComboBox</span><span class="o">-></span><span \
class="n">setUrl</span><span class="p">(</span> <span class="n"><span \
class="hl">K</span>Url</span><span class="p">(</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">m_lastChosenSourceURL</span> <span class="p">)</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">130</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">m_firstURLComboBox</span><span class="o">-></span><span \
class="n">setUrl</span><span class="p">(</span> <span class="n"><span \
class="hl">Q</span>Url</span><span class="o"><span class="hl">::</span></span><span \
class="n"><span class="hl">fromLocalFile</span></span><span class="p">(</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">m_lastChosenSourceURL</span> <span class="p">)</span> <span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See \
above.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320266#file320266line136" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/filespage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
FilesPage::setSecondURLRequesterMode( unsigned int mode )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">136</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">m_secondURLComboBox</span><span class="o">-></span><span \
class="n">setUrl</span><span class="p">(</span> <span class="n"><span \
class="hl">K</span>Url</span><span class="p">(</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">m_lastChosenDestinationURL</span> <span class="p">)</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">132</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">m_secondURLComboBox</span><span class="o">-></span><span \
class="n">setUrl</span><span class="p">(</span> <span class="n"><span \
class="hl">Q</span>Url</span><span class="o"><span class="hl">::</span></span><span \
class="n"><span class="hl">fromLocalFile</span></span><span class="p">(</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">m_lastChosenDestinationURL</span> <span class="p">)</span> <span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See \
above.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320270#file320270line24" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libdialogpages/pagebase.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">24</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">PageBase</span><span class="o">::</span><span \
class="n">PageBase</span><span class="p">()</span> <span class="o">:</span> <span \
class="n"><span class="hl">KVBox</span></span><span class="p">()</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">24</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">PageBase</span><span class="o">::</span><span \
class="n">PageBase</span><span class="p">()</span> <span class="o">:</span> <span \
class="n"><span class="hl">QFrame</span></span><span class="p">()</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
one should wait until it passes your own testing.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320275#file320275line83" \
style="color: black; font-weight: bold; text-decoration: underline;">main.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
const char version[] = "4.1.3";</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">81</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">options</span><span class="p">.</span><span class="n">add</span><span \
class="p">(</span><span class="s">"+-"</span><span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">82</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">parser</span><span class="p">.</span><span class="n">addOption</span><span \
class="p">(</span><span class="n">QCommandLineOption</span><span \
class="p">(</span><span class="s">"c"</span><span class="p">,</span> <span \
class="n">i18n</span><span class="p">(</span><span class="s">"This will compare \
URL1 with URL2"</span><span class="p">)));</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All \
these parser.addOption calls must come before the call to parser.process.</p></pre> \
</div> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320275#file320275line132" \
style="color: black; font-weight: bold; text-decoration: underline;">main.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
const char version[] = "4.1.3";</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">126</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="tb"> </span><span class="n">ks</span><span class="o">-></span><span \
class="n">openDiff</span><span class="p">(</span> <span class="n">args</span><span \
class="o"><span class="hl">-></span></span><span class="n"><span \
class="hl">url</span></span><span class="p">(</span> <span class="mi">0</span> <span \
class="p">)</span> <span class="p">);</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">130</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="tb"> </span><span class="n">ks</span><span class="o">-></span><span \
class="n">openDiff</span><span class="p">(</span> <span class="n">args</span><span \
class="p"><span class="hl">.</span></span><span class="n"><span \
class="hl">at</span></span><span class="p">(</span> <span class="mi">0</span> <span \
class="p">)</span> <span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think this now needs something like: QDir::isAbsolutePath(args.at(0)) ? \
QUrl::fromLocalFile(args.at(0)) : QUrl(args.at(0))</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QUrl \
really needs a static method for that, neither the constructor, nor fromLocalFile, \
nor fromUserInput do the right thing in this context. I'm going to ask on \
kde-core-devel if I'm missing something.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This shows up so often \
in this function that it might be worth putting it into a helper function.</p></pre> \
</div> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320275#file320275line147" \
style="color: black; font-weight: bold; text-decoration: underline;">main.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
const char version[] = "4.1.3";</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">141</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="n"><span class="hl">K</span>Url</span> <span class="n">url0</span> <span \
class="o">=</span> <span class="n">args</span><span class="o"><span \
class="hl">-></span></span><span class="n"><span class="hl">url</span></span><span \
class="p">(</span> <span class="mi">0</span> <span class="p">);</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">145</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="tb"> </span><span class="n"><span class="hl">Q</span>Url</span> <span \
class="n">url0</span> <span class="o">=</span> <span class="n"><span \
class="hl">QUrl</span></span><span class="o"><span class="hl">::</span></span><span \
class="n"><span class="hl">fromLocalFile</span></span><span class="p"><span \
class="hl">(</span></span><span class="n">args</span><span class="p"><span \
class="hl">.</span></span><span class="n"><span class="hl">at</span></span><span \
class="p">(</span> <span class="mi">0</span> <span class="p">)<span \
class="hl">)</span>;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here \
too: QDir::isAbsolutePath(args.at(0)) ? QUrl::fromLocalFile(args.at(0)) : \
QUrl(args.at(0))</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320275#file320275line149" \
style="color: black; font-weight: bold; text-decoration: underline;">main.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
const char version[] = "4.1.3";</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">143</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="n"><span class="hl">K</span>Url</span> <span class="n">url1</span> <span \
class="o">=</span> <span class="n">args</span><span class="o"><span \
class="hl">-></span></span><span class="n"><span class="hl">url</span></span><span \
class="p">(</span> <span class="mi">1</span> <span class="p">);</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">147</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="tb"> </span><span class="n"><span class="hl">Q</span>Url</span> <span \
class="n">url1</span> <span class="o">=</span> <span class="n"><span \
class="hl">QUrl</span></span><span class="o"><span class="hl">::</span></span><span \
class="n"><span class="hl">fromLocalFile</span></span><span class="p"><span \
class="hl">(</span></span><span class="n">args</span><span class="p"><span \
class="hl">.</span></span><span class="n"><span class="hl">at</span></span><span \
class="p">(</span> <span class="mi">1</span> <span class="p">)<span \
class="hl">)</span>;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here \
too: QDir::isAbsolutePath(args.at(1)) ? QUrl::fromLocalFile(args.at(1)) : \
QUrl(args.at(1))</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320275#file320275line167" \
style="color: black; font-weight: bold; text-decoration: underline;">main.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
const char version[] = "4.1.3";</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">161</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="n"><span class="hl">K</span>Url</span> <span class="n">url0</span> <span \
class="o">=</span> <span class="n">args</span><span class="o"><span \
class="hl">-></span></span><span class="n"><span class="hl">url</span></span><span \
class="p">(</span> <span class="mi">0</span> <span class="p">);</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">165</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="tb"> </span><span class="n"><span class="hl">Q</span>Url</span> <span \
class="n">url0</span> <span class="o">=</span> <span class="n"><span \
class="hl">QUrl</span></span><span class="o"><span class="hl">::</span></span><span \
class="n"><span class="hl">fromLocalFile</span></span><span class="p"><span \
class="hl">(</span></span><span class="n">args</span><span class="p"><span \
class="hl">.</span></span><span class="n"><span class="hl">at</span></span><span \
class="p">(</span> <span class="mi">0</span> <span class="p">)<span \
class="hl">)</span>;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here \
too: QDir::isAbsolutePath(args.at(0)) ? QUrl::fromLocalFile(args.at(0)) : \
QUrl(args.at(0))</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320275#file320275line169" \
style="color: black; font-weight: bold; text-decoration: underline;">main.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
const char version[] = "4.1.3";</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">163</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="n"><span class="hl">K</span>Url</span> <span class="n">url1</span> <span \
class="o">=</span> <span class="n">args</span><span class="o"><span \
class="hl">-></span></span><span class="n"><span class="hl">url</span></span><span \
class="p">(</span> <span class="mi">1</span> <span class="p">);</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">167</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="tb"> </span><span class="n"><span class="hl">Q</span>Url</span> <span \
class="n">url1</span> <span class="o">=</span> <span class="n"><span \
class="hl">QUrl</span></span><span class="o"><span class="hl">::</span></span><span \
class="n"><span class="hl">fromLocalFile</span></span><span class="p"><span \
class="hl">(</span></span><span class="n">args</span><span class="p"><span \
class="hl">.</span></span><span class="n"><span class="hl">at</span></span><span \
class="p">(</span> <span class="mi">1</span> <span class="p">)<span \
class="hl">)</span>;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here \
too: QDir::isAbsolutePath(args.at(1)) ? QUrl::fromLocalFile(args.at(1)) : \
QUrl(args.at(1))</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320275#file320275line183" \
style="color: black; font-weight: bold; text-decoration: underline;">main.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
const char version[] = "4.1.3";</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">177</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="n">ks</span><span class="o">-></span><span class="n">openDiff</span><span \
class="p">(</span> <span class="n">args</span><span class="o"><span \
class="hl">-></span></span><span class="n"><span class="hl">url</span></span><span \
class="p">(</span> <span class="mi">0</span> <span class="p">)</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">181</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="n">ks</span><span class="o">-></span><span class="n">openDiff</span><span \
class="p">(</span> <span class="n"><span class="hl">QUrl</span></span><span \
class="o"><span class="hl">::</span></span><span class="n"><span \
class="hl">fromLocalFile</span></span><span class="p"><span \
class="hl">(</span></span><span class="n">args</span><span class="p"><span \
class="hl">.</span></span><span class="n"><span class="hl">at</span></span><span \
class="p">(</span> <span class="mi">0</span> <span class="p">)</span> <span \
class="p">)</span><span class="hl"> </span><span class="p"><span \
class="hl">)</span>;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here \
too: QDir::isAbsolutePath(args.at(0)) ? QUrl::fromLocalFile(args.at(0)) : \
QUrl(args.at(0))</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320275#file320275line193" \
style="color: black; font-weight: bold; text-decoration: underline;">main.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
const char version[] = "4.1.3";</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">187</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="n"><span \
class="hl">K</span>Url</span> <span class="n">url0</span> <span class="o">=</span> \
<span class="n">args</span><span class="o"><span class="hl">-></span></span><span \
class="n"><span class="hl">url</span></span><span class="p">(</span> <span \
class="mi">0</span> <span class="p">);</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">191</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="n"><span \
class="hl">Q</span>Url</span> <span class="n">url0</span> <span class="o">=</span> \
<span class="n"><span class="hl">QUrl</span></span><span class="o"><span \
class="hl">::</span></span><span class="n"><span \
class="hl">fromLocalFile</span></span><span class="p"><span \
class="hl">(</span></span><span class="n">args</span><span class="p"><span \
class="hl">.</span></span><span class="n"><span class="hl">at</span></span><span \
class="p">(</span> <span class="mi">0</span> <span class="p">)<span \
class="hl">)</span>;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here \
too: QDir::isAbsolutePath(args.at(0)) ? QUrl::fromLocalFile(args.at(0)) : \
QUrl(args.at(0))</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120627/diff/1/?file=320275#file320275line195" \
style="color: black; font-weight: bold; text-decoration: underline;">main.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
const char version[] = "4.1.3";</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">189</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="n"><span \
class="hl">K</span>Url</span> <span class="n">url1</span> <span class="o">=</span> \
<span class="n">args</span><span class="o"><span class="hl">-></span></span><span \
class="n"><span class="hl">url</span></span><span class="p">(</span> <span \
class="mi">1</span> <span class="p">);</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">193</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="n"><span \
class="hl">Q</span>Url</span> <span class="n">url1</span> <span class="o">=</span> \
<span class="n"><span class="hl">QUrl</span></span><span class="o"><span \
class="hl">::</span></span><span class="n"><span \
class="hl">fromLocalFile</span></span><span class="p"><span \
class="hl">(</span></span><span class="n">args</span><span class="p"><span \
class="hl">.</span></span><span class="n"><span class="hl">at</span></span><span \
class="p">(</span> <span class="mi">1</span> <span class="p">)<span \
class="hl">)</span>;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here \
too: QDir::isAbsolutePath(args.at(1)) ? QUrl::fromLocalFile(args.at(1)) : \
QUrl(args.at(1))</p></pre> </div>
</div>
<br />
<p>- Kevin Kofler</p>
<br />
<p>On Oktober 17th, 2014, 9:38 nachm. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs and Kevin Kofler.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Okt. 17, 2014, 9:38 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kompare
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Change KUrl to QUrl. Use QLayout/QFrame instead of \
KVBox (seems broken though somehow) Use QFileDialog instead of KFileDialog.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It builds and runs. The compare dialog ui looks \
squished though and doesn't resize like it used to, must be something I did wrong \
when porting away from KVBox</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libdialogpages/viewpage.cpp <span style="color: \
grey">(07bdba5e1edf55a6dcd02e5deef58d30c07660c2)</span></li>
<li>libdialogpages/viewsettings.h <span style="color: \
grey">(dbf6afe0d0c70e548e32dfc09391d67ef595cdba)</span></li>
<li>libdialogpages/viewsettings.cpp <span style="color: \
grey">(5a69d0bd9a49f7a3881940c4ea8ad407be56adc1)</span></li>
<li>main.cpp <span style="color: \
grey">(4132c8442f8546ee7d365051dda0e32196249217)</span></li>
<li>libdialogpages/diffpage.h <span style="color: \
grey">(37490b1ebb245e9648530429da63a9240010dddd)</span></li>
<li>libdialogpages/diffpage.cpp <span style="color: \
grey">(7800b486e023cffe41e1fa3e9e60781250ea4199)</span></li>
<li>libdialogpages/filespage.h <span style="color: \
grey">(42afafcd0fc8bc0a01e32b79d414742937d791fb)</span></li>
<li>libdialogpages/filespage.cpp <span style="color: \
grey">(6a87fe36abd57bdaa09b516de38969db6c6f2298)</span></li>
<li>libdialogpages/filessettings.h <span style="color: \
grey">(dc3306e34fe1b4eb7cb6a9d2b598f91932bedda0)</span></li>
<li>libdialogpages/filessettings.cpp <span style="color: \
grey">(0e19dc00f22a2f6e9588bf2d110dbde682888472)</span></li>
<li>libdialogpages/pagebase.h <span style="color: \
grey">(0cef46feaa2cc81deff12c2c5f739e6be6df1b49)</span></li>
<li>libdialogpages/pagebase.cpp <span style="color: \
grey">(ba1574aed7124ede49e1c5908a8fe693cf7bc5d3)</span></li>
<li>libdialogpages/viewpage.h <span style="color: \
grey">(b5b770d1441650564106e1cc7ef7e587f6ee142d)</span></li>
<li>komparepart/komparesplitter.cpp <span style="color: \
grey">(8d496bf279caa7cb9a305c2d15131f591c48818d)</span></li>
<li>kompareurldialog.h <span style="color: \
grey">(dc50c588e70835ad9292da1baf5222f58f512f67)</span></li>
<li>kompareurldialog.cpp <span style="color: \
grey">(7de050bc44770a79f8f7d789cabd95d6707a40f1)</span></li>
<li>libdialogpages/CMakeLists.txt <span style="color: \
grey">(769a1154c56e8eb8aa42f1bc6d84e0f9a4154fd0)</span></li>
<li>libdialogpages/dialogpagesexport.h <span style="color: \
grey">(b2de57f6616739d353d4889ef4965ab07f1191aa)</span></li>
<li>komparenavtreepart/komparenavtreepart.cpp <span style="color: \
grey">(3faceff78fbbd2f083cd0a7837c74f50fe543474)</span></li>
<li>komparepart/CMakeLists.txt <span style="color: \
grey">(09b61e6ca0cdce391fc759be49a672a050cc16cd)</span></li>
<li>komparepart/kompare_part.h <span style="color: \
grey">(24475f1b0ccf7fbeda56860a9a69955cd0b82808)</span></li>
<li>komparepart/kompare_part.cpp <span style="color: \
grey">(4d40be0dedcfb91b77ee239de11188b328f8bc13)</span></li>
<li>komparepart/komparelistview.cpp <span style="color: \
grey">(35bbab849d8b7938cba518e97a00ed50cae35612)</span></li>
<li>komparepart/kompareprefdlg.cpp <span style="color: \
grey">(118485663390e9563a77741b490a9cdf8bf6d464)</span></li>
<li>komparepart/komparesaveoptionswidget.cpp <span style="color: \
grey">(4c9acba6a7f9c6dda04130946faac37138422875)</span></li>
<li>CMakeLists.txt <span style="color: \
grey">(38167c2099d0ea1600bd5a6893982e809902fa3a)</span></li>
<li>doc/index.docbook <span style="color: \
grey">(578d12a41d9a6afed441ffd38c39bff16c096ab2)</span></li>
<li>interfaces/kompareinterface.h <span style="color: \
grey">(53b19d944b2a4a65c14ea41b8f1c0997581933db)</span></li>
<li>kompare_shell.h <span style="color: \
grey">(8549fcdc4d1536c58734f2bc3a78b9ebc42c6c5f)</span></li>
<li>kompare_shell.cpp <span style="color: \
grey">(dcc45513f3f9f5f94869046989b6b4f5b1c0995e)</span></li>
<li>komparenavtreepart/CMakeLists.txt <span style="color: \
grey">(53e8e670e70629afac9197fc108d844733ec5c07)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120627/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4097452284455906940==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic