[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 120376: drKonqi Fix Bug 337742 - Unable to send report: error code 410 from Bugzi
From: "Ian Wadham" <iandw.au () gmail ! com>
Date: 2014-10-17 6:24:59
Message-ID: 20141017062459.21224.88776 () probe ! kde ! org
[Download RAW message or body]
--===============5350147830335204632==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Sept. 26, 2014, 11:54 a.m., Ian Wadham wrote:
> > Hi Frédéric,
> >
> > As announced on KDE Core devel, in \
> > http://lists.kde.org/?l=kde-core-devel&m=141016488132293&w=2 about 3 weeks ago, I \
> > also am working on Dr Konqi.
> > I am about to publish a general patch, which is aimed at the present problem \
> > posed by the change to tokens in Bugzilla \
> > https://bugs.kde.org/show_bug.cgi?id=337742, but also intends to avoid such \
> > problems in future and to be forward-portable to KF5. My approach is to check the \
> > version number of the Bugzilla software and to switch to whichever security \
> > method is appropriate for that version: cookies, tokens or passwords-only.
> > Of course, my patch will implement tokens for the time being, but the idea is to \
> > switch automatically to passwords-only when the time comes, without any new \
> > release of KDE software being necessary. See \
> > http://www.bugzilla.org/docs/tip/en/html/api/Bugzilla/WebService.html#LOGGING_IN \
> > in the documentation for Bugzilla 4.5.5 (the next version), as opposed to 4.4.5 \
> > (the current version). Bugzilla 4.5.5 allows tokens, but I believe they will be \
> > discontinued at some stage, though I cannot put my finger on where I have seen \
> > that discussion.
> > This should avoid users having to experience further bugs in Dr Konqi's \
> > connection to bugs.kde.org. My patch is also intended to be extendable, so that \
> > Dr Konqi can be updated and re-released, ahead of time, if any further feature \
> > change is announced by Bugzilla and could adversely affect Dr Konqi.
>
> Frédéric Sheedy wrote:
> Great, good news! My patch was only a quick fix to what you are doing.
>
> Ian Wadham wrote:
> I did not mean that you should drop what you are doing and discard this review and \
> patch completely... :-) Instead, we should work together and each be aware of what \
> the other is doing.
> Please revive your patch and this review.
>
> From what I can tell, the patch (after review and shipping) will be good \
> immediately and at least until the version after Bugzilla 4.5.x. Also, your patch \
> has some improvements to the testing, which is important. And I think we need to \
> get a fix into the closing versions of KDE 4 ASAP (next deadline Thursday, 9 \
> October). My fixes will be more long-term and I am running short of days to work on \
> them, due to other commitments, and anyway they may take a while to review... So \
> please revive your review and patch, Frédéric.
> One immediate comment: I found that I could retrieve the token by using the tag \
> "token", but I could not use "token" in the "args" map. I had to use \
> "Bugzilla_token". I have no idea why that is. I am using an Apple OS X platform, \
> but that should not make a difference to a web dialog.
> Ian Wadham wrote:
> Frédéric, please have a look at review https://git.reviewboard.kde.org/r/120431/ \
> particularly the comments of the last 24 hours.
> Somebody is going to have to commit a patch for Dr Konqi before Albert Astals Cid \
> starts tagging KDE 4.14.2 on Thursday night. It will be either your patch, my patch \
> or a simplified version of my patch. If the consensus is to use your patch in KDE \
> 4.14.2 for now, I would like to give it a test on Thursday (Australian time, UTC + \
> 11 hours). I am otherwise engaged today (Wednesday).
> All being well, I could commit your patch, but do you have commit rights yourself?
>
> Frédéric Sheedy wrote:
> Hi Ian,
>
> I do have an account to commit the patch. Let me know of the consensus!
>
> Ian Wadham wrote:
> As you may have seen on https://git.reviewboard.kde.org/r/120431/ the consensus was \
> in favour of a simplified patch, which I edited, tested and later committed on \
> Thursday.
> It is regrettable that neither of our patches received a review from a KDE core \
> developer who is familiar with the Dr Konqi code. Had that happened, things could \
> have proceeded in a more orderly fashion and I am sure that your patch could have \
> been shipped immediately, to fix bug 337742, and mine could have been refined and \
> shipped within the KDE 4.14.3 or 14.12 timeframe.
> Frédéric, I think it is important that your fixes for the Dr Konqi test processes \
> should go into KDE 4.14.3 or 14.12 and also into KF5.
> Thank you very much for your help.
>
> Frédéric Sheedy wrote:
> Hi Ian, thanks for the answer!
>
> As my fixes for Dr Konqui are not for the end users, should I commit it without a \
> review?
If nobody objects, I would say yes, but I am no authority. However, it seems rather \
hard to get a review of changes to Dr Konqi and we are just talking about some small \
changes to file drkonqi/tests/bugzillalibtest/bugzillalibtest.cpp.
- Ian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120376/#review67481
-----------------------------------------------------------
On Oct. 8, 2014, 1:49 a.m., Frédéric Sheedy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120376/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 1:49 a.m.)
>
>
> Review request for KDE Runtime and Ian Wadham.
>
>
> Bugs: 337742
> http://bugs.kde.org/show_bug.cgi?id=337742
>
>
> Repository: kde-runtime
>
>
> Description
> -------
>
> Bugzilla 4.4.5 now request token to create report.
>
>
> Diffs
> -----
>
> drkonqi/bugzillalib.h 570169b
> drkonqi/bugzillalib.cpp f74753c
> drkonqi/tests/bugzillalibtest/bugzillalibtest.cpp 46c95b6
>
> Diff: https://git.reviewboard.kde.org/r/120376/diff/
>
>
> Testing
> -------
>
> Testing was done using crashtest program in drkonqui folder on \
> https://bugstest.kde.org Create new bug report and add attachement works now.
>
>
> Thanks,
>
> Frédéric Sheedy
>
>
--===============5350147830335204632==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120376/">https://git.reviewboard.kde.org/r/120376/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 26th, 2014, 11:54 a.m. UTC, <b>Ian \
Wadham</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hi Frédéric,</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As \
announced on KDE Core devel, in \
http://lists.kde.org/?l=kde-core-devel&m=141016488132293&w=2 about 3 weeks \
ago, I also am working on Dr Konqi.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I am about to publish a \
general patch, which is aimed at the present problem posed by the change to tokens in \
Bugzilla https://bugs.kde.org/show_bug.cgi?id=337742, but also intends to avoid such \
problems in future and to be forward-portable to KF5. My approach is to check the \
version number of the Bugzilla software and to switch to whichever security method is \
appropriate for that version: cookies, tokens or passwords-only.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Of course, my patch will implement tokens for the time being, but the idea \
is to switch automatically to passwords-only when the time comes, without any new \
release of KDE software being necessary. See \
http://www.bugzilla.org/docs/tip/en/html/api/Bugzilla/WebService.html#LOGGING_IN in \
the documentation for Bugzilla 4.5.5 (the next version), as opposed to 4.4.5 (the \
current version). Bugzilla 4.5.5 allows tokens, but I believe they will be \
discontinued at some stage, though I cannot put my finger on where I have seen that \
discussion.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This should avoid users having to experience further \
bugs in Dr Konqi's connection to bugs.kde.org. My patch is also intended to be \
extendable, so that Dr Konqi can be updated and re-released, ahead of time, if any \
further feature change is announced by Bugzilla and could adversely affect Dr \
Konqi.</p></pre> </blockquote>
<p>On September 26th, 2014, 3:28 p.m. UTC, <b>Frédéric Sheedy</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Great, good news! My patch was only a quick fix to what you are \
doing.</p></pre> </blockquote>
<p>On September 26th, 2014, 11:11 p.m. UTC, <b>Ian Wadham</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I did \
not mean that you should drop what you are doing and discard this review and patch \
completely... :-) Instead, we should work together and each be aware of what the \
other is doing.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Please revive your patch and this \
review.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">From what I can tell, the patch (after review and \
shipping) will be good immediately and at least until the version after Bugzilla \
4.5.x. Also, your patch has some improvements to the testing, which is important. And \
I think we need to get a fix into the closing versions of KDE 4 ASAP (next deadline \
Thursday, 9 October). My fixes will be more long-term and I am running short of days \
to work on them, due to other commitments, and anyway they may take a while to \
review... So please revive your review and patch, Frédéric.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One \
immediate comment: I found that I could retrieve the token by using the tag "token", \
but I could not use "token" in the "args" map. I had to use "Bugzilla_token". I have \
no idea why that is. I am using an Apple OS X platform, but that should not make a \
difference to a web dialog.</p></pre> </blockquote>
<p>On October 7th, 2014, 9:54 p.m. UTC, <b>Ian Wadham</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Frédéric, please have a look at review \
https://git.reviewboard.kde.org/r/120431/ particularly the comments of the last 24 \
hours.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Somebody is going to have to commit a patch for Dr \
Konqi before Albert Astals Cid starts tagging KDE 4.14.2 on Thursday night. It will \
be either your patch, my patch or a simplified version of my patch. If the consensus \
is to use your patch in KDE 4.14.2 for now, I would like to give it a test on \
Thursday (Australian time, UTC + 11 hours). I am otherwise engaged today \
(Wednesday).</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">All being well, I could commit your patch, but do you \
have commit rights yourself?</p></pre> </blockquote>
<p>On October 8th, 2014, 2:18 a.m. UTC, <b>Frédéric Sheedy</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi \
Ian,</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I do have an account to commit the patch. Let me know \
of the consensus!</p></pre> </blockquote>
<p>On October 11th, 2014, 1:13 a.m. UTC, <b>Ian Wadham</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As \
you may have seen on https://git.reviewboard.kde.org/r/120431/ the consensus was in \
favour of a simplified patch, which I edited, tested and later committed on \
Thursday.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It is regrettable that neither of our patches received \
a review from a KDE core developer who is familiar with the Dr Konqi code. Had that \
happened, things could have proceeded in a more orderly fashion and I am sure that \
your patch could have been shipped immediately, to fix bug 337742, and mine could \
have been refined and shipped within the KDE 4.14.3 or 14.12 timeframe.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Frédéric, I think it is important that your fixes for the Dr Konqi test \
processes should go into KDE 4.14.3 or 14.12 and also into KF5.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thank you very much for your help.</p></pre> </blockquote>
<p>On October 16th, 2014, 1:12 p.m. UTC, <b>Frédéric Sheedy</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi \
Ian, thanks for the answer!</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">As my fixes for Dr Konqui are not for \
the end users, should I commit it without a review?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
nobody objects, I would say yes, but I am no authority. However, it seems rather hard \
to get a review of changes to Dr Konqi and we are just talking about some small \
changes to file drkonqi/tests/bugzillalibtest/bugzillalibtest.cpp.</p></pre> <br />
<p>- Ian</p>
<br />
<p>On October 8th, 2014, 1:49 a.m. UTC, Frédéric Sheedy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Runtime and Ian Wadham.</div>
<div>By Frédéric Sheedy.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2014, 1:49 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=337742">337742</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Bugzilla 4.4.5 now request token to create \
report.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Testing was done using crashtest program in drkonqui \
folder on https://bugstest.kde.org Create new bug report and add attachement works \
now.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>drkonqi/bugzillalib.h <span style="color: grey">(570169b)</span></li>
<li>drkonqi/bugzillalib.cpp <span style="color: grey">(f74753c)</span></li>
<li>drkonqi/tests/bugzillalibtest/bugzillalibtest.cpp <span style="color: \
grey">(46c95b6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120376/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5350147830335204632==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic