From kde-core-devel Thu Sep 25 17:37:47 2014 From: Thiago Macieira Date: Thu, 25 Sep 2014 17:37:47 +0000 To: kde-core-devel Subject: Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value Message-Id: <3202919.rAU4uXWpfn () tjmaciei-mobl4> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=141166670217317 On Thursday 25 September 2014 13:32:41 Ren=E9 J.V. Bertin wrote: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120363/ > ----------------------------------------------------------- >=20 > Review request for KDE Software on Mac OS X and kdelibs. >=20 >=20 > Repository: kdelibs >=20 >=20 > Description > ------- >=20 > Applications can be defined in their CMake file as being `NOGUI`, but= until > now this has had very limited effect. Especially on OS X, those > applications can still construct a minimal GUI and thus have "visual > presence" in the Dock and application switcher (and have a menubar as= > well). >=20 > This patch proposes to define a preprocessor token, `KDE_WITHOUT_GUI`= , for > those targets, and uses that token to set the default value for the > `GUIenabled` option of the `KApplication` and `KUniqueApplication` cl= asses. >=20 > This could potentially be combined on OS X with the CoreFoundation ca= ll that > turns a running application into an "agent" (see > https://git.reviewboard.kde.org/r/120354). Note that this change can't apply to a Qt5-based build since QApplicati= on no=20 longer has that extra parameter. Are we sure we want to add a new feature that is Qt4-only and has a sho= rt=20 lifetime? --=20 Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center PGP/GPG: 0x6EF45358; fingerprint: E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358