'Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and appl'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent",  removing it from Dock and appl
From:       René J.V. Bertin <rjvbertin () gmail ! com>
Date:       2014-09-25 16:14:24
Message-ID: 20140925161424.6971.38564 () probe ! kde ! org
[Download RAW message or body]

--===============7470088802768552745==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120354/
-----------------------------------------------------------

(Updated Sept. 25, 2014, 6:14 p.m.)


Review request for KDE Software on Mac OS X, KDE Runtime, kdelibs, and Qt KDE.


Repository: kde-runtime


Description
-------

See https://bugs.kde.org/show_bug.cgi?id=339333 for more detailed discussion.

KDE helper applications that need to be able to present widgets or otherwise "talk \
with the GUI layer" require special attention on OS X, if one doesn't want them to \
appear in the Dock or task switcher nor present a bare-bones menubar when made \
active.

Applications that live in an app bundle can set LSUIElement="1" in their Info.plist \
to signal the window server that they're "agents" (and thus don't want the \
aforementioned visual presence). This feature is already in use (see \
Info.plis.template for apps like kded4 and kdeinit4, and the corresponding code in \
their respective CMake files).

kglobalaccel is a different case as it's built as a standard *n*x app \
(`/opt/local/bin/kglobalaccel` in a standard MacPorts install) and thus has no \
Info.plist. It is however possible to set the corresponding bit via CoreFoundation, \
and that's what this patch does.

Suggestion: a member function I'd tentatively call `appIsService` would be welcome, \
but one could also make this the default behaviour when starting a `GUIenabled=false` \
application on OS X. That's actually the main reason for submitting this RR: see if \
we can come to a consensus if and how to use this new knowledge.


Diffs (updated)
-----

  kglobalaccel/main.cpp 4d230b8 

Diff: https://git.reviewboard.kde.org/r/120354/diff/


Testing
-------

On OS X 10.6.8 with kdelibs 4.14.1 (git/kde4.14).


Thanks,

René J.V. Bertin


--===============7470088802768552745==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120354/">https://git.reviewboard.kde.org/r/120354/</a>
  </td>
    </tr>
   </table>
   <br />





<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Software on Mac OS X, KDE Runtime, kdelibs, and Qt \
KDE.</div> <div>By René J.V. Bertin.</div>


<p style="color: grey;"><i>Updated Sept. 25, 2014, 6:14 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See https://bugs.kde.org/show_bug.cgi?id=339333 for \
more detailed discussion.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">KDE helper applications that need to be \
able to present widgets or otherwise "talk with the GUI layer" require special \
attention on OS X, if one doesn't want them to appear in the Dock or task switcher \
nor present a bare-bones menubar when made active.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Applications that live in an app bundle can set LSUIElement="1" in their \
Info.plist to signal the window server that they're "agents" (and thus don't want the \
aforementioned visual presence). This feature is already in use (see \
Info.plis.template for apps like kded4 and kdeinit4, and the corresponding code in \
their respective CMake files).</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">kglobalaccel is a \
different case as it's built as a standard <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">n</em>x app (<code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">/opt/local/bin/kglobalaccel</code> in a standard MacPorts \
install) and thus has no Info.plist. It is however possible to set the corresponding \
bit via CoreFoundation, and that's what this patch does.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Suggestion: a member function I'd tentatively call <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">appIsService</code> would be welcome, but one could also \
make this the default behaviour when starting a <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">GUIenabled=false</code> application on OS X.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
That's actually the main reason for submitting this RR: see if we can come to a \
consensus if and how to use this new knowledge.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.6.8 with kdelibs 4.14.1 \
(git/kde4.14).</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kglobalaccel/main.cpp <span style="color: grey">(4d230b8)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120354/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============7470088802768552745==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic