[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2014-09-25 13:32:41
Message-ID: 20140925133241.6970.88294 () probe ! kde ! org
[Download RAW message or body]
--===============8434398982495777194==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120363/
-----------------------------------------------------------
Review request for KDE Software on Mac OS X and kdelibs.
Repository: kdelibs
Description
-------
Applications can be defined in their CMake file as being `NOGUI`, but until now this \
has had very limited effect. Especially on OS X, those applications can still \
construct a minimal GUI and thus have "visual presence" in the Dock and application \
switcher (and have a menubar as well).
This patch proposes to define a preprocessor token, `KDE_WITHOUT_GUI`, for those \
targets, and uses that token to set the default value for the `GUIenabled` option of \
the `KApplication` and `KUniqueApplication` classes.
This could potentially be combined on OS X with the CoreFoundation call that turns a \
running application into an "agent" (see https://git.reviewboard.kde.org/r/120354).
Diffs
-----
cmake/modules/KDE4Macros.cmake 073d726
kdeui/kernel/kapplication.h fa2ab26
kdeui/kernel/kapplication.cpp b093034
kdeui/kernel/kuniqueapplication.h e05dcd7
Diff: https://git.reviewboard.kde.org/r/120363/diff/
Testing
-------
On OS X 10.6.8 with kdelibs 4.14.1 (git/kde4.14), rebuilt kdelibs, kde-workspace, \
kde-runtime, kde-baseapps, kdepim-runtime and nepomuk-core. If the documentation I \
read is correct, the `GUIenabled` switch has no effect on Linux, so this patch \
shouldn't have any either on that OS.
Thanks,
René J.V. Bertin
--===============8434398982495777194==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120363/">https://git.reviewboard.kde.org/r/120363/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and kdelibs.</div>
<div>By René J.V. Bertin.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Applications can be defined in their CMake file as \
being <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">NOGUI</code>, but until now this has had very \
limited effect. Especially on OS X, those applications can still construct a minimal \
GUI and thus have "visual presence" in the Dock and application switcher (and have a \
menubar as well).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This patch proposes to define a \
preprocessor token, <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">KDE_WITHOUT_GUI</code>, for \
those targets, and uses that token to set the default value for the <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">GUIenabled</code> option of the <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">KApplication</code> and <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">KUniqueApplication</code> classes.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This could potentially \
be combined on OS X with the CoreFoundation call that turns a running application \
into an "agent" (see https://git.reviewboard.kde.org/r/120354).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.6.8 with kdelibs 4.14.1 (git/kde4.14), \
rebuilt kdelibs, kde-workspace, kde-runtime, kde-baseapps, kdepim-runtime and \
nepomuk-core.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> If the documentation I read is correct, the <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">GUIenabled</code> switch has no effect on Linux, so this \
patch shouldn't have any either on that OS.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/KDE4Macros.cmake <span style="color: grey">(073d726)</span></li>
<li>kdeui/kernel/kapplication.h <span style="color: grey">(fa2ab26)</span></li>
<li>kdeui/kernel/kapplication.cpp <span style="color: grey">(b093034)</span></li>
<li>kdeui/kernel/kuniqueapplication.h <span style="color: \
grey">(e05dcd7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120363/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8434398982495777194==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic