--===============8747383320687253899== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 223-239 > > > > > > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE blocks. If I see correctly, what remains being built on Apple is: > > * kcheckpass > > * qguiplatformplugin_kde > > > > Somehow I doubt kcheckpass will work on MacOS (it uses PAM) or is of any need (only used by kscreenlocker_greet in ksmserver which is not built). And qguiplatformplugin_kde should not be of any use on MacOS either because it's the Qt plugin for a Plasma session and shouldn't (TM) be used on other platforms. > > > > So if I see correctly you could just merge the whole thing into a > > if(NOT WIN32 AND NOT APPLE) > > René J.V. Bertin wrote: > Are you very sure about that? I see things related to KFileDialog and KColorDialog, and I don't see why those would only be relevant from inside a Plasma session... > > What would be the best place where I could put some kind of output expression that I ought NOT to see if indeed the platform plugin isn't used? > > I also remember someone (Thomas?) mention it in the context of doing an override of a Qt setting at a very low, early level during application initialisation. > > Thomas Lübking wrote: > You would want to alter qguiplatformplugin_osx (not sure about the _osx name part) since that is what will be loaded on OSX if you're eg. running kwrite in the default OSX shell. > You will (hopefully) get the OSX native filedialogs and color pickers from any Qt application for this, not the foreign KDE ones. exactly as Thomas writes: this is the platform plugin for the kde workspaces. On MacOS you don't have the kde workspaces and thus don't want to load it. You want to get the mac os plugin to have integration with mac os. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/#review67071 ----------------------------------------------------------- On Sept. 20, 2014, 2:52 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120287/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2014, 2:52 p.m.) > > > Review request for KDE Software on Mac OS X and kde-workspace. > > > Repository: kde-workspace > > > Description > ------- > > A few rather straightforward patches to make the relevant bits of KDE4's kde-workspace build and function on OS X. > The main interest is having the systemsettings control panel to control the various relevant KDE settings among which desktop search, fonts, colours and even style. > The oxygen style builds and looks good but shows some updating glitches due to compositing. > > I'm submitting this patch partly in hope it may be useful in bringing kf5-workspace to OS X, one day. > > > Diffs > ----- > > CMakeLists.txt 195f99c > kcontrol/CMakeLists.txt fc666b1 > kcontrol/krdb/krdb.cpp 36fc99c > kcontrol/style/CMakeLists.txt d832b20 > libs/CMakeLists.txt c0576fe > > Diff: https://git.reviewboard.kde.org/r/120287/diff/ > > > Testing > ------- > > On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs git/master, 4.14.1). > > > File Attachments > ---------------- > > copy of the diff file saved locally, which had no tabs when I uploaded it. Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch > > > Thanks, > > René J.V. Bertin > > --===============8747383320687253899== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/

On September 20th, 2014, 3:51 p.m. CEST, Martin Gräßlin wrote:

CMakeLists.txt (Diff revision 5)
223 
if(NOT WIN32)
 223 
if(NOT WIN32)
224 
   macro_optional_add_subdirectory( kcheckpass )
 224 
   macro_optional_add_subdirectory( kcheckpass )
 

    225
    
   if(NOT APPLE)

  


 


 
 

 

  

    225
    
   macro_optional_add_subdirectory( kwin )

    226
    
>>>   macro_optional_add_subdirectory( kwin )

  


  

    226
    
   macro_optional_add_subdirectory( ksmserver )

    227
    
>>>   macro_optional_add_subdirectory( ksmserver )

  


 


 
 

 

  

    227
    

    228
    

  


 


 
 

 

  

    228
    
   find_package(JPEG REQUIRED)

    229
    
>>>   find_package(JPEG REQUIRED)

  


  

    229
    
   find_package(PNG REQUIRED)

    230
    
>>>   find_package(PNG REQUIRED)

  


  

    230
    
   macro_optional_add_subdirectory( ksplash )

    231
    
>>>   macro_optional_add_subdirectory( ksplash )

  


 


 
 

 

  

    231
    

    232
    

  


 


 
 

 

  

    232
    
   macro_optional_add_subdirectory( powerdevil )

    233
    
>>>   macro_optional_add_subdirectory( powerdevil )

  


 


 
 

 

  

    
    

    234
    
   endif(NOT APPLE)

  


 


 
 

 

  

    233
    
   macro_optional_add_subdirectory( qguiplatformplugin_kde )

    235
    
   macro_optional_add_subdirectory( qguiplatformplugin_kde )

  


  

    234
    
   if (NOT CMAKE_SYSTEM_NAME MATCHES Darwin)

    236
    
   if (NOT CMAKE_SYSTEM_NAME MATCHES Darwin)

  


  

    235
    
      macro_optional_add_subdirectory( ksysguard )

    237
    
      macro_optional_add_subdirectory( ksysguard )

  


  

    236
    
   endif (NOT CMAKE_SYSTEM_NAME MATCHES Darwin)

    238
    
   endif (NOT CMAKE_SYSTEM_NAME MATCHES Darwin)

  


  

    237
    
endif(NOT WIN32)

    239
    
endif(NOT WIN32)

  


 




  
out of interest: this is now a huge NOT WIN32 block with two NOT APPLE blocks. If I see correctly, what remains being built on Apple is:

 kcheckpass

 qguiplatformplugin_kde


Somehow I doubt kcheckpass will work on MacOS (it uses PAM) or is of any need (only used by kscreenlocker_greet in ksmserver which is not built). And qguiplatformplugin_kde should not be of any use on MacOS either because it's the Qt plugin for a Plasma session and shouldn't (TM) be used on other platforms.


So if I see correctly you could just merge the whole thing into a

if(NOT WIN32 AND NOT APPLE)

 




 
On September 21st, 2014, 12:19 p.m. CEST, René J.V. Bertin wrote:

 

  
Are you very sure about that? I see things related to KFileDialog and KColorDialog, and I don't see why those would only be relevant from inside a Plasma session...


What would be the best place where I could put some kind of output expression that I ought NOT to see if indeed the platform plugin isn't used?


I also remember someone (Thomas?) mention it in the context of doing an override of a Qt setting at a very low, early level during application initialisation.

 






 
On September 21st, 2014, 1:28 p.m. CEST, Thomas Lübking wrote:

 

  
You would want to alter qguiplatformplugin_osx (not sure about the _osx name part) since that is what will be loaded on OSX if you're eg. running kwrite in the default OSX shell.

You will (hopefully) get the OSX native filedialogs and color pickers from any Qt application for this, not the foreign KDE ones.

 











exactly as Thomas writes: this is the platform plugin for the kde workspaces. On MacOS you don't have the kde workspaces and thus don't want to load it. You want to get the mac os plugin to have integration with mac os.








- Martin






On September 20th, 2014, 2:52 p.m. CEST, René J.V. Bertin wrote:












 

  


Review request for KDE Software on Mac OS X and kde-workspace.


By René J.V. Bertin.




Updated Sept. 20, 2014, 2:52 p.m.












 Repository: 
kde-workspace





Description 

 

 

  
   
A few rather straightforward patches to make the relevant bits of KDE4's kde-workspace build and function on OS X.

The main interest is having the systemsettings control panel to control the various relevant KDE settings among which desktop search, fonts, colours and even style.

The oxygen style builds and looks good but shows some updating glitches due to compositing.


I'm submitting this patch partly in hope it may be useful in bringing kf5-workspace to OS X, one day.

  		
 






Testing 



 

  
   
On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs git/master, 4.14.1).

  		
 






Diffs 


    

 
  • CMakeLists.txt (195f99c)
    • 

 
  • kcontrol/CMakeLists.txt (fc666b1)
    • 

 
  • kcontrol/krdb/krdb.cpp (36fc99c)
    • 

 
  • kcontrol/style/CMakeLists.txt (d832b20)
    • 

 
  • libs/CMakeLists.txt (c0576fe)
    • 





View Diff





File Attachments 



 
  • copy of the diff file saved locally, which had no tabs when I uploaded it. Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 
    • 






      		
 
    

    








  
    
 



--===============8747383320687253899==--