--===============6372530170860355889== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/#review67125 ----------------------------------------------------------- Martin, Since this file is openn, you can considerate this entry as obsolete : https://git.reviewboard.kde.org/r/112991/ - Gilles Caulier On Sept. 20, 2014, 12:52 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120287/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2014, 12:52 p.m.) > > > Review request for KDE Software on Mac OS X and kde-workspace. > > > Repository: kde-workspace > > > Description > ------- > > A few rather straightforward patches to make the relevant bits of KDE4's kde-workspace build and function on OS X. > The main interest is having the systemsettings control panel to control the various relevant KDE settings among which desktop search, fonts, colours and even style. > The oxygen style builds and looks good but shows some updating glitches due to compositing. > > I'm submitting this patch partly in hope it may be useful in bringing kf5-workspace to OS X, one day. > > > Diffs > ----- > > CMakeLists.txt 195f99c > kcontrol/CMakeLists.txt fc666b1 > kcontrol/krdb/krdb.cpp 36fc99c > kcontrol/style/CMakeLists.txt d832b20 > libs/CMakeLists.txt c0576fe > > Diff: https://git.reviewboard.kde.org/r/120287/diff/ > > > Testing > ------- > > On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs git/master, 4.14.1). > > > File Attachments > ---------------- > > copy of the diff file saved locally, which had no tabs when I uploaded it. Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch > > > Thanks, > > René J.V. Bertin > > --===============6372530170860355889== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/ 

Martin,


Since this file is openn, you can considerate this entry as obsolete :


https://git.reviewboard.kde.org/r/112991/

- Gilles Caulier


On September 20th, 2014, 12:52 p.m. UTC, René J.V. Bertin wrote:

Review request for KDE Software on Mac OS X and kde-workspace.
By René J.V. Bertin.

Updated Sept. 20, 2014, 12:52 p.m.

Repository: kde-workspace

Description 

A few rather straightforward patches to make the relevant bits of KDE4's kde-workspace build and function on OS X.

The main interest is having the systemsettings control panel to control the various relevant KDE settings among which desktop search, fonts, colours and even style.

The oxygen style builds and looks good but shows some updating glitches due to compositing.


I'm submitting this patch partly in hope it may be useful in bringing kf5-workspace to OS X, one day.

Testing 

On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs git/master, 4.14.1).

Diffs

  • CMakeLists.txt (195f99c)
  • kcontrol/CMakeLists.txt (fc666b1)
  • kcontrol/krdb/krdb.cpp (36fc99c)
  • kcontrol/style/CMakeLists.txt (d832b20)
  • libs/CMakeLists.txt (c0576fe)

View Diff

File Attachments

  • copy of the diff file saved locally, which had no tabs when I uploaded it. Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1
    • --===============6372530170860355889==--