[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 120287: [OS X] make kde-workspace build
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-09-20 12:24:01
Message-ID: 20140920122401.22584.34913 () probe ! kde ! org
[Download RAW message or body]
--===============1644090837863179116==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote:
> > CMakeLists.txt, lines 225-234
> > <https://git.reviewboard.kde.org/r/120287/diff/3/?file=313626#file313626line225>
> >
> > tabs instead of whitespaces
>
> René J.V. Bertin wrote:
> I looked into those yesterday, and cannot find tabs on my end. No idea where they'd \
> come from.
> Martin Gräßlin wrote:
> I'd guess the editor you use changes it somehow. I'd suggest to use Kate and enable \
> show all whitespaces.
> René J.V. Bertin wrote:
> No, really, those tabs aren't there. I re-reopened the CMakeLists.txt in vi (which \
> doesn't modify anything unless I ask for it) and there are no tabs to be found. \
> Same in KDevelop when I open the patch review tool. I wonder if your editor isn't \
> the culprit, or something on reviewboard?
> I copied the .reviewboardrc file from another KDE project and edited the obvious \
> settings. I see nothing concerning tabs in there, but maybe there ought to be?
> René J.V. Bertin wrote:
> See my local copy of the diff I just added.
>
> Thomas Lübking wrote:
> There're no tabs in the diff (checked teh only reliable way: okteta ;-)
>
> Indention in those files is crazy (2 or 3 chars, never 4), what makes it look like \
> WS/tab intermix, but ">>>" seems only a RB indication that the line was altered \
> only by shifting.
> René J.V. Bertin wrote:
> Just a question: would I still have triggered `-pedantic` mode if I had included \
> something like "and relevant code tidy-ups" in my RR title? :P
> Also, is one supposed to go through an RR for each and every tidy-up one might want \
> to commit (now that I have commit access ...)?
> Thomas Lübking wrote:
> You can stuff as many patches (commits) into one review as you like, just that one \
> patch may delay the "ship it" to all others than and at some point ppl. will refuse \
> to look at 3MB of patches at once ;-)
> I don't think that pure tidy up commits belong into KDE4 at all, if you really \
> consider one necessary, better have it reviewed.
> For KF5/master you ideally clean up code while editing the area anyway.
> Global astyle fixes should only be done when things become too much of a mess - and \
> be shown to the maintainer. (Reason is that you introduce "fences" to "git blame")
>
> Marko Käning wrote:
> Reason being that "fences" to "git blame" get introduced is a very good point, \
> indeed! (Never thought of that, actually.) That's somewhat a problem of the SCM's \
> way of handling the code lines then! Would be cool if white-space commits could be \
> marked as such, so that git could omit/bridge them in case of blame...
> Christoph Feck wrote:
> The >>> markers reviewboard shows are not Tabs, but change in indentation.
> would I still have triggered -pedantic mode if I had included something like "and \
> relevant code tidy-ups" in my RR title?
you triggered the -pedantic mode for me (which is always kind of on), because I \
consider the change as dangerous, thus I think it must be absolutely side-effect free \
and in a way that reviewers can focus on the actual changes.
Sorry about the whitespace complains, that must be a recent change in reviewboard - \
at least I have never seen it before.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/#review67023
-----------------------------------------------------------
On Sept. 20, 2014, 12:54 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120287/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2014, 12:54 p.m.)
>
>
> Review request for KDE Software on Mac OS X and kde-workspace.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> A few rather straightforward patches to make the relevant bits of KDE4's \
> kde-workspace build and function on OS X. The main interest is having the \
> systemsettings control panel to control the various relevant KDE settings among \
> which desktop search, fonts, colours and even style. The oxygen style builds and \
> looks good but shows some updating glitches due to compositing.
> I'm submitting this patch partly in hope it may be useful in bringing kf5-workspace \
> to OS X, one day.
>
> Diffs
> -----
>
> CMakeLists.txt 195f99c
> kcontrol/CMakeLists.txt fc666b1
> kcontrol/krdb/krdb.cpp 36fc99c
> kcontrol/style/CMakeLists.txt d832b20
> libs/CMakeLists.txt c0576fe
>
> Diff: https://git.reviewboard.kde.org/r/120287/diff/
>
>
> Testing
> -------
>
> On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs \
> git/master, 4.14.1).
>
> File Attachments
> ----------------
>
> copy of the diff file saved locally, which had no tabs when I uploaded it. \
> Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 \
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
>
>
> Thanks,
>
> René J.V. Bertin
>
>
--===============1644090837863179116==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120287/">https://git.reviewboard.kde.org/r/120287/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 20th, 2014, 10:20 a.m. CEST, \
<b>Martin Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120287/diff/3/?file=313626#file313626line225" \
style="color: black; font-weight: bold; text-decoration: \
underline;">CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">225</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">if</span><span class="p">(</span><span class="s">NOT</span> <span \
class="s">APPLE</span><span class="p">)</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">225</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">kwin</span> <span class="p">)</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">226</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="indent">>>></span> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">kwin</span> <span class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">226</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">ksmserver</span> <span class="p">)</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">227</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="indent">>>></span> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">ksmserver</span> <span class="p">)</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">227</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">228</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">228</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">find_package</span><span class="p">(</span><span class="s">JPEG</span> \
<span class="s">REQUIRED</span><span class="p">)</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">229</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="indent">>>></span> <span class="nb">find_package</span><span \
class="p">(</span><span class="s">JPEG</span> <span class="s">REQUIRED</span><span \
class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">229</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">find_package</span><span class="p">(</span><span class="s">PNG</span> \
<span class="s">REQUIRED</span><span class="p">)</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">230</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="indent">>>></span> <span class="nb">find_package</span><span \
class="p">(</span><span class="s">PNG</span> <span class="s">REQUIRED</span><span \
class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">230</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">ksplash</span> <span class="p">)</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">231</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="indent">>>></span> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">ksplash</span> <span class="p">)</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">231</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">232</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">232</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">powerdevil</span> <span class="p">)</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">233</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="indent">>>></span> <span \
class="nb">macro_optional_add_subdirectory</span><span class="p">(</span> <span \
class="s">powerdevil</span> <span class="p">)</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">234</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">endif</span><span class="p">(</span><span class="s">NOT</span> <span \
class="s">APPLE</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">tabs \
instead of whitespaces</p></pre> </blockquote>
<p>On September 20th, 2014, 10:54 a.m. CEST, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
looked into those yesterday, and cannot find tabs on my end. No idea where they'd \
come from.</p></pre> </blockquote>
<p>On September 20th, 2014, 11:02 a.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd \
guess the editor you use changes it somehow. I'd suggest to use Kate and enable show \
all whitespaces.</p></pre> </blockquote>
<p>On September 20th, 2014, 12:48 p.m. CEST, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No, \
really, those tabs aren't there. I re-reopened the CMakeLists.txt in vi (which \
doesn't modify anything unless I ask for it) and there are no tabs to be found. Same \
in KDevelop when I open the patch review tool. I wonder if your editor isn't the \
culprit, or something on reviewboard?</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I copied the \
.reviewboardrc file from another KDE project and edited the obvious settings. I see \
nothing concerning tabs in there, but maybe there ought to be?</p></pre> \
</blockquote>
<p>On September 20th, 2014, 12:54 p.m. CEST, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See \
my local copy of the diff I just added.</p></pre> </blockquote>
<p>On September 20th, 2014, 1:01 p.m. CEST, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">There're no tabs in the diff (checked teh only reliable way: okteta ;-)</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Indention in those files is crazy (2 or 3 chars, never \
4), what makes it look like WS/tab intermix, but ">>>" seems only a RB \
indication that the line was altered only by shifting.</p></pre> </blockquote>
<p>On September 20th, 2014, 1:35 p.m. CEST, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just \
a question: would I still have triggered <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">-pedantic</code> mode if I had included something like "and relevant code \
tidy-ups" in my RR title? :P</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Also, is one supposed to go through an \
RR for each and every tidy-up one might want to commit (now that I have commit access \
...)?</p></pre> </blockquote>
<p>On September 20th, 2014, 1:43 p.m. CEST, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
can stuff as many patches (commits) into one review as you like, just that one patch \
may delay the "ship it" to all others than and at some point ppl. will refuse to look \
at 3MB of patches at once ;-)</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't think that pure \
tidy up commits belong into KDE4 at all, if you really consider one necessary, better \
have it reviewed.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">For KF5/master you ideally clean up \
code while editing the area anyway.<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> Global astyle fixes \
should only be done when things become too much of a mess - and be shown to the \
maintainer.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> (Reason is that you introduce "fences" to "git \
blame")</p></pre> </blockquote>
<p>On September 20th, 2014, 1:51 p.m. CEST, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Reason being that "fences" to "git blame" get introduced is a very good \
point, indeed! (Never thought of that, actually.)<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
That's somewhat a problem of the SCM's way of handling the code lines then!<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> Would be cool if white-space commits could be marked as such, so that git \
could omit/bridge them in case of blame...</p></pre> </blockquote>
<p>On September 20th, 2014, 2:19 p.m. CEST, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
>>> markers reviewboard shows are not Tabs, but change in \
indentation.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">would I still have triggered -pedantic mode if I had included something \
like "and relevant code tidy-ups" in my RR title?</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">you triggered the -pedantic mode for me (which is \
always kind of on), because I consider the change as dangerous, thus I think it must \
be absolutely side-effect free and in a way that reviewers can focus on the actual \
changes.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Sorry about the whitespace complains, that must be a \
recent change in reviewboard - at least I have never seen it before.</p></pre> <br />
<p>- Martin</p>
<br />
<p>On September 20th, 2014, 12:54 p.m. CEST, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and kde-workspace.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Sept. 20, 2014, 12:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">A few rather straightforward patches to make the \
relevant bits of KDE4's kde-workspace build and function on OS X.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> The \
main interest is having the systemsettings control panel to control the various \
relevant KDE settings among which desktop search, fonts, colours and even style.<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> The oxygen style builds and looks good but shows some updating glitches \
due to compositing.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I'm submitting this patch partly in \
hope it may be useful in bringing kf5-workspace to OS X, one day.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 \
and more recently kdelibs git/master, 4.14.1).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(195f99c)</span></li>
<li>kcontrol/CMakeLists.txt <span style="color: grey">(fc666b1)</span></li>
<li>kcontrol/krdb/krdb.cpp <span style="color: grey">(36fc99c)</span></li>
<li>kcontrol/style/CMakeLists.txt <span style="color: grey">(d832b20)</span></li>
<li>libs/CMakeLists.txt <span style="color: grey">(c0576fe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120287/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch">copy \
of the diff file saved locally, which had no tabs when I uploaded it. Checksum: \
3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 </a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1644090837863179116==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic