[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 120182: KIO::CopyJob: Do not query for free space when filesystem type is unknown
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2014-09-20 3:28:55
Message-ID: 20140920032855.22584.40528 () probe ! kde ! org
[Download RAW message or body]
--===============6591688202018754348==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 19, 2014, 7:03 p.m., Andrea Iacovitti wrote:
> > I don't know this code but David's proposed patch differs from the one committed
> >
> > if (m_asMethod || !fileInfo.exists()) {
> > vs
> > if (m_asMethod && !fileInfo.exists()) {
> >
> > ....
It is a typo on my part. I will fix it.
- Dawit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120182/#review66976
-----------------------------------------------------------
On Sept. 19, 2014, 11:25 a.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120182/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2014, 11:25 a.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Bugs: 336529
> http://bugs.kde.org/show_bug.cgi?id=336529
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> This patch stops KIO::CopyJob from querying for free disk space when the filesystem \
> type is unknown.
>
> Diffs
> -----
>
> kio/kio/copyjob.cpp 713255b
>
> Diff: https://git.reviewboard.kde.org/r/120182/diff/
>
>
> Testing
> -------
>
> Mounted Andriod filesystem through sshfs and attempted to copy files through sftp.
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
--===============6591688202018754348==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120182/">https://git.reviewboard.kde.org/r/120182/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 19th, 2014, 7:03 p.m. UTC, <b>Andrea \
Iacovitti</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I don't know this code but David's proposed patch \
differs from the one committed</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">if (m_asMethod || \
!fileInfo.exists()) {<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> vs<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> if \
(m_asMethod && !fileInfo.exists()) {</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">....</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is \
a typo on my part. I will fix it.</p></pre> <br />
<p>- Dawit</p>
<br />
<p>On September 19th, 2014, 11:25 a.m. UTC, Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2014, 11:25 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=336529">336529</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch stops KIO::CopyJob from querying for free \
disk space when the filesystem type is unknown.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Mounted Andriod filesystem through sshfs and attempted \
to copy files through sftp.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/copyjob.cpp <span style="color: grey">(713255b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120182/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6591688202018754348==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic