[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)
From: "Ben Cooksley" <bcooksley () kde ! org>
Date: 2014-09-19 10:16:38
Message-ID: 20140919101638.22584.11385 () probe ! kde ! org
[Download RAW message or body]
--===============3668883939195723835==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119498/#review66935
-----------------------------------------------------------
Unless anyone has any objections in the next 24 hours, I think this can go in as it \
makes Dr Konqi usable on another platform.
- Ben Cooksley
On Sept. 18, 2014, 10:57 a.m., Ian Wadham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119498/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2014, 10:57 a.m.)
>
>
> Review request for KDE Software on Mac OS X, KDE Runtime, kdelibs, and Michael \
> Pyne.
>
> Repository: kde-runtime
>
>
> Description
> -------
>
> When a KDE app crashes in Apple OS X, it just disappears from the screen. At the \
> most, the user is invited to report the crash to Apple. AFAIK this has been a \
> problem in KDE on Apple OS X for years, leading to frustration with KDE among Apple \
> users and MacPorts developers and an attitude among KDE developers of "Why does \
> nobody report the problem(s) on bugs.kde.org?"
> It is my strong belief that the failure to report crashes of KDE apps in Apple OS X \
> also exists in Frameworks.
> So far I have identified a number of portability bugs in KDE on Apple OS X: 1 in \
> KCrash, 1 in kdeinit4 and 5 in Dr Konqi. Three patches for Dr Konqi are submitted \
> in this review. Patches for KCrash and kdeinit4 are submitted in part 1 of this \
> review, against kdelibs. I am still investigating the other two problems in Dr \
> Konqi - and there could be more than two...
> In this review we have three portability problems:
>
> 1. On Apple OS X, Dr Konqi's dialog box hides itself underneath the main window of \
> the app that has just crashed, so is effectively useless. This appears to be \
> because Dr Konqi is started by a Linux/Unix method (fork() + exec()?). If an app is \
> started with the Apple OS X "open" command, it always appears on top. The patch \
> just raises the dialog box.
> 2. When formatting the backtrace output, Dr Konqi crashes (with an ASSERT) on the \
> last line. This appears to be an error in the algorithm used (i.e. also a bug in \
> Linux KDE), but the patch is treating it as an Apple OS X portability problem for \
> now.
> 3. Dr Konqi checks whether the user can save cookies in kcookiejar and, if not, \
> stops reporting the crash. On Apple OS X, cookies would be kept in another browser \
> (e.g. Safari or Firefox) and not in KDE's default browser (Konqueror) and cookie \
> jar. IMHO, Dr K should report the crash no matter what, as long as it can connect \
> to bugs.kde.org and log in.
>
> Diffs
> -----
>
> drkonqi/gdbhighlighter.cpp 7cd0aa9
> drkonqi/main.cpp 75e060e
> drkonqi/reportassistantpages_bugzilla.cpp 86ca327
>
> Diff: https://git.reviewboard.kde.org/r/119498/diff/
>
>
> Testing
> -------
>
> Using Apple OS X 10.7.5 (Lion) on a MacBook Pro, I have installed KDE libs via \
> MacPorts (at version 4.12.5) and I have adapted kdesrc-build to run in an Apple OS \
> X environment and used it to test against the KDE 4.13 branch. I have been testing \
> with a KDE app that I can crash at will and using stderr and Apple OS X Console log \
> output to determine the outcome.
> Please note that I am the -only- KDE developer who has this kind of setup, but I am \
> NOT a KDE core developer. My experience before now has been in KDE Games. However I \
> used to be a UNIX and database guru before I retired in 1998.
> I NEED HELP from KDE -core- developers to proceed further. These problems will also \
> exist in Dr Konqi for KF 5, but I am as yet unable to build or test Frameworks on \
> Apple OS X and I cannot find Dr Konqi among the Frameworks repositories. I am sure \
> there are many more Apple OS X portability problems in Dr Konqi and other KDE \
> software.
> Without my patches, Dr Konqi, on Apple OS X, remains invisible to the user, often \
> fails to complete the backtrace report and then fails to connect to bugs.kde.org.
> With my patches, Dr Konqi on Apple OS X can generate a full crash report, including \
> the backtrace and the results of the dialog with the user. Sometimes, however, it \
> fails to submit the completed report to bugs.kde.org. This problem is still under \
> investigation.
> I would not have got this far without help from Michael Pyne, Thomas Lübking and \
> several of the MacPorts developers, as well as the unfailing enthusiasm and \
> encouragement of my friend Marko Käning.
>
> File Attachments
> ----------------
>
> Log of Dr K ASSERT problem
> https://git.reviewboard.kde.org/media/uploaded/files/2014/07/30/a3f99f00-94df-4b10-bc47-66b1c966f893__DrKonqiASSERT.kcrash.txt
>
>
> Thanks,
>
> Ian Wadham
>
>
--===============3668883939195723835==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119498/">https://git.reviewboard.kde.org/r/119498/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Unless anyone has any objections in the next 24 hours, I think this can go \
in as it makes Dr Konqi usable on another platform.</p></pre> <br />
<p>- Ben Cooksley</p>
<br />
<p>On September 18th, 2014, 10:57 a.m. UTC, Ian Wadham wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X, KDE Runtime, kdelibs, and Michael \
Pyne.</div> <div>By Ian Wadham.</div>
<p style="color: grey;"><i>Updated Sept. 18, 2014, 10:57 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When a KDE app crashes in Apple OS X, it just \
disappears from the screen. At the most, the user is invited to report the crash to \
Apple. AFAIK this has been a problem in KDE on Apple OS X for years, leading to \
frustration with KDE among Apple users and MacPorts developers and an attitude among \
KDE developers of "Why does nobody report the problem(s) on bugs.kde.org?"</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">It is my strong belief that the failure to report crashes of KDE apps in \
Apple OS X also exists in Frameworks.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">So far I have \
identified a number of portability bugs in KDE on Apple OS X: 1 in KCrash, 1 in \
kdeinit4 and 5 in Dr Konqi. Three patches for Dr Konqi are submitted in this review. \
Patches for KCrash and kdeinit4 are submitted in part 1 of this review, against \
kdelibs. I am still investigating the other two problems in Dr Konqi - and there \
could be more than two...</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">In this review we have three \
portability problems:</p> <ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;"> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On \
Apple OS X, Dr Konqi's dialog box hides itself underneath the main window of the app \
that has just crashed, so is effectively useless. This appears to be because Dr Konqi \
is started by a Linux/Unix method (fork() + exec()?). If an app is started with the \
Apple OS X "open" command, it always appears on top. The patch just raises the dialog \
box.</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">When formatting the backtrace output, \
Dr Konqi crashes (with an ASSERT) on the last line. This appears to be an error in \
the algorithm used (i.e. also a bug in Linux KDE), but the patch is treating it as an \
Apple OS X portability problem for now.</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Dr Konqi checks whether the user can \
save cookies in kcookiejar and, if not, stops reporting the crash. On Apple OS X, \
cookies would be kept in another browser (e.g. Safari or Firefox) and not in KDE's \
default browser (Konqueror) and cookie jar. IMHO, Dr K should report the crash no \
matter what, as long as it can connect to bugs.kde.org and log in.</p> </li>
</ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Using Apple OS X 10.7.5 (Lion) on a MacBook Pro, I \
have installed KDE libs via MacPorts (at version 4.12.5) and I have adapted \
kdesrc-build to run in an Apple OS X environment and used it to test against the KDE \
4.13 branch. I have been testing with a KDE app that I can crash at will and using \
stderr and Apple OS X Console log output to determine the outcome.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please note that I am the -only- KDE developer who has this kind of setup, \
but I am NOT a KDE core developer. My experience before now has been in KDE Games. \
However I used to be a UNIX and database guru before I retired in 1998.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I NEED HELP from KDE -core- developers to proceed further. These problems \
will also exist in Dr Konqi for KF 5, but I am as yet unable to build or test \
Frameworks on Apple OS X and I cannot find Dr Konqi among the Frameworks \
repositories. I am sure there are many more Apple OS X portability problems in Dr \
Konqi and other KDE software.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Without my patches, Dr \
Konqi, on Apple OS X, remains invisible to the user, often fails to complete the \
backtrace report and then fails to connect to bugs.kde.org.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With \
my patches, Dr Konqi on Apple OS X can generate a full crash report, including the \
backtrace and the results of the dialog with the user. Sometimes, however, it fails \
to submit the completed report to bugs.kde.org. This problem is still under \
investigation.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I would not have got this far without \
help from Michael Pyne, Thomas Lübking and several of the MacPorts developers, as \
well as the unfailing enthusiasm and encouragement of my friend Marko \
Käning.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>drkonqi/gdbhighlighter.cpp <span style="color: grey">(7cd0aa9)</span></li>
<li>drkonqi/main.cpp <span style="color: grey">(75e060e)</span></li>
<li>drkonqi/reportassistantpages_bugzilla.cpp <span style="color: \
grey">(86ca327)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119498/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/07/30/a3f99f00-94df-4b10-bc47-66b1c966f893__DrKonqiASSERT.kcrash.txt">Log \
of Dr K ASSERT problem</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3668883939195723835==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic