'Re: Review Request 120077: Make sure that the time and date are editable when ntpdate is missing'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 120077: Make sure that the time and date are editable when ntpdate is missing
From:       "Mathias Tillman" <master.homer () gmail ! com>
Date:       2014-09-08 14:50:48
Message-ID: 20140908145048.8756.43964 () probe ! kde ! org
[Download RAW message or body]

--===============4483844305746063259==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120077/
-----------------------------------------------------------

(Updated Sept. 8, 2014, 2:50 p.m.)


Status
------

This change has been marked as submitted.


Review request for kde-workspace.


Bugs: 337707
    https://bugs.kde.org/show_bug.cgi?id=337707


Repository: plasma-desktop


Description
-------

This fixes a bug where if you enable automatic time synchronisation and for whatever \
reason remove ntpdate the time and date are not editable, and you can't disable the \
automatic synchronisation due to the missing binary. The only way around it currently \
is to install ntpdate again, go to date and time settings, disable automatic \
synchronisation and then finally remove ntpdate again.

It also makes the Servers list uneditable when ntpdate is missing, as well as it \
having the same tooltip as the checkbox.


Diffs
-----

  kcms/dateandtime/dtime.cpp f8e641b5e0863a3a122c75def2282e0eac5f8b1e 

Diff: https://git.reviewboard.kde.org/r/120077/diff/


Testing
-------

I have tried both with and without the ntpdate binary, and everything seems to work \
fine.


Thanks,

Mathias Tillman


--===============4483844305746063259==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120077/">https://git.reviewboard.kde.org/r/120077/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kde-workspace.</div>
<div>By Mathias Tillman.</div>


<p style="color: grey;"><i>Updated Sept. 8, 2014, 2:50 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://bugs.kde.org/show_bug.cgi?id=337707">337707</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This fixes a bug where if you enable automatic time \
synchronisation and for whatever reason remove ntpdate the time and date are not \
editable, and you can't disable the automatic synchronisation due to the missing \
binary. The only way around it currently is to install ntpdate again, go to date and \
time settings, disable automatic synchronisation and then finally remove ntpdate \
again.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It also makes the Servers list uneditable when ntpdate \
is missing, as well as it having the same tooltip as the checkbox.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I have tried both with and without the ntpdate binary, \
and everything seems to work fine.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/dateandtime/dtime.cpp <span style="color: \
grey">(f8e641b5e0863a3a122c75def2282e0eac5f8b1e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120077/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============4483844305746063259==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic