'Re: Review Request 120064: Reset info panel and window caption when an archive fails to open'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-utils-devel
Subject:    Re: Review Request 120064: Reset info panel and window caption when an archive fails to open
From:       "Mathias Tillman" <master.homer () gmail ! com>
Date:       2014-09-06 16:15:14
Message-ID: 20140906161514.11808.93775 () probe ! kde ! org
[Download RAW message or body]

--===============9050240198588181592==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Sept. 6, 2014, 4:13 p.m., Raphael Kubo da Costa wrote:
> > http://commits.kde.org/ark/03b6de3cfc7519d88c0c026a4a9737f5604d6a99
> > I referenced the wrong review request there :-(

So you did :( Does it matter though, or is it just for appearances sake?

- Mathias

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120064/#review65923
-----------------------------------------------------------

On Sept. 6, 2014, 4:15 p.m., Mathias Tillman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120064/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2014, 4:15 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 245705
> http://bugs.kde.org/show_bug.cgi?id=245705
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> When opening an archive that for whatever reason fails to load (because it's \
> corrupt, or an invalid format) the archive appears to be open when it is not in \
> fact open. This patch fixes that by resetting the open archive, info panel name and \
> window caption. 
> 
> Diffs
> -----
> 
> part/part.cpp b4ebcd27c462d2b8037b5ea40c56969eda71bdcb 
> 
> Diff: https://git.reviewboard.kde.org/r/120064/diff/
> 
> 
> Testing
> -------
> 
> I have tried opening both archives that fail to load and ones that work.
> 
> 
> Thanks,
> 
> Mathias Tillman
> 
> 

--===============9050240198588181592==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120064/">https://git.reviewboard.kde.org/r/120064/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On September 6th, 2014, 4:13 p.m. UTC, <b>Raphael \
Kubo da Costa</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: \
inherit;">http://commits.kde.org/ark/03b6de3cfc7519d88c0c026a4a9737f5604d6a99<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> I referenced the wrong review request there :-(</p></pre>
 </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So \
you did :( Does it matter though, or is it just for appearances sake?</p></pre> <br \
/>

<p>- Mathias</p>

<br />
<p>On September 6th, 2014, 4:15 p.m. UTC, Mathias Tillman wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Mathias Tillman.</div>

<p style="color: grey;"><i>Updated Sept. 6, 2014, 4:15 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=245705">245705</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When opening an archive that for whatever reason fails \
to load (because it's corrupt, or an invalid format) the archive appears to be open \
when it is not in fact open. This patch fixes that by resetting the open archive, \
info panel name and window caption.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I have tried opening both archives that fail to load \
and ones that work.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/part.cpp <span style="color: \
grey">(b4ebcd27c462d2b8037b5ea40c56969eda71bdcb)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120064/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============9050240198588181592==--

_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel

[prev in list] [next in list] [prev in thread] [next in thread] 