[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request 120064: Reset info panel and window caption when an archive fails to open
From:       "Mathias Tillman" <master.homer () gmail ! com>
Date:       2014-09-05 11:19:49
Message-ID: 20140905111949.11808.15706 () probe ! kde ! org
[Download RAW message or body]

--===============0884916081510982564==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120064/
-----------------------------------------------------------

Review request for KDE Base Apps.


Bugs: 245705
    http://bugs.kde.org/show_bug.cgi?id=245705


Repository: ark


Description
-------

When opening an archive that for whatever reason fails to load (because it's corrupt, \
or an invalid format) the archive appears to be open when it is not in fact open. \
This patch fixes that by resetting the open archive, info panel name and window \
caption.


Diffs
-----

  part/part.cpp b4ebcd27c462d2b8037b5ea40c56969eda71bdcb 

Diff: https://git.reviewboard.kde.org/r/120064/diff/


Testing
-------

I have tried opening both archives that fail to load and ones that work.


Thanks,

Mathias Tillman


--===============0884916081510982564==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120064/">https://git.reviewboard.kde.org/r/120064/</a>
  </td>
    </tr>
   </table>
   <br />





<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Base Apps.</div>
<div>By Mathias Tillman.</div>








<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=245705">245705</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When opening an archive that for whatever reason fails \
to load (because it's corrupt, or an invalid format) the archive appears to be open \
when it is not in fact open. This patch fixes that by resetting the open archive, \
info panel name and window caption.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I have tried opening both archives that fail to load \
and ones that work.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/part.cpp <span style="color: \
grey">(b4ebcd27c462d2b8037b5ea40c56969eda71bdcb)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120064/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============0884916081510982564==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic