[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 116570: Ask user for confirmation before doing POST -> POST redirection in KIO
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2014-08-30 14:09:51
Message-ID: 20140830140951.14965.87032 () probe ! kde ! org
[Download RAW message or body]
--===============4224060843644054613==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116570/
-----------------------------------------------------------
(Updated Aug. 30, 2014, 2:09 p.m.)
Status
------
This change has been discarded.
Review request for kdelibs, Andrea Iacovitti and David Faure.
Repository: kdelibs
Description
-------
This patch is a companion to the recent POST->POST redirection implementation in KIO, \
https://git.reviewboard.kde.org/r/116017/. It prompts the user to approve the \
redirection as explicitly required in sections 10.3.[2|3] of RFC 2616:
If the 301 status code is received in response to a request other
than GET or HEAD, the user agent MUST NOT automatically redirect the
request unless it can be confirmed by the user, since this might
change the conditions under which the request was issued.
Please note that this patch only prompts the user for confirmation on POST->POST \
redirections. It can be expanded to include redirections for other requests such as \
PUT.
There is also an issue of whether this patch should be part of the 4.13 release? \
Since we are in a freeze and the patch has both message changes as well as a new API, \
I have simply marked it for inclusion in master branch, i.e. 4.14.
Diffs
-----
kio/kio/job.cpp 50b4afb
kio/kio/jobuidelegate.h 17fd554
kio/kio/jobuidelegate.cpp 5aff330
Diff: https://git.reviewboard.kde.org/r/116570/diff/
Testing
-------
http://greenbytes.de/tech/tc/httpredirects/t307methods.html
File Attachments
----------------
POST redirection confirm dialog
https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/e77dd03e-cb37-49bb-8554-cca991c8c546__post_redirection_confirmation.png
Thanks,
Dawit Alemayehu
--===============4224060843644054613==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116570/">https://git.reviewboard.kde.org/r/116570/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs, Andrea Iacovitti and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Aug. 30, 2014, 2:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is a companion to the recent POST->POST redirection \
implementation in KIO, https://git.reviewboard.kde.org/r/116017/. It prompts the user \
to approve the redirection as explicitly required in sections 10.3.[2|3] of RFC 2616:
If the 301 status code is received in response to a request other
than GET or HEAD, the user agent MUST NOT automatically redirect the
request unless it can be confirmed by the user, since this might
change the conditions under which the request was issued.
Please note that this patch only prompts the user for confirmation on POST->POST \
redirections. It can be expanded to include redirections for other requests such as \
PUT.
There is also an issue of whether this patch should be part of the 4.13 release? \
Since we are in a freeze and the patch has both message changes as well as a new API, \
I have simply marked it for inclusion in master branch, i.e. 4.14.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">http://greenbytes.de/tech/tc/httpredirects/t307methods.html</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/job.cpp <span style="color: grey">(50b4afb)</span></li>
<li>kio/kio/jobuidelegate.h <span style="color: grey">(17fd554)</span></li>
<li>kio/kio/jobuidelegate.cpp <span style="color: grey">(5aff330)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116570/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/e77dd03e-cb37-49bb-8554-cca991c8c546__post_redirection_confirmation.png">POST \
redirection confirm dialog</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4224060843644054613==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic