[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 119572: Part: use correct slots for QStatusbar
From:       "Martin Tobias Holmedahl Sandsmark" <martin.sandsmark () kde ! org>
Date:       2014-08-04 12:50:10
Message-ID: 20140804125010.20974.59971 () probe ! kde ! org
[Download RAW message or body]

--===============5477535868858080332==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119572/#review63769
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Tobias Holmedahl Sandsmark


On Aug. 2, 2014, 10:19 a.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119572/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2014, 10:19 a.m.)
> 
> 
> Review request for kdelibs and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: filelight
> 
> 
> Description
> -------
> 
> Part: use correct slots for QStatusbar
> 
> The correct names are showMessage(..) and clearMessage().
> 
> 
> Diffs
> -----
> 
> src/part/part.cpp e63c852151c54018dc5dee448b0bc1367d6ee149 
> 
> Diff: https://git.reviewboard.kde.org/r/119572/diff/
> 
> 
> Testing
> -------
> 
> Warning message is gone when running and file names start appearing in the status \
> bar. 
> 
> Thanks,
> 
> Heiko Becker
> 
> 


--===============5477535868858080332==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119572/">https://git.reviewboard.kde.org/r/119572/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre>  <br />









<p>- Martin Tobias Holmedahl Sandsmark</p>


<br />
<p>On August 2nd, 2014, 10:19 a.m. UTC, Heiko Becker wrote:</p>









<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kdelibs and Martin Tobias Holmedahl Sandsmark.</div>
<div>By Heiko Becker.</div>


<p style="color: grey;"><i>Updated Aug. 2, 2014, 10:19 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
filelight
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Part: use correct slots for QStatusbar</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The correct names are showMessage(..) and clearMessage().</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Warning message is gone when running and file names \
start appearing in the status bar.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/part/part.cpp <span style="color: \
grey">(e63c852151c54018dc5dee448b0bc1367d6ee149)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119572/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============5477535868858080332==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic