[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request 119400: Fish kio: Do not store authentication information in wallet if the user did n
From: José Millán Soto <jmillan () opentia ! com>
Date: 2014-07-22 10:38:01
Message-ID: 20140722103801.14616.52079 () probe ! kde ! org
[Download RAW message or body]
--===============5821075259473373961==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119400/
-----------------------------------------------------------
Review request for kdelibs.
Repository: kio-extras
Description
-------
cacheAuthentication method is being called even if the user did not select the "Remember \
password" checkbox. As a result, the authentication information will be store in the wallet \
even if the user does not want to.
Diffs
-----
fish/fish.cpp 1a79adf
Diff: https://git.reviewboard.kde.org/r/119400/diff/
Testing
-------
Thanks,
José Millán Soto
--===============5821075259473373961==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119400/">https://git.reviewboard.kde.org/r/119400/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By José Millán Soto.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">cacheAuthentication method is being called even if the user did not select the \
"Remember password" checkbox.<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> As a result, the authentication information \
will be store in the wallet even if the user does not want to.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>fish/fish.cpp <span style="color: grey">(1a79adf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119400/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5821075259473373961==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic